patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Alvin Zhang <alvinx.zhang@intel.com>
To: christian.ehrhardt@canonical.com, LingliX.Chen@intel.com
Cc: Alvin Zhang <alvinzhx@intel.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] telemetry: fix race in telemetry control thread creation
Date: Wed, 16 Jun 2021 14:52:41 +0800	[thread overview]
Message-ID: <20210616065241.13352-1-alvinx.zhang@intel.com> (raw)

From: Alvin Zhang <alvinzhx@intel.com>

Before calling thread returns from the function
"rte_ctrl_thread_create", the newly created thread may have ran
and exited for "thread_status" was 0.

This patch puts setting "thread_status" status before creating
new thread.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinzhx@intel.com>
---
 lib/librte_telemetry/rte_telemetry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c
index eb20cc6..98d5f91 100644
--- a/lib/librte_telemetry/rte_telemetry.c
+++ b/lib/librte_telemetry/rte_telemetry.c
@@ -1005,10 +1005,10 @@ struct json_data {
 	}
 	TAILQ_INIT(&static_telemetry->client_list_head);
 
+	static_telemetry->thread_status = 1;
 	ret = rte_ctrl_thread_create(&static_telemetry->thread_id,
 		telemetry_ctrl_thread, &attr, rte_telemetry_run_thread_func,
 		(void *)static_telemetry);
-	static_telemetry->thread_status = 1;
 
 	if (ret < 0) {
 		ret = rte_telemetry_cleanup();
-- 
1.8.3.1


                 reply	other threads:[~2021-06-16  6:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616065241.13352-1-alvinx.zhang@intel.com \
    --to=alvinx.zhang@intel.com \
    --cc=LingliX.Chen@intel.com \
    --cc=alvinzhx@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).