From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5522DA0C41 for ; Wed, 23 Jun 2021 23:26:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 295F14003C; Wed, 23 Jun 2021 23:26:34 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id C1A084003C; Wed, 23 Jun 2021 23:26:32 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 0EB4120B7188; Wed, 23 Jun 2021 14:26:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0EB4120B7188 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624483592; bh=fY1YGNE0o35AuYzlqo3xUhSj4b2cUpPGR909uNTiEx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NrgWX72JzaQZdYHBwasV2RtBjC4TBG70uB3rvg7+DYEnNu8mEfAENZ423kqdK3Or7 3SPNCvIRv5hCeN3d4Dhh/6C1U3QUQ8qs1erM/cI3hwhL4aZTi8TxGZFfv/iQJ/Lak2 TO27FwXkVAybz045K3yUhPTZJof8Gc2eJFf9uNd8= Date: Wed, 23 Jun 2021 14:26:32 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org Message-ID: <20210623212632.GD20289@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1620236174-10676-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-10-git-send-email-jizh@linux.microsoft.com> <20210621023053.07b8a425@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621023053.07b8a425@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-stable] [PATCH v13 09/10] app/testpmd: fix unused function warnings X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Function print_fdir_mask and print_fdir_flex_payload is only called > > when either i40e or ixgbe presents. Add #if defined to remove > > "unused function" compilation warning. > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal Shnaiderman > > --- > > app/test-pmd/config.c | 82 +++++++++++++++++++++---------------------- > > 1 file changed, 41 insertions(+), 41 deletions(-) > > Code inside #ifdef isn't compile-checked, it's better to avoid. > The only case we can't is when i40e or ixgbe API is called directly. > I'd rather remove #ifdef whenever possible and mark maybe-unused entities, > like this: > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 3723317ab4..97a577fec0 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -4488,8 +4488,6 @@ flowtype_to_str(uint16_t flow_type) > return NULL; > } > > -#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) > - > static inline void > print_fdir_mask(struct rte_eth_fdir_masks *mask) > { > @@ -4590,6 +4588,9 @@ get_fdir_info(portid_t port_id, struct rte_eth_fdir_info *fdir_info, > { > int ret = -ENOTSUP; > > + RTE_SET_USED(fdir_info); > + RTE_SET_USED(fdir_stat); > + > #ifdef RTE_NET_I40E > if (ret == -ENOTSUP) { > ret = rte_pmd_i40e_get_fdir_info(port_id, fdir_info); > @@ -4686,8 +4687,6 @@ fdir_get_infos(portid_t port_id) > fdir_stats_border, fdir_stats_border); > } > > -#endif /* RTE_NET_I40E || RTE_NET_IXGBE */ > - > void > fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg) > { > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index d61a055bdd..a40ee902e8 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -917,9 +917,7 @@ int all_ports_stopped(void); > int port_is_stopped(portid_t port_id); > int port_is_started(portid_t port_id); > void pmd_test_exit(void); > -#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) > void fdir_get_infos(portid_t port_id); > -#endif > void fdir_set_flex_mask(portid_t port_id, > struct rte_eth_fdir_flex_mask *cfg); > void fdir_set_flex_payload(portid_t port_id, Hi Dmitry, I agree that should avoid the #ifdef as much as possible. But in this case, I am not quite sure if I followed your comment correctly. Someone originally introduced these i40e and ixgbe related fdir functions (print_fdir_mask, print_fdir_flex_payload, print_fdir_flex_mask, print_fdir_flow_type, get_fdir_info, fdir_get_infos) into testpmd with adding the #if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) for 4 out of 6 functions and left 2 of them outside the #ifdef which caused compilation "unused function" warning. What I did here is just move the starting point of #ifdef to also include those 2 missed functions (print_fdir_mask and print_fdir_flex_payload). IMO the original author would be in better place to reducing the unneccary #ifdef in a proper way.