patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Jie Zhou <jizh@linux.microsoft.com>,
	dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com,
	talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net,
	bruce.richardson@intel.com, ferruh.yigit@intel.com,
	konstantin.ananyev@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings
Date: Thu, 24 Jun 2021 21:44:04 +0300	[thread overview]
Message-ID: <20210624214404.282808cf@sovereign> (raw)
In-Reply-To: <20210624154524.GA22718@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

2021-06-24 08:45 (UTC-0700), Tyler Retzlaff:
> On Wed, Jun 23, 2021 at 02:26:32PM -0700, Jie Zhou wrote:
> > On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote:  
> > > -
> > >  void
> > >  fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg)
> > >  {
> > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> > > index d61a055bdd..a40ee902e8 100644
> > > --- a/app/test-pmd/testpmd.h
> > > +++ b/app/test-pmd/testpmd.h
> > > @@ -917,9 +917,7 @@ int all_ports_stopped(void);
> > >  int port_is_stopped(portid_t port_id);
> > >  int port_is_started(portid_t port_id);
> > >  void pmd_test_exit(void);
> > > -#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE)
> > >  void fdir_get_infos(portid_t port_id);
> > > -#endif
> > >  void fdir_set_flex_mask(portid_t port_id,
> > >                            struct rte_eth_fdir_flex_mask *cfg);
> > >  void fdir_set_flex_payload(portid_t port_id,  
> > 
> > Hi Dmitry, I agree that should avoid the #ifdef as much as possible. But in this case, I am not quite sure if I followed your comment correctly. Someone originally introduced these i40e and ixgbe related fdir functions (print_fdir_mask, print_fdir_flex_payload, print_fdir_flex_mask, print_fdir_flow_type, get_fdir_info, fdir_get_infos) into testpmd with adding the #if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) for 4 out of 6 functions and left 2 of them outside the #ifdef which caused compilation "unused function" warning. What I did here is just move the starting point of #ifdef to also include those 2 missed functions (print_fdir_mask and print_fdir_flex_payload). IMO the original author would be in better place to reducing the unneccary #ifdef in a proper way.  
> 
> i think i have to agree with jie here. there are limits to how many
> defects we should have to correct which are unrelated change. if this is
> critical i think it would be best if the maintainer provide a patch
> cleaning up the code they own.
> 
> let's not hold this patch up over it because of it being a broad change
> we lose a lot of time rebasing where either the maintainer or author
> could follow up with a narrow change to correct this.

Fair enough, the patch doesn't add technical debt at least.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>


  reply	other threads:[~2021-06-24 18:44 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1619805162-10684-1-git-send-email-jizh@linux.microsoft.com>
2021-05-04  0:33 ` [dpdk-stable] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05  8:34     ` Tal Shnaiderman
2021-05-05 16:09       ` Jie Zhou
2021-05-05 16:41         ` [dpdk-stable] [dpdk-dev] " Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-04  0:34   ` [dpdk-stable] [PATCH v10 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-04  7:31   ` [dpdk-stable] [PATCH v10 00/10] app/testpmd: enable " Thomas Monjalon
2021-05-05 16:00     ` Jie Zhou
2021-05-04 23:51   ` Kadam, Pallavi
2021-05-05 17:18   ` [dpdk-stable] [PATCH v11 " Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-05 17:18     ` [dpdk-stable] [PATCH v11 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-05 17:36     ` [dpdk-stable] [PATCH v12 00/10] app/testpmd: enable " Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-05 17:36       ` [dpdk-stable] [PATCH v12 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-05 19:12       ` [dpdk-stable] [PATCH v13 00/10] app/testpmd: enable " Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 02/10] eal/windows: add necessary macros Jie Zhou
2021-06-20 23:28           ` Dmitry Kozlyuk
2021-06-23 20:51             ` Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 03/10] eal/windows: add device event stubs Jie Zhou
2021-06-20 23:28           ` Dmitry Kozlyuk
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-20 23:30           ` Dmitry Kozlyuk
2021-06-23 20:57             ` Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-06-20 23:30           ` Dmitry Kozlyuk
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-06-20 23:30           ` Dmitry Kozlyuk
2021-06-23 20:58             ` Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-06-20 23:30           ` Dmitry Kozlyuk
2021-06-23 21:26             ` Jie Zhou
2021-06-24 15:45               ` [dpdk-stable] [dpdk-dev] " Tyler Retzlaff
2021-06-24 18:44                 ` Dmitry Kozlyuk [this message]
2021-06-24 21:36                   ` Jie Zhou
2021-05-05 19:12         ` [dpdk-stable] [PATCH v13 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-20 23:30           ` Dmitry Kozlyuk
2021-05-06  7:20         ` [dpdk-stable] [PATCH v13 00/10] app/testpmd: enable " Tal Shnaiderman
2021-06-23 22:34         ` [dpdk-stable] [PATCH v14 0/9] " Jie Zhou
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-24 23:10             ` Dmitry Kozlyuk
2021-06-28 10:01             ` Andrew Rybchenko
2021-06-28 10:35               ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-06-28 14:10                 ` Tyler Retzlaff
2021-06-29 18:29                   ` Jie Zhou
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-24 23:10             ` Dmitry Kozlyuk
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-24 23:10             ` Dmitry Kozlyuk
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-06-28 10:55             ` Andrew Rybchenko
2021-06-28 14:29               ` [dpdk-stable] [dpdk-dev] " Tyler Retzlaff
2021-06-29 18:34                 ` Jie Zhou
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-24 23:10             ` Dmitry Kozlyuk
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-24 23:10             ` Dmitry Kozlyuk
2021-06-23 22:34           ` [dpdk-stable] [PATCH v14 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-29 20:23           ` [dpdk-stable] [PATCH v15 0/9] app/testpmd: enable " Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-29 20:23             ` [dpdk-stable] [PATCH v15 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-29 20:50             ` [dpdk-stable] [PATCH v16 0/9] app/testpmd: enable " Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-07-01 13:41                 ` Andrew Rybchenko
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-07-01 13:34                 ` Andrew Rybchenko
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-29 20:50               ` [dpdk-stable] [PATCH v16 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-07-01 13:49               ` [dpdk-stable] [PATCH v16 0/9] app/testpmd: enable " Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624214404.282808cf@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jizh@linux.microsoft.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=pallavi.kadam@intel.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=roretzla@microsoft.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).