From: Joyce Kong <joyce.kong@arm.com>
To: beilei.xing@intel.com, qi.z.zhang@intel.com,
ruifeng.wang@arm.com, honnappa.nagarahalli@arm.com,
bruce.richardson@intel.com, helin.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, nd@arm.com
Subject: [dpdk-stable] [PATCH v3 1/2] net/i40e: add logic of processing continuous DD bits for Arm
Date: Tue, 6 Jul 2021 01:54:03 -0500 [thread overview]
Message-ID: <20210706065404.25137-2-joyce.kong@arm.com> (raw)
In-Reply-To: <20210706065404.25137-1-joyce.kong@arm.com>
For Arm platforms, reading descs can get re-ordered, then the
status of DD bits will be discontinuous, so add the logic to
only process continuous descs by checking DD bits.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
drivers/net/i40e/i40e_rxtx.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 6c58decec..9aaabfd92 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -452,7 +452,7 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)
uint16_t pkt_len;
uint64_t qword1;
uint32_t rx_status;
- int32_t s[I40E_LOOK_AHEAD], nb_dd;
+ int32_t s[I40E_LOOK_AHEAD], var, nb_dd;
int32_t i, j, nb_rx = 0;
uint64_t pkt_flags;
uint32_t *ptype_tbl = rxq->vsi->adapter->ptype_tbl;
@@ -485,8 +485,18 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)
rte_smp_rmb();
/* Compute how many status bits were set */
- for (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++)
- nb_dd += s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT);
+ for (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++) {
+ var = s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT);
+#ifdef RTE_ARCH_ARM
+ /* For Arm platforms, only compute continuous status bits */
+ if (var)
+ nb_dd += 1;
+ else
+ break;
+#else
+ nb_dd += var;
+#endif
+ }
nb_rx += nb_dd;
--
2.17.1
next prev parent reply other threads:[~2021-07-06 6:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210604073405.14880-1-joyce.kong@arm.com>
2021-06-23 8:43 ` [dpdk-stable] [PATCH v2] " Joyce Kong
2021-06-30 1:14 ` Honnappa Nagarahalli
2021-07-05 3:41 ` Joyce Kong
2021-07-06 6:54 ` [dpdk-stable] [PATCH v3 0/2] fixes for i40e hw scan ring Joyce Kong
2021-07-06 6:54 ` Joyce Kong [this message]
2021-07-09 3:05 ` [dpdk-stable] [PATCH v3 1/2] net/i40e: add logic of processing continuous DD bits for Arm Zhang, Qi Z
2021-07-06 6:54 ` [dpdk-stable] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence Joyce Kong
2021-07-08 12:09 ` Zhang, Qi Z
2021-07-08 13:51 ` [dpdk-stable] [dpdk-dev] " Lance Richardson
2021-07-08 14:26 ` Zhang, Qi Z
2021-07-08 14:44 ` Honnappa Nagarahalli
2021-07-13 0:46 ` [dpdk-stable] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706065404.25137-2-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=qi.z.zhang@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).