From: Michael Baum <michaelba@nvidia.com> To: <dev@dpdk.org> Cc: Matan Azrad <matan@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, "Ori Kam" <orika@nvidia.com>, <stable@dpdk.org> Subject: [dpdk-stable] [PATCH_v4 3/3] regex/mlx5: fix redundancy in PCI remove function Date: Mon, 12 Jul 2021 10:06:44 +0300 Message-ID: <20210712070644.2848418-4-michaelba@nvidia.com> (raw) In-Reply-To: <20210712070644.2848418-1-michaelba@nvidia.com> In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: stable@dpdk.org Signed-off-by: Michael Baum <michaelba@nvidia.com> --- drivers/regex/mlx5/mlx5_regex.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device *pci_dev) rte_regexdev_unregister(priv->regexdev); if (priv->ctx) mlx5_glue->close_device(priv->ctx); - if (priv->regexdev) - rte_regexdev_unregister(priv->regexdev); rte_free(priv); } return 0; -- 2.25.1
next prev parent reply other threads:[~2021-07-12 7:07 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-28 19:23 [dpdk-stable] [PATCH 1/3] regex/mlx5: fix memory region unregistration Michael Baum 2021-06-28 19:23 ` [dpdk-stable] [PATCH 2/3] regex/mlx5: fix leak in PCI remove function Michael Baum 2021-06-28 19:23 ` [dpdk-stable] [PATCH 3/3] regex/mlx5: fix redundancy " Michael Baum 2021-06-30 5:52 ` [dpdk-stable] [PATCH 1/3] regex/mlx5: fix memory region unregistration Matan Azrad 2021-07-05 5:27 ` [dpdk-stable] [PATCH_v2 " Michael Baum 2021-07-05 5:27 ` [dpdk-stable] [PATCH_v2 2/3] regex/mlx5: fix leak in PCI remove function Michael Baum 2021-07-05 5:27 ` [dpdk-stable] [PATCH_v2 3/3] regex/mlx5: fix redundancy " Michael Baum [not found] ` <20210707120303.2490006-1-michaelba@nvidia.com> 2021-07-07 12:03 ` [dpdk-stable] [PATCH_v3 1/3] regex/mlx5: fix memory region unregistration Michael Baum [not found] ` <20210712070644.2848418-1-michaelba@nvidia.com> 2021-07-12 7:06 ` [dpdk-stable] [PATCH_v4 " Michael Baum 2021-07-21 6:25 ` Ori Kam 2021-07-12 7:06 ` [dpdk-stable] [PATCH_v4 2/3] regex/mlx5: fix leak in PCI remove function Michael Baum 2021-07-21 6:21 ` [dpdk-stable] [dpdk-dev] " Ori Kam 2021-07-12 7:06 ` Michael Baum [this message] 2021-07-21 6:23 ` [dpdk-stable] [PATCH_v4 3/3] regex/mlx5: fix redundancy " Ori Kam 2021-07-07 12:03 ` [dpdk-stable] [PATCH_v3 2/3] regex/mlx5: fix leak " Michael Baum 2021-07-07 12:03 ` [dpdk-stable] [PATCH_v3 3/3] regex/mlx5: fix redundancy " Michael Baum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210712070644.2848418-4-michaelba@nvidia.com \ --to=michaelba@nvidia.com \ --cc=dev@dpdk.org \ --cc=matan@nvidia.com \ --cc=orika@nvidia.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git