From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36CCCA0C4C for ; Mon, 12 Jul 2021 15:12:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E1A44069D; Mon, 12 Jul 2021 15:12:22 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id F088E4069D for ; Mon, 12 Jul 2021 15:12:19 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id a13so25534397wrf.10 for ; Mon, 12 Jul 2021 06:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nabXke5/+oM1vXnr9gGdysWNvE80A+jIWDOcUzLFXaQ=; b=uXiewn2jwn/Sl0w74lCpoLvniQp0zR/yg38bhgLYHUgxiqG0YTNFjdxS/Ou/Wrmz/X 8ObdJ4LccbnIZA7HBWxorUzOV20crnBMjfk4HEXivuGSi35ZQftz4rUj9qcjjMeLpWwL jf95c1a83bYhNHrR3FVngM+iyVhcMON76VY5R7Xcbob9F2iYmPzr/XZurSbn/6VTHT12 zlOvwqBp/RaWZDrOIUnb6cTEEPHEN1kADMJF2G+D9lJWT1wiQLcRACu09T+XGrBpuJ4n SLnsf6EPTlO0aV9iCpN7A9uqkCd7VV793wz4HqmD9fgXb0nPNVxP8bIzht5ap3hJkMtp Lx1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nabXke5/+oM1vXnr9gGdysWNvE80A+jIWDOcUzLFXaQ=; b=ACMY9KUHsg3gJ4mbdR5I+adOQTOay/9tqxlYlZSYJ7HMPPpH4UHuBLr7TYRXi6l3QS ujy0H9lx/kO20jUSz2RuSUwLouA2xJl+HLEsc7sJbFTYNCw+EqMZes2eEiNp75km03um wsrAqbutmtQGfEEriqrKiu6VLCUiaMQvOpYxeP9/UxxcdtuXSC9vjZSDooEHRFbqQOQx zPLA5cicl9tG0othP+trBDDWXFlPFzquiZIO60SbkeabQEFoOotmhbySPMfYVpZ9G0Er Xet9AwOhbOBEQbpfhDTCLiJUsy9wqIIFfmfiE1CO+Nq3ELTLnoz+SAjxHbXRwEDmy6Mm Hotw== X-Gm-Message-State: AOAM530S3tlzrRoxE1B5R3UZEwjju2SNp7qg8ixm0VCOANlcZiL/VRg0 MJHoUJNUouPDmq5umTOqxSY= X-Google-Smtp-Source: ABdhPJyjy90LTc9ACFftKdljaNskIYyqs1dASrk2vI7cOv2GTHtUe1bn8NJ2M9gds6aKRpCFC1ye3A== X-Received: by 2002:adf:a1c2:: with SMTP id v2mr34954000wrv.155.1626095539659; Mon, 12 Jul 2021 06:12:19 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id p2sm11883126wma.27.2021.07.12.06.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:12:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Lance Richardson Cc: David Marchand , dpdk stable Date: Mon, 12 Jul 2021 14:04:37 +0100 Message-Id: <20210712130551.2462159-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/test: fix IPv6 header initialization' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/60c3dfd45f8ac5b248dd08acf73d93705908472a Thanks. Luca Boccassi --- >From 60c3dfd45f8ac5b248dd08acf73d93705908472a Mon Sep 17 00:00:00 2001 From: Lance Richardson Date: Fri, 26 Mar 2021 12:37:32 -0400 Subject: [PATCH] app/test: fix IPv6 header initialization [ upstream commit a906371d2758df7260640873d93f888724759448 ] Fix two issues found when writing PMD unit tests for HW ptype and L4 checksum offload: - The version field in the IPv6 header was being set to zero, which prevented hardware from recognizing it as IPv6. The IP version field is now set to six. - The payload_len field was being initialized using host byte order, which (among other things) resulted in incorrect L4 checksum computation. The payload_len field is now set using network (big-endian) byte order. Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Lance Richardson Reviewed-by: David Marchand --- app/test/packet_burst_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c index c05ea7ad51..0fd7290b0e 100644 --- a/app/test/packet_burst_generator.c +++ b/app/test/packet_burst_generator.c @@ -142,8 +142,8 @@ uint16_t initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, uint8_t *dst_addr, uint16_t pkt_data_len) { - ip_hdr->vtc_flow = 0; - ip_hdr->payload_len = pkt_data_len; + ip_hdr->vtc_flow = rte_cpu_to_be_32(0x60000000); /* Set version to 6. */ + ip_hdr->payload_len = rte_cpu_to_be_16(pkt_data_len); ip_hdr->proto = IPPROTO_UDP; ip_hdr->hop_limits = IP_DEFTTL; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:38.844270543 +0100 +++ 0042-app-test-fix-IPv6-header-initialization.patch 2021-07-12 13:41:36.334119361 +0100 @@ -1 +1 @@ -From a906371d2758df7260640873d93f888724759448 Mon Sep 17 00:00:00 2001 +From 60c3dfd45f8ac5b248dd08acf73d93705908472a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a906371d2758df7260640873d93f888724759448 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org