From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99369A0C4C for ; Mon, 12 Jul 2021 15:07:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8226E4069E; Mon, 12 Jul 2021 15:07:48 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 4F7584069E for ; Mon, 12 Jul 2021 15:07:47 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id w13so11375333wmc.3 for ; Mon, 12 Jul 2021 06:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=se42BCzTv1auqwhnDZMwOZjXH1OPI89maEnTv/wp034=; b=JTE7+Pg07sjGDw15UH1O6dXh6wJ6ZlnXxOSyoysgmHUpihSi2GXMyS/9+aq6KPmN3O EbXgS+d6bHrh1D3eVebHOJwqWT0WorcsDHenEDc+hzPdDJ4wjEJSXVbdCTkARhGLkhWi Ne8CkWHn/8m1rHSlKsHsQVE7MeHlffyBnJlc2eET5kaJuGA+oT8p1UQz8i5b9fXa0DgE bp77Id3/42tUeu04YrbsiLV1f2evvy6JSjmzLBPWh0WERDVNTDgr2+pbKQIZjWXlx6Pd Ar2Fnk/TNoQiRELN7S9De+6au9EvzYh4pDgHxTdYu1yk01aInQhBehN6JbsbVT2aSOzG 7f8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=se42BCzTv1auqwhnDZMwOZjXH1OPI89maEnTv/wp034=; b=LwZe2xSEUdtae0PZKRe+P8WVuDXL9LePm/gmzuqkO/FXlwAMfB8iY/wuOZnTfLu4y+ nSLdItWsPr3nhRrxSj9/trbjtFt+PSl4/FW/dkzxbylJKJndIQWmIvj5TppKHg1jMeSx u6BEKbZvmVJLUaNNjhylcEvSkFsX8wbxcIOFSQlY1adGrwMNZzkt/86dnVDDLoaOYuuq pRxNdYh13WdJaX+LF2PLFsFXZaGJUZdFcHWy2iyjArSvxh9Lod9ldIj62VfRrCkNi8xN tt/iMudYeDo2PtUKhnOppR/f8CNv0/IU1Aev6f5a1p4PMREITCsJy70oYSLb/8RHuCx5 22nA== X-Gm-Message-State: AOAM53014a425nvvE7j5AxBOslGP0tGwy8MrBfT7slIWkYAPX8iV1ksp i6kbutY3NXGbWwkMFxpk/+Q= X-Google-Smtp-Source: ABdhPJxk/5CC5fvn3DPDYQxWFo4KT08MAT5fRDLyYuJiZlmHxFY72EBRU3R1ej1Mt25cNEnahFaFJA== X-Received: by 2002:a1c:63d6:: with SMTP id x205mr6507689wmb.42.1626095267113; Mon, 12 Jul 2021 06:07:47 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id m4sm6475235wrs.14.2021.07.12.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:07:37 -0700 (PDT) From: luca.boccassi@gmail.com To: Thierry Herbelot Cc: Ajit Khaparde , dpdk stable Date: Mon, 12 Jul 2021 14:04:00 +0100 Message-Id: <20210712130551.2462159-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: check access to possible null pointer' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d19b2017fcb5436c280e540eb4039f7aa28d1500 Thanks. Luca Boccassi --- >From d19b2017fcb5436c280e540eb4039f7aa28d1500 Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 24 May 2021 11:00:38 +0200 Subject: [PATCH] net/bnxt: check access to possible null pointer [ upstream commit dc59260fb68960ab4296d974370594f6ea31ab9f ] Check that pointers are valid before using them. Fixes: 7bc8e9a227ccb ("net/bnxt: support async link notification") Signed-off-by: Thierry Herbelot Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index 40e1b0c980..93779f4e0c 100644 --- a/drivers/net/bnxt/bnxt_irq.c +++ b/drivers/net/bnxt/bnxt_irq.c @@ -21,11 +21,14 @@ void bnxt_int_handler(void *param) { struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param; struct bnxt *bp = eth_dev->data->dev_private; - struct bnxt_cp_ring_info *cpr = bp->async_cp_ring; + struct bnxt_cp_ring_info *cpr; struct cmpl_base *cmp; uint32_t raw_cons; uint32_t cons; + if (bp == NULL) + return; + cpr = bp->async_cp_ring; if (cpr == NULL) return; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:37.156257098 +0100 +++ 0005-net-bnxt-check-access-to-possible-null-pointer.patch 2021-07-12 13:41:36.158115694 +0100 @@ -1 +1 @@ -From dc59260fb68960ab4296d974370594f6ea31ab9f Mon Sep 17 00:00:00 2001 +From d19b2017fcb5436c280e540eb4039f7aa28d1500 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dc59260fb68960ab4296d974370594f6ea31ab9f ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 8abbadb3d1..fd8b8fac98 100644 +index 40e1b0c980..93779f4e0c 100644