From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D903A0C4C for ; Mon, 12 Jul 2021 15:13:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 255484069D; Mon, 12 Jul 2021 15:13:55 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id F10F340685 for ; Mon, 12 Jul 2021 15:13:53 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id w13so11389123wmc.3 for ; Mon, 12 Jul 2021 06:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iP6AgES8qg5SQi44ospJ/K7GwmzM73cHllBGiJVkimM=; b=PSaj+RS+DIekLdZgodrayvB/hF+7ipSktMpMYLD88yPQTEAKsEStamymHgbI4PWA8P WobPtjYswskzXnm2l40bWCTS3Q5TrXWwMGCK6RSYncrkK6o4NGw2tfv46FYaX42K0lLe 840Kedb1z6xtCRHl96RKDRgia1Ukraa7RLPH/ODUE9fwG11S6QLTz7/UfKU0T05u8eFc ol34rekomBZ5CUQKO9JYdP7vOS2X3kOwQEYWJuGDLtC4MMz8BR0fKMSX6UaDVUPHxOWs W/HeeduhgFAg5tmxKdnXya35lNegYartI34DOwg1KP6yNDqYGkj1u2g1lKZlii5kVVv8 0ANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iP6AgES8qg5SQi44ospJ/K7GwmzM73cHllBGiJVkimM=; b=sHGYltQQ2u70xHATiAeY4MVLiK7jYPft4a7uA88bk09ujhMYdyHteRDkQW/lMx0Pr/ dtuAaT8OdeEI+BCZINOPMZXYn4C+JS69oOUlRJsMeuyzIr9C4UdifNpYQKn+Z68CKoy9 Lct45VjtTash70MWFYN6sCY10EBb8ikGe3plm3WuOTMZSmUpyvWn0uh75jagFakIMguV 9xnUsNVaxW8zIUaIylmzmShabsGZCNCioikAGUDBo8iGzQVDS285fAuLWQaf3k6AiTbG H05DZuwOyGdquNJPCy/BxqI3HF+DAu6T5e33KDNBYeb7aeGCZKYG0wTyhYuXeFrHPNzW cBMw== X-Gm-Message-State: AOAM5310tALadrE2o0Rp1pFNr8chrA8nj/aAfCprOE9VUPmQMQ2EKh8h XbWD6exgW3qSW5gU6RnHjbw= X-Google-Smtp-Source: ABdhPJyrnowasdV6RdfzSqOV9CqCsKccdCGU2cKz67japwxgyCjh4a40vw687AnmDhUY26SliZavPw== X-Received: by 2002:a05:600c:1c0d:: with SMTP id j13mr1236123wms.34.1626095633716; Mon, 12 Jul 2021 06:13:53 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id o29sm10925057wms.13.2021.07.12.06.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:13:53 -0700 (PDT) From: luca.boccassi@gmail.com To: Huisong Li Cc: Min Hu , Ferruh Yigit , Xiaoyun Li , dpdk stable Date: Mon, 12 Jul 2021 14:05:06 +0100 Message-Id: <20210712130551.2462159-71-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: change port link speed without stopping all' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c09b86adc2fa56e3ff3354b5dd63c30294b4899f Thanks. Luca Boccassi --- >From c09b86adc2fa56e3ff3354b5dd63c30294b4899f Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Wed, 28 Apr 2021 16:36:59 +0800 Subject: [PATCH] app/testpmd: change port link speed without stopping all [ upstream commit 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 ] When we use the following cmd to modify the link speed of specified port: "port config speed xxx duplex xxx", we have to stop all ports. It's not necessary. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Acked-by: Ferruh Yigit Acked-by: Xiaoyun Li --- app/test-pmd/cmdline.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index e28d068cd2..113e27b603 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1607,14 +1607,14 @@ cmd_config_speed_specific_parsed(void *parsed_result, struct cmd_config_speed_specific *res = parsed_result; uint32_t link_speed; - if (!all_ports_stopped()) { - printf("Please stop all ports first\n"); - return; - } - if (port_id_is_invalid(res->id, ENABLED_WARN)) return; + if (!port_is_stopped(res->id)) { + printf("Please stop port %d first\n", res->id); + return; + } + if (parse_and_check_speed_duplex(res->value1, res->value2, &link_speed) < 0) return; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:40.358831928 +0100 +++ 0071-app-testpmd-change-port-link-speed-without-stopping-.patch 2021-07-12 13:41:36.626125444 +0100 @@ -1 +1 @@ -From 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 Mon Sep 17 00:00:00 2001 +From c09b86adc2fa56e3ff3354b5dd63c30294b4899f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index bfd2fb9240..8468018cf3 100644 +index e28d068cd2..113e27b603 100644 @@ -25 +26 @@ -@@ -1619,14 +1619,14 @@ cmd_config_speed_specific_parsed(void *parsed_result, +@@ -1607,14 +1607,14 @@ cmd_config_speed_specific_parsed(void *parsed_result,