From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47576A0C4C for ; Mon, 12 Jul 2021 15:13:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 413D940685; Mon, 12 Jul 2021 15:13:57 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 08C3240685 for ; Mon, 12 Jul 2021 15:13:55 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id m2so14531906wrq.2 for ; Mon, 12 Jul 2021 06:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D3DG2UagXpRLbExnDt9HDn34hloey9YOwHAuwQEkExc=; b=kRxnLZpEM4YhFqeFTJ+H26gu/gMIS987EpMwXQGNAejQWqIZjKQKbwPfKgvZEUHvzN ZABQHAuTKF0E2m1RkZWTQ35Ge78N7g396MZ20kXGr+7B+YHUAmb9hyZa8HDZxMWvfy4e 9ZEcP7iaKqyYpmqQ7uaSJKtjBGvy6zUSNyNC3YXkC3dID8FHwFpSC3a16OQJsQqiCztM 1bXWT7zsiihz9soBc00cQj/ynm4+fmu2zidC8BysCWgmYte+1BCAd0gVfFOUvgJWz9Zv L5kw8pWmpQfqiEZ7ORy6Vt/ZbTs3mKBWWKqhvHwMDREKv3uGtM7Bd/d7Cqtcf8oRz/Pp +K0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D3DG2UagXpRLbExnDt9HDn34hloey9YOwHAuwQEkExc=; b=c4Xnx6HEw6Vb4mDNlbEXqbcRNyp+7Xq8jGNDr7OqZTtL9wkrGptU5tInEly4rG/fcA EAUhThGvvLbHOGCrMFKqgq2BRakV7Sa6UunnHcC2EsWp/Y4A4hGskABpuZIe/81cLPe6 W941Bsg6QJUOB7vdXLiv290ohEqjk2dkSpuCjm8p+5HIIjoZXT8gWq7bPllyXB03xwRi O2PHu40mZO9RnNno/Q/guJ5c2XdF6Phx1GFuyCO+N9/k5Xg0Qfpse3T54BvIu5ZK0qe6 xXER3scFVpX4LC0oXmrGZveToCF99d5CUD4aQBpDm3zBM/tddGjW/HEdX3wjALgxpQ7n yO6A== X-Gm-Message-State: AOAM530Y9t4nG4FhtYKpbzPYcZd8L9VNjJbhfRER0aZqp8Oa4KcinzOp gZeQpsl5ExcejJC2zYwefuBLEeAC+6nBk2SB X-Google-Smtp-Source: ABdhPJzFCevuoo/P7jzk7CReji1ci44KxFDtHZGbdij6lS/5J3+f8BL0o0sCm3C3vsZ8YBCJ8WoWSw== X-Received: by 2002:adf:eb43:: with SMTP id u3mr59515141wrn.83.1626095634843; Mon, 12 Jul 2021 06:13:54 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id l15sm4119056wrv.87.2021.07.12.06.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:13:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Feifei Wang Cc: Ruifeng Wang , Honnappa Nagarahalli , Adam Dybkowski , dpdk stable Date: Mon, 12 Jul 2021 14:05:07 +0100 Message-Id: <20210712130551.2462159-72-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'crypto/qat: fix Arm build with special memcpy' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/55fa4d96382b429a660a3c515906354e6c24259e Thanks. Luca Boccassi --- >From 55fa4d96382b429a660a3c515906354e6c24259e Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Fri, 21 May 2021 10:00:04 +0800 Subject: [PATCH] crypto/qat: fix Arm build with special memcpy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit c316efc3cf90fba1b673373669096ad6a3e39cc4 ] In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, gcc will report variable uninitialized warning: ../drivers/crypto/qat/qat_sym_session.c: In function ‘partial_hash_compute’: ../lib/eal/include/generic/rte_byteorder.h:241:24: warning: ‘’ may be used uninitialized in this function [-Wmaybe-uninitialized] 241 | #define rte_bswap32(x) __builtin_bswap32(x) ... This is because "digest" will be initialized by "rte_memcpy" function rather than "memcpy" if "RTE_ARCH_ARM64_MEMCPY" is set as true. Furthermore, 'rte_memcpy' will initialize 'digest' with two steps by invoking rte_mov_x functions. For example: partial_hash_sha1 -> rte_memcpy -> rte_memcpy_ge16_lt_128 -> step 1: rte_mov16(dst,src ) step 2: rte_mov16(dst - 16 + n, src - 16 + n) However, gcc compiler cannot identify this multi-step initialization, then it will report warning. To fix this, use "memset" to initialize "digest". Fixes: cd7fc8a84b48 ("eal/arm64: optimize memcpy") Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym_session.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 23d059bf84..6e2193fb69 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -1190,6 +1190,9 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo hash_alg, uint64_t *hash_state_out_be64; int i; + /* Initialize to avoid gcc warning */ + memset(digest, 0, sizeof(digest)); + digest_size = qat_hash_get_digest_size(hash_alg); if (digest_size <= 0) return -EFAULT; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:40.417666831 +0100 +++ 0072-crypto-qat-fix-Arm-build-with-special-memcpy.patch 2021-07-12 13:41:36.630125527 +0100 @@ -1 +1 @@ -From c316efc3cf90fba1b673373669096ad6a3e39cc4 Mon Sep 17 00:00:00 2001 +From 55fa4d96382b429a660a3c515906354e6c24259e Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit c316efc3cf90fba1b673373669096ad6a3e39cc4 ] + @@ -34 +35,0 @@ -Cc: stable@dpdk.org @@ -45 +46 @@ -index 231b1640da..e22dd3600c 100644 +index 23d059bf84..6e2193fb69 100644 @@ -48 +49 @@ -@@ -1196,6 +1196,9 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo hash_alg, +@@ -1190,6 +1190,9 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo hash_alg,