From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68964A0C4C for ; Mon, 12 Jul 2021 15:14:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B9AD4069D; Mon, 12 Jul 2021 15:14:26 +0200 (CEST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 1E92540685 for ; Mon, 12 Jul 2021 15:14:25 +0200 (CEST) Received: by mail-wr1-f51.google.com with SMTP id d12so24933876wre.13 for ; Mon, 12 Jul 2021 06:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mbfMhbgRrej73uu9dmI6HtPiphAMK4xjb0hkSuIfckI=; b=Rs2U0W+cZi82BjEQsenfWbSHXinkW7F2BUaYpPo36Vj6ixW8i9SfuPgkcuv9IRB8Uc zLjb1gAhY55v+kPBTv1KmhvKqg0PegcPJwqook3ybz0PaPD6uFMBYm492c7l/PvxyfbQ 52+DNIxqPB5ufq6O1ZbL6O3CJ8ZP716GCRLGZSGWJ6RAfNMaHG7LC53p5um6otpufJMS D6UV6OBz19McHCFmUbrWVplztwmMWhyBL1eW1IzcanXDqz/1tRgPqTCf5UxIe806kvbj pJpzEKdvUEnv3MFNDaZv8U7bvecZtbxTEzMxLphu3pRfMv+wo9115IjApQUZQFNSP7+E B8Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mbfMhbgRrej73uu9dmI6HtPiphAMK4xjb0hkSuIfckI=; b=rGHXsUKncSXaQu1JcB+NItyYu6GKInojD+ASMPYJxezrdt1K+SoJOyNuoVtYcvkF+E liBBMzcA+AD9qzk23P3BNzvI9DJ0u5y6bzFmZE0olnp7ImgbACd6Vj2q2ysZtxwXHNOF 0hMBO2l1Is2jI40qPFdCIffmj2dRMI4KjnGyz0yj6l508YUvxnxwhNl2EQ4V/cWylCpy YgJew34S607zaRVvMOP/mIDz0ZHSsVoW4kL9FwM+7JhyPQkwCg6ZxrEhSN1B2cVoOX2j NcprSg/xOpLty85v5eXd2vNCuSBrGrsH6a8MQZu6Jl+ofqelogyX0BpmZZS+DaZTJTn0 yfIQ== X-Gm-Message-State: AOAM531p6sgEhcsL1kRRnc6ShSd6srSlsvHU5mJZaJRKeOqqkabTOz1D FRxuz8e/m7R1Awd0LI26G8A= X-Google-Smtp-Source: ABdhPJwNtZ5+bUU4gUcnXdRbvyPGMazb8pd5JGe8xKRffUtGfWr4R4F2eoOfQ8M2mqDxVM869LRnAw== X-Received: by 2002:a5d:6850:: with SMTP id o16mr24986468wrw.319.1626095664957; Mon, 12 Jul 2021 06:14:24 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id j12sm14896346wrq.83.2021.07.12.06.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:14:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Dana Vardi Cc: Michael Shamis , Liron Himi , dpdk stable Date: Mon, 12 Jul 2021 14:05:16 +0100 Message-Id: <20210712130551.2462159-81-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'crypto/mvsam: fix session data reset' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9bf79cbfafc52bf852cd9110357c9a0cd1c75911 Thanks. Luca Boccassi --- >From 9bf79cbfafc52bf852cd9110357c9a0cd1c75911 Mon Sep 17 00:00:00 2001 From: Dana Vardi Date: Thu, 1 Jul 2021 09:59:20 +0300 Subject: [PATCH] crypto/mvsam: fix session data reset [ upstream commit 03e73e8572f112bd3714cd90c491a6570330189c ] This patch fix wrong clear memory session pointer. When call mrvl_crypto_pmd_sym_session_clear function, it might cause the following error: CRYPTODEV: set_sym_session_private_data() line 497: Set private data for driver 1 not allowed This fix set zeroes to mrvl_crypto_session pointer instead to rte_cryptodev_sym_session pointer, and will verify that rte_cryptodev_sym_session pointer will not lose data such as nb_drivers. Bugzilla ID: 646 Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver") Signed-off-by: Dana Vardi Reviewed-by: Michael Shamis Reviewed-by: Liron Himi --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c index 527ddef0cf..4eb7ec97d1 100644 --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c @@ -793,7 +793,7 @@ mrvl_crypto_pmd_sym_session_clear(struct rte_cryptodev *dev, MRVL_LOG(ERR, "Error while destroying session!"); } - memset(sess, 0, sizeof(struct mrvl_crypto_session)); + memset(mrvl_sess, 0, sizeof(struct mrvl_crypto_session)); struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); set_sym_session_private_data(sess, index, NULL); rte_mempool_put(sess_mp, sess_priv); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:40.835248061 +0100 +++ 0081-crypto-mvsam-fix-session-data-reset.patch 2021-07-12 13:41:36.698126943 +0100 @@ -1 +1 @@ -From 03e73e8572f112bd3714cd90c491a6570330189c Mon Sep 17 00:00:00 2001 +From 9bf79cbfafc52bf852cd9110357c9a0cd1c75911 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 03e73e8572f112bd3714cd90c491a6570330189c ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org