From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 658FEA0C4C for ; Mon, 12 Jul 2021 15:15:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6068A4069D; Mon, 12 Jul 2021 15:15:02 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id CA25F40685 for ; Mon, 12 Jul 2021 15:15:00 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id d12so24936556wre.13 for ; Mon, 12 Jul 2021 06:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xP3ICvOueOOf/4R6tZJAYc8q0D0oufKD3MB6c/uj6Fs=; b=QGfx6rYJ5XtX6nctW6qmdBOassKK9FcVX/FQ2FSrenKUGAz4fIk0nt9h6qV+3R5ACm XL6mkDhFhYc8brDVDYpkw0w9QQZ2HPW1Z4Q/H6254C3kA1GrICX+fePvwqNpQOMiG0QM ZpNRtxpzwuoavso9JHSDMjyKptyQWPvrcWRA2hf+HERJiLpFAL/zK1snHUexFyiQn225 jmT4e3cOGJtNEOpL9+0ZV6jaiINykJy6hciDBwE7gvzlIj/MptjbCCvT8+m6RLdTHwvD tfTnAMzcnYzZ+oYiZ2Ck9CJiEJDW6GLcZmL5nBRVxt7zYkTCIzUSbYvsk+2X7zmJYnTA CtDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xP3ICvOueOOf/4R6tZJAYc8q0D0oufKD3MB6c/uj6Fs=; b=frqha6x1jGfcPjn2yhkbkbX0oQL8912mhAfA76Rw7GEZ0l+Fro5yNSF9UbXoPHlFaU t8cOouePyXmWK60igr1oe/1hlwxQdqDKx/+SwNhCCAvnyzH6TtmqsDSuOonGAV88HtR9 80X6OgoxSglhMQmQ925v1R/sqD2IZleUdqppU0Bw1C1CotugxTCuw6nIRrdBFnEZo3UC pShoFKr4RGZdIe6Isy0t9mqvuXq18mdDl/1z5qIHDnzzsUOxaDbKhzeiv9zlW5C4//0R ioqHc0aVnB4wpQP23Lsy88DJtWF/62JkBeNIjNVsMSmyacssNOEFxBmk6KjvYf/j9Xd6 Zwsw== X-Gm-Message-State: AOAM531GC13IgYAqdAZhZxpA9D6Xwx+BTnTVfOdyjjb4OuQjIkxeFi56 TKNrDqem3A3QbnQ0NDv7Mkg= X-Google-Smtp-Source: ABdhPJy1CrQIh4MHfPlpP0YLyjTluKucut3eO1EB1rmZh/Apv4QC4Ht9qoYgDLExLq9tZkj1niIbgg== X-Received: by 2002:adf:f74f:: with SMTP id z15mr14524245wrp.54.1626095700657; Mon, 12 Jul 2021 06:15:00 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id k20sm13264194wrd.70.2021.07.12.06.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:15:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Dmitry Kozlyuk Cc: Viacheslav Ovsiienko , dpdk stable Date: Mon, 12 Jul 2021 14:05:30 +0100 Message-Id: <20210712130551.2462159-95-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'doc: add limitation for ConnectX-4 with L2 in mlx5 guide' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/222e82452dad164d61a97f7767c2aafbbaa0e4f7 Thanks. Luca Boccassi --- >From 222e82452dad164d61a97f7767c2aafbbaa0e4f7 Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Wed, 30 Jun 2021 10:01:06 +0300 Subject: [PATCH] doc: add limitation for ConnectX-4 with L2 in mlx5 guide [ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ] ConnectX-4 and ConnectX-4 Lx NICs require all L2 headers of transmitted packets to be inlined. By default only first 18 bytes are inlined, which is insufficient if additional encapsulation is used, like Q-in-Q. Thus, default settings caused such traffic to be dropepd on Tx. Document a recommendation to increase inlined data size in such cases. Fixes: 505f1fe426d3 ("net/mlx5: add Tx devargs") Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 24d5a69227..78bf829fe5 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -591,6 +591,13 @@ Driver options it is not recommended and may prevent NIC from sending packets over some configurations. + For ConnectX-4 and ConnectX-4 Lx NICs, automatically configured value + is insufficient for some traffic, because they require at least all L2 headers + to be inlined. For example, Q-in-Q adds 4 bytes to default 18 bytes + of Ethernet and VLAN, thus ``txq_inline_min`` must be set to 22. + MPLS would add 4 bytes per label. Final value must account for all possible + L2 encapsulation headers used in particular environment. + Please, note, this minimal data inlining disengages eMPW feature (Enhanced Multi-Packet Write), because last one does not support partial packet inlining. This is not very critical due to minimal data inlining is mostly required -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:41.481244720 +0100 +++ 0095-doc-add-limitation-for-ConnectX-4-with-L2-in-mlx5-gu.patch 2021-07-12 13:41:36.794128943 +0100 @@ -1 +1 @@ -From e60561cc955ac01512a35ca309793e351cef3c9b Mon Sep 17 00:00:00 2001 +From 222e82452dad164d61a97f7767c2aafbbaa0e4f7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 0d96eec2bb..5b4bb13914 100644 +index 24d5a69227..78bf829fe5 100644 @@ -25 +26 @@ -@@ -700,6 +700,13 @@ Driver options +@@ -591,6 +591,13 @@ Driver options