From: Jie Wang <jie1x.wang@intel.com>
To: dev@dpdk.org
Cc: xiaoyun.li@intel.com, andrew.rybchenko@oktetlabs.ru,
Jie Wang <jie1x.wang@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload
Date: Thu, 15 Jul 2021 11:57:20 +0000 [thread overview]
Message-ID: <20210715115720.9981-1-jie1x.wang@intel.com> (raw)
In-Reply-To: <20210715113314.8837-1-jie1x.wang@intel.com>
The driver may change offloads info into dev->data->dev_conf
in dev_configure which may cause port->dev_conf and port->rx_conf
contain outdated values.
This patch updates the offloads info if it changes to fix this issue.
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Cc: stable@dpdk.org
Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
v4: delete the whitespace at the end of the line.
v3:
- check and update the "offloads" of "port->dev_conf.rx/txmode".
- update the commit log.
v2: copy "rx/txmode.offloads", instead of copying the entire struct
"dev->data->dev_conf.rx/txmode".
---
app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1cdd3cdd12..b6e8d7cdd9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2475,6 +2475,11 @@ start_port(portid_t pid)
}
if (port->need_reconfig > 0) {
+ const struct rte_eth_dev *dev = &rte_eth_devices[pi];
+ struct rte_eth_conf *dev_conf;
+ int k;
+
+ dev_conf = &dev->data->dev_conf;
port->need_reconfig = 0;
if (flow_isolate_all) {
@@ -2508,6 +2513,28 @@ start_port(portid_t pid)
port->need_reconfig = 1;
return -1;
}
+ /* Apply Rx offloads configuration */
+ if (dev_conf->rxmode.offloads !=
+ port->dev_conf.rxmode.offloads) {
+ port->dev_conf.rxmode.offloads =
+ dev_conf->rxmode.offloads;
+ for (k = 0;
+ k < port->dev_info.max_rx_queues;
+ k++)
+ port->rx_conf[k].offloads =
+ dev_conf->rxmode.offloads;
+ }
+ /* Apply Tx offloads configuration */
+ if (dev_conf->txmode.offloads !=
+ port->dev_conf.txmode.offloads) {
+ port->dev_conf.txmode.offloads =
+ dev_conf->txmode.offloads;
+ for (k = 0;
+ k < port->dev_info.max_tx_queues;
+ k++)
+ port->tx_conf[k].offloads =
+ dev_conf->txmode.offloads;
+ }
}
if (port->need_reconfig_queues > 0) {
port->need_reconfig_queues = 0;
--
2.25.1
next prev parent reply other threads:[~2021-07-15 4:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:57 [dpdk-stable] [PATCH] " Jie Wang
2021-07-09 9:27 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-12 3:12 ` Li, Xiaoyun
[not found] ` <DM8PR11MB5639B19DACFB1B4F4E70ACA4D1149@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-13 3:30 ` Li, Xiaoyun
2021-07-16 9:09 ` Ferruh Yigit
2021-07-13 17:04 ` [dpdk-stable] [PATCH v2] " Jie Wang
2021-07-15 2:29 ` Li, Xiaoyun
2021-07-15 2:40 ` Li, Xiaoyun
2021-07-15 11:33 ` [dpdk-stable] [PATCH v3] " Jie Wang
2021-07-15 11:57 ` Jie Wang [this message]
2021-07-15 4:53 ` [dpdk-stable] [PATCH v4] " Li, Xiaoyun
2021-07-16 8:30 ` Li, Xiaoyun
2021-07-16 8:52 ` Ferruh Yigit
[not found] ` <DM8PR11MB5639C757A790F65CBFB647C2D1E19@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-19 16:18 ` Ferruh Yigit
2021-07-22 11:03 ` Andrew Rybchenko
2021-08-09 8:53 ` Ferruh Yigit
2021-08-17 17:38 ` [dpdk-stable] [PATCH v5] " Jie Wang
[not found] ` <20210824171049.138208-1-jie1x.wang@intel.com>
2021-08-24 17:10 ` [dpdk-stable] [PATCH v6 2/2] " Jie Wang
[not found] ` <20210824181929.142691-1-jie1x.wang@intel.com>
2021-08-24 18:19 ` Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715115720.9981-1-jie1x.wang@intel.com \
--to=jie1x.wang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).