From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBB10A0C47 for ; Mon, 26 Jul 2021 15:53:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4B45410E1; Mon, 26 Jul 2021 15:53:40 +0200 (CEST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id E4E09410E6 for ; Mon, 26 Jul 2021 15:53:37 +0200 (CEST) Received: by mail-wm1-f50.google.com with SMTP id m38-20020a05600c3b26b02902161fccabf1so8246993wms.2 for ; Mon, 26 Jul 2021 06:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eOtUBYfSXTC4oqVvo1t3npxOofrdGrukN4Y1+mpc5jc=; b=QBOebOtLeyW/beELiRqg6dpmKQqPeeWijW/jPgiqkxwnYfsTh3Qj22OyQ/cS5Xgi2p 2sC7Ce8oblzXQrrJEl9yGIc66xL+De3An1GmU+yi5lemTgWigwHhf0NpojnMORCsy7a2 V2a/eIn9kB7sCopCcQ+3kOqY+eNhQStVBX+bvpW6R6fboJwqrKoscsbgX24P89/jnnJp inO9MZ3wGYZDWSqDrP6ze9pNOOrvHV8EewbQCNZsoSGlhnXVNGZP7Tke0Lap33YkmiAN 3xZkcSbz4Kx6uhZ7kijyE1seZx04XDEtkyloz6vcuw/XLo0/6z4Afu+yys/dfcgbPL0k uDrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eOtUBYfSXTC4oqVvo1t3npxOofrdGrukN4Y1+mpc5jc=; b=jrDfvzB+J5ZvfOn5Trv1kLYaXgF70nJlzqXdfBs19wFastar2NKpdEpY4o0NFr6hlQ ZZCvdAIYgrd2iOfuqBzf4LJvI5DIU7N8TYlrQyLLquS/bBJ9PYMbsGtd58YMrx/qksUm 5JSsXjirO99oRF6UgGO31FU9NRMnQP9P3iEh4TarnG8AWzT5sKCt3HseX90TW8d3LqaW EPCwPMet2o25wMBpknL+jySsrVfmzjPMzJ1idiD5EiZpuPgtONztD0Ynzksq9Ua7Nt75 YwFDTY4bynrOmulYF7+HOe7F8UDmuIkoz0/5g53yI6+sLjvbr5nrqWcYRihQqIcJW7rJ bFDQ== X-Gm-Message-State: AOAM530YWqO+ua5oEMFXiJ2OI0zTaOfUbWKuouPjaoQVWJ/l7axpSTuj uYWVB03kpvx5Lwo3aZYvN8E= X-Google-Smtp-Source: ABdhPJw9kL5ftBLws3mqklTLi9BuuaVWU/fz/b/ZU5lYPyJy0gC5Lxm/A80XiXNRSpjnBIDFfqaq1w== X-Received: by 2002:a1c:4e1a:: with SMTP id g26mr4185214wmh.52.1627307617683; Mon, 26 Jul 2021 06:53:37 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id e3sm2136189wrw.51.2021.07.26.06.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:53:37 -0700 (PDT) From: luca.boccassi@gmail.com To: Martin Havlik Cc: Min Hu , Andrew Rybchenko , dpdk stable Date: Mon, 26 Jul 2021 14:52:25 +0100 Message-Id: <20210726135322.149850-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bonding: check flow setting' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/6807067d712ff88124851b6f9ee06cc8503758a5 Thanks. Luca Boccassi --- >From 6807067d712ff88124851b6f9ee06cc8503758a5 Mon Sep 17 00:00:00 2001 From: Martin Havlik Date: Tue, 22 Jun 2021 11:25:29 +0200 Subject: [PATCH] net/bonding: check flow setting [ upstream commit d844400966d0071680d618c21a896ec8c73a50e6 ] Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Signed-off-by: Martin Havlik Acked-by: Min Hu (Connor) Reviewed-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 8abb25a920..a1d3703e96 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1808,8 +1808,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id], &flow_error); - bond_ethdev_8023ad_flow_set(bonded_eth_dev, + errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev, slave_eth_dev->data->port_id); + if (errval != 0) { + RTE_BOND_LOG(ERR, + "bond_ethdev_8023ad_flow_set: port=%d, err (%d)", + slave_eth_dev->data->port_id, errval); + return errval; + } } /* Start device */ -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:16.080783013 +0100 +++ 0002-net-bonding-check-flow-setting.patch 2021-07-26 13:53:15.769290941 +0100 @@ -1 +1 @@ -From d844400966d0071680d618c21a896ec8c73a50e6 Mon Sep 17 00:00:00 2001 +From 6807067d712ff88124851b6f9ee06cc8503758a5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d844400966d0071680d618c21a896ec8c73a50e6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 4c43bf9166..a6755661c4 100644 +index 8abb25a920..a1d3703e96 100644 @@ -23 +24 @@ -@@ -1819,8 +1819,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, +@@ -1808,8 +1808,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,