From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B547A0C47 for ; Mon, 26 Jul 2021 15:53:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C89B410EA; Mon, 26 Jul 2021 15:53:41 +0200 (CEST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id DB4CA410E1 for ; Mon, 26 Jul 2021 15:53:38 +0200 (CEST) Received: by mail-wr1-f51.google.com with SMTP id r2so11237495wrl.1 for ; Mon, 26 Jul 2021 06:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kxR3qGwcf4GiNWZ/NfYjlCMv3+hV324jeQfV6k2fDjU=; b=Oo+Ke1Css8CCG+cOtfcJtTIisBkc+XC9If5L4epPpGQHU5u/NeH7RWZkt9elhla7sQ Sdes4K+jTtz1Volp7qrv0ZyR+BvRg/QC6EfPRcoqmgDluPYSymE7jE9pcKCQBIpG6dYD SrjmBl36pw0MSdnxBSw1j3KwFlqgrsneQtLlfODP78YW5X2jU+pQLhkyAmz3CsV4SeH7 fKeOaZoZRhHLrykbHUKA51EaIdFo50pAxHXcv0Bf0x/2ffyFDk81S48degd3Qtlxl77K 9x7CeFwMeqooWi3u7B4rogYf5SbNCpRkekmk7mJTjgJqh41f8Bcndr8wvejPQEdJZxzy r0Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kxR3qGwcf4GiNWZ/NfYjlCMv3+hV324jeQfV6k2fDjU=; b=Po345xWNT1MARvMfl+it42Zv0N3OcViVEDhblcgpdl5m3DB7sQnagq04PlZ6FIP8Eo lHdzSQSJZvuGZ5KByqpzmqka3W4Eb/2xCqAZFNEApbtQr57ab8+rLYo5M3FBgo65L4WN BdWlRyrln9bNjFouZcDuBNHDVfYjxf4CuI65rJ1AQ7Q4xsamqnbdvHygZKSeWJNtdziw ARaVfk09zs0ZqA48xbeCnF1Kvb1S7vb0JPrsa6LfFk0LIOFGCDQFXz+ycFfj/qL0MjRy Cl3KwrCpRcCjafZLOnkRfeSB2tt9jY2ZZrap2LiqmkW2zQ/pAV9oZ/f9Z/o9lkgkfJk+ 1hMQ== X-Gm-Message-State: AOAM532+Y1sF3AEpHlYl0JPXFVA/6TCVmcwPtYsHSWgHkSasyCWx/e6a ftNxlolf6nj0rjPQ20D2crg= X-Google-Smtp-Source: ABdhPJzXEPzEtX0AHfSom+mnKN2/t9ir0+YOAz2uE4swSutX/27G+ZrCdCfCi08PQzbDQfQdthP7Cw== X-Received: by 2002:a5d:5286:: with SMTP id c6mr16980256wrv.357.1627307618684; Mon, 26 Jul 2021 06:53:38 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id z11sm42352671wru.65.2021.07.26.06.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:53:38 -0700 (PDT) From: luca.boccassi@gmail.com To: Dapeng Yu Cc: Andrew Rybchenko , dpdk stable Date: Mon, 26 Jul 2021 14:52:26 +0100 Message-Id: <20210726135322.149850-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/softnic: fix connection memory leak' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/96ad1e25fc0265ec2b5776af7833f0beb25bb18f Thanks. Luca Boccassi --- >From 96ad1e25fc0265ec2b5776af7833f0beb25bb18f Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Fri, 9 Jul 2021 14:00:56 +0800 Subject: [PATCH] net/softnic: fix connection memory leak [ upstream commit ae2b3ba6430d9f86cc3583b893f442aaa8934655 ] In function softnic_conn_init(), a block of memory is allocated as connection buffer, but it is never freed in softnic_conn_free(), which cause memory leak. Fixes: 7709a63bf178 ("net/softnic: add connection agent") Signed-off-by: Dapeng Yu Reviewed-by: Andrew Rybchenko --- drivers/net/softnic/conn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/softnic/conn.c b/drivers/net/softnic/conn.c index 8b66580887..5b031358d5 100644 --- a/drivers/net/softnic/conn.c +++ b/drivers/net/softnic/conn.c @@ -144,6 +144,7 @@ softnic_conn_free(struct softnic_conn *conn) free(conn->msg_out); free(conn->msg_in); + free(conn->buf); free(conn->prompt); free(conn->welcome); free(conn); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:16.126777061 +0100 +++ 0003-net-softnic-fix-connection-memory-leak.patch 2021-07-26 13:53:15.769290941 +0100 @@ -1 +1 @@ -From ae2b3ba6430d9f86cc3583b893f442aaa8934655 Mon Sep 17 00:00:00 2001 +From 96ad1e25fc0265ec2b5776af7833f0beb25bb18f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ae2b3ba6430d9f86cc3583b893f442aaa8934655 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org