From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 691A8A0C47 for ; Mon, 26 Jul 2021 15:55:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63DC840DDA; Mon, 26 Jul 2021 15:55:52 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 6523540DDA for ; Mon, 26 Jul 2021 15:55:50 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id m38-20020a05600c3b26b02902161fccabf1so8252372wms.2 for ; Mon, 26 Jul 2021 06:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1htBXpa0oYbcpP1aSIy9U/mqPtH8UHIm9u9MP+3ym3w=; b=NW1VgwJMiR3Am+F3XVSqEhkRso2HY0uHC+EXkSf4MXxfd086aD6WHYUEM8jSX3FdI2 I9QodQHFuqDgnKOM+O4voeYWl0QF+puJ6gTf2kwCm1/VIzV13fV5vEBHba/CTmMscwWS hdStpvQV3S6pCnuvyP/wU32qIe5WV+pmRLoq1AbHq8aJ6v73idD2eruodqD/FnjRNjrb iRtnpbv3JgJyU8JGkd0nLw6dQ29M9dPpNVIlCmHfWoeuKuNRHWl5uZSmc3z699fW5CYs u45ZRoR9TrGIRK/ZAUuhudhGHL/LB0v44rbWENE+scEwlW9i2zt4gXAq1VBSUwgJSLR+ OitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1htBXpa0oYbcpP1aSIy9U/mqPtH8UHIm9u9MP+3ym3w=; b=Ktd11v9qjMiwzKn8SHUSdPGccj0Xm3Ziaxxzb8Zo1K/lie/PLbEU3aU+82+cfeT2fv QRHOqo6B2yTDUBvcQ+QFa52MdKRp+ZZ5jEzdU1G3Mwmn6QfqMzxVF3DOiQ1GwLMbhNRQ ggjL0wq1+XZSZIZItTQvVcm0aMwcKaQimwnScpfickx3/bJIkFHRMzTH8fh/EpVvRE6S BBjixOyVkpr3eAJUgH+dVf1LlwpLLhafG7DdvKiBiniCgndqL03V34UARyEIrA2YPMd6 HWo0VsvDyYxtbqR8OD8JnqtCELyhDNKof9AnLjWhlfOvw4erbcKlQie7XjpTNA5rqpKl BB9Q== X-Gm-Message-State: AOAM532vf/nodDmCVeX9gbm/Oa/brBt08Vv5W2c4tDMGLe3BmnZ/HrSA U12kTGndwOx5+3Yvr8RT5aM= X-Google-Smtp-Source: ABdhPJy9GRx1Rsn4XeIW6Srmpxl6mQtKTKMn1ZFOVPCjSoX5tPt5oW/yUIA4hUn657/IbY0ltcLQBg== X-Received: by 2002:a1c:6a06:: with SMTP id f6mr24710607wmc.38.1627307750216; Mon, 26 Jul 2021 06:55:50 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id j140sm434261wmj.37.2021.07.26.06.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:55:49 -0700 (PDT) From: luca.boccassi@gmail.com To: Guoyang Zhou Cc: dpdk stable Date: Mon, 26 Jul 2021 14:53:09 +0100 Message-Id: <20210726135322.149850-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hinic/base: fix LRO' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3e6a9fa0e2a5398cf0bf2e5372091b28b7b1d00e Thanks. Luca Boccassi --- >From 3e6a9fa0e2a5398cf0bf2e5372091b28b7b1d00e Mon Sep 17 00:00:00 2001 From: Guoyang Zhou Date: Fri, 16 Jul 2021 17:54:29 +0800 Subject: [PATCH] net/hinic/base: fix LRO [ upstream commit 68fa836d0ff83229e1404f1274c90e1bff2475c8 ] The Rx queue must config as ceq disables, and must set MSI-X state disabled. Otherwise when LRO is enables, there will be problems with packet aggregation because of firmware. Fixes: 9d02f40d6503 ("net/hinic: fix LRO") Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_nicio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hinic/base/hinic_pmd_nicio.c b/drivers/net/hinic/base/hinic_pmd_nicio.c index 162308b02f..ad5db9f1de 100644 --- a/drivers/net/hinic/base/hinic_pmd_nicio.c +++ b/drivers/net/hinic/base/hinic_pmd_nicio.c @@ -230,8 +230,8 @@ static void hinic_rq_prepare_ctxt(struct hinic_rq *rq, wq_block_pfn_hi = upper_32_bits(wq_block_pfn); wq_block_pfn_lo = lower_32_bits(wq_block_pfn); - /* must config as ceq enable but do not generate ceq */ - rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(1, EN) | + /* config as ceq disable, but must set msix state disable */ + rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(0, EN) | RQ_CTXT_CEQ_ATTR_SET(1, OWNER); rq_ctxt->pi_intr_attr = RQ_CTXT_PI_SET(pi_start, IDX) | -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:18.446688208 +0100 +++ 0046-net-hinic-base-fix-LRO.patch 2021-07-26 13:53:15.937294472 +0100 @@ -1 +1 @@ -From 68fa836d0ff83229e1404f1274c90e1bff2475c8 Mon Sep 17 00:00:00 2001 +From 3e6a9fa0e2a5398cf0bf2e5372091b28b7b1d00e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68fa836d0ff83229e1404f1274c90e1bff2475c8 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org