From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A1E2A0C47 for ; Mon, 26 Jul 2021 15:53:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43A3540DDA; Mon, 26 Jul 2021 15:53:44 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id C445F40DDA for ; Mon, 26 Jul 2021 15:53:40 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id e25-20020a05600c4b99b0290253418ba0fbso39154wmp.1 for ; Mon, 26 Jul 2021 06:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sbKPNbZvk2HsuWqu4r5DyOg/wl8wAgm6XxqqLBPw+Xg=; b=Azm6F7n86Jr826qnMSP/Jjz/FsqiGowEjZRBFSZzTLmJ5e+scHQWxEIVR4MgSsfIIX uTEBL6VHBM+mejp66AlXA0twQwN2WVFxpCz+2UY++f4ghkuYiHg4HrJPbk/W2QBDcltJ 1qRo8fYokuOuzeJxIw4P2CcpAei/f1pM3/2jGyP9cdc9NowPEF3ncOfAuEV0JOvYfPkt eBDWR57ye9rTtPcekRIPe9yo1oH8jXDCPlC8IIXkpMg4KEqYLMZVQo0hr9HZBEckEJUN Io5ocWJBfQ/MTJGgpxTAb90ZKCCFx16iP8416A0BeIW1AA8GM/QfQnGhQoinQu2giltX a+pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sbKPNbZvk2HsuWqu4r5DyOg/wl8wAgm6XxqqLBPw+Xg=; b=MlP6ERUOk1zftOwmcfOmehhqwGqJS8Ab7tzG966JcJ8YpMFWRMwVQRzQ2nve5Y5ojR WmkjGZ7b8NylH22I8X17eAR9rlen1zc1FXCHBmCJpWzIzdJ7KGaCt4YG96DQPIGYB2MT BWeylQv+kuoQfCZjhzKZBocpc/sSozpAOb0gKWbZXGy1b1Z47liX1tyu/gA6AjHN87w3 qz18Xu1BBjZGH8hki4UAqGmp0Qf5rBCHFbmhL9cDvvK+gnWLIVY7zeNqNjRl8NIWFpf9 SRmpx6BxDOgK3AjPzCERcMDpSu2+90xhXgSyLiK1L5UD1ypgvbKN0KpyRkBH07aIkA2r QMFg== X-Gm-Message-State: AOAM533nokXzD4zfO0SqR51uFbPuoY0t/qGZ2TSs+RnBYkP5Bk17o1gG Aa4a/Gsmt+PUp/dtEuSQJYgdNzBdW8npeg== X-Google-Smtp-Source: ABdhPJzJqBMGeFiw/C0k3mv+HKD0VIIoneqFpfWZRqNszXr+RmhcrE/76ZnNB5whCDp0jluQbeBQ0g== X-Received: by 2002:a05:600c:2f1a:: with SMTP id r26mr26669522wmn.41.1627307620607; Mon, 26 Jul 2021 06:53:40 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id y197sm14124966wmc.7.2021.07.26.06.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:53:40 -0700 (PDT) From: luca.boccassi@gmail.com To: Ruifeng Wang Cc: Viacheslav Ovsiienko , dpdk stable Date: Mon, 26 Jul 2021 14:52:28 +0100 Message-Id: <20210726135322.149850-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: remove redundant operations in NEON Rx' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2a5c46697b2b0aa0ff37f18b92ba6aa90d9dcb69 Thanks. Luca Boccassi --- >From 2a5c46697b2b0aa0ff37f18b92ba6aa90d9dcb69 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Wed, 7 Jul 2021 17:03:06 +0800 Subject: [PATCH] net/mlx5: remove redundant operations in NEON Rx [ upstream commit ff6fcd415f4b2be7572abffa5284978c176d3de4 ] Mask of entries after the compressed CQE is covered by invalid mask of non-compressed valid CQEs. Hence remove redundant calculation on mask. The change showed slight performance uplift on N1SDP. Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") Signed-off-by: Ruifeng Wang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h index 2234fbe6b2..ce50a3ccc4 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h @@ -767,16 +767,15 @@ rxq_cq_process_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq, comp_idx = __builtin_clzl(vget_lane_u64(vreinterpret_u64_u16( comp_mask), 0)) / (sizeof(uint16_t) * 8); - /* D.6 mask out entries after the compressed CQE. */ - mask = vcreate_u16(comp_idx < MLX5_VPMD_DESCS_PER_LOOP ? - -1UL >> (comp_idx * sizeof(uint16_t) * 8) : - 0); - invalid_mask = vorr_u16(invalid_mask, mask); + invalid_mask = vorr_u16(invalid_mask, comp_mask); /* D.7 count non-compressed valid CQEs. */ n = __builtin_clzl(vget_lane_u64(vreinterpret_u64_u16( invalid_mask), 0)) / (sizeof(uint16_t) * 8); nocmp_n += n; - /* D.2 get the final invalid mask. */ + /* + * D.2 mask out entries after the compressed CQE. + * get the final invalid mask. + */ mask = vcreate_u16(n < MLX5_VPMD_DESCS_PER_LOOP ? -1UL >> (n * sizeof(uint16_t) * 8) : 0); invalid_mask = vorr_u16(invalid_mask, mask); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:16.214236629 +0100 +++ 0005-net-mlx5-remove-redundant-operations-in-NEON-Rx.patch 2021-07-26 13:53:15.777291109 +0100 @@ -1 +1 @@ -From ff6fcd415f4b2be7572abffa5284978c176d3de4 Mon Sep 17 00:00:00 2001 +From 2a5c46697b2b0aa0ff37f18b92ba6aa90d9dcb69 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff6fcd415f4b2be7572abffa5284978c176d3de4 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 5c569ee199..4d1710b837 100644 +index 2234fbe6b2..ce50a3ccc4 100644