From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23276A0C40 for ; Fri, 30 Jul 2021 16:35:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAEF84003F; Fri, 30 Jul 2021 16:35:08 +0200 (CEST) Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by mails.dpdk.org (Postfix) with ESMTP id D7FBA4003F for ; Fri, 30 Jul 2021 16:35:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=LbFrT tbRXVuKPr7D9lLQP/Ox+dmgyW6PGd/wV1OUm7E=; b=HfpBko0lzc8VakSw76TE4 QIWdPVD4BkH203m3FQJG39zrqZ7lHRP4pubFwOSpiAOpbW4RzEfok4Ub032Djp2S l+kS8rMYHP1tSeSjIx5Ki4f+zE3jInAnqYGmv3vb5+JsP8OEJUIyuwFn9Hj4wxjP DCpTlpJjpJA9SFnhx/SzRs= Received: from DESKTOP-ONA2IA7.localdomain (unknown [39.182.55.95]) by smtp8 (Coremail) with SMTP id DMCowADXtT4NDgRhpkr9RQ--.44528S4; Fri, 30 Jul 2021 22:35:02 +0800 (CST) From: Gaoxiang Liu To: gaoxiangliu0@163.com Cc: stable@dpdk.org Date: Fri, 30 Jul 2021 22:34:06 +0800 Message-Id: <20210730143406.767-1-gaoxiangliu0@163.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DMCowADXtT4NDgRhpkr9RQ--.44528S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrKr1fXrWkZF48CF45KF4fAFb_yoWfGrX_Gr 17JF9rAF4UC3Wq93y7Ar1rZrySk3Z5GFykWa9Iq34rX3WUJ3W5XrnIvrnxGanrWw4UCrZr Gr4fG3Z8u34S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8ZZ23UUUUU== X-Originating-IP: [39.182.55.95] X-CM-SenderInfo: xjdr5xxdqjzxjxq6il2tof0z/xtbBORffOl-PIyR35gAAsN Subject: [dpdk-stable] [PATCH] net/virtio: fix repeated memory free of vq X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" When virtio_init_queue returns error, the memory of vq is freed. But the value of hw->vqs[queue_idx] does not restore.` If hw->vqs[queue_idx] != NULL, the memory of vq is freed again in virtio_free_queues. Fixes: 69c80d4ef89b ("net/vritio: allocate queue at init stage") Cc: stable@dpdk.org Signed-off-by: Gaoxiang Liu --- drivers/net/virtio/virtio_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 056830566..fc72d71cb 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -631,6 +631,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t queue_idx) rte_memzone_free(mz); free_vq: rte_free(vq); + hw->vqs[queue_idx] = NULL; return ret; } -- 2.32.0