From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CADFA0C47 for ; Tue, 10 Aug 2021 17:41:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0748A4014F; Tue, 10 Aug 2021 17:41:08 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 629CF4014F for ; Tue, 10 Aug 2021 17:41:06 +0200 (CEST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 4B0DF3F0B8 for ; Tue, 10 Aug 2021 15:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610066; bh=WkMKS5wCNJGyj8yu1nQxiVO3MloFHwtOJAUZUHTLOyM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BB1AxMm7oXwjU5cTsoi6UAm3EZ+A59AK4sL157pPiuJbFpIY6LIW++mGYpeBIlJAA Sl5utp/QI+n5Lha6v002v7DmRFkZP6Ywqx70pjxYHcBCTogkX4YAmAzO4MWay+OePo 6/OKPW043MG5xM1t/qzKlayU0bYeJv3tvt8hEsgzwPX0QCeg7qhSqMnyKBDDiNWCq2 bnas3YO2tCXt9u7Rp98Uqrf0rgKW+RMFzC2TxfwP2s8AbtBD1Yolxj4iz5sq6xOhAX myDLmw9q/E94h2nl3oDPtnAtXvILvy/D6SVjtSWOna4Hr2LbOpwuZvTR5Hj2xul2xs pu66dhsGwlbmw== Received: by mail-ed1-f70.google.com with SMTP id d12-20020a50fe8c0000b02903a4b519b413so10949705edt.9 for ; Tue, 10 Aug 2021 08:41:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WkMKS5wCNJGyj8yu1nQxiVO3MloFHwtOJAUZUHTLOyM=; b=XH2G3VvvErRDgreE/sL3IAX8i8mqP2RMn4T6TULr88GvlNgtFKpdZZFEPiR2p/TqSq 1xW3mUXRR5nezu5SiSAezPn37s/ovimHbFZkUoBNeilZqocWESuEiGYF2pEV5+pmYBMi vO6Olyb1pxCo96JTIVafKfni5NxR5K4wfQ+wcl/QoI7A0aIVApRJoQtXnqrwEvptH+N3 5Va1bZBGY6yQ8vUCGjp1+3bjwpXLD3px9NwNPGaBSJiwvJBDP9sWpdXKGFl5t2WVQWUb 0BvbQM8WhWOWyOVvLr0IJaSXW18/4XFf1cooLRa0Xogz90cKgZjjtDU57xCUG1NMUoOV pIHA== X-Gm-Message-State: AOAM5313/q093WX78BD13WiKQWt0ai1LQWYtH59LxapgOTDjaJwhS55l 4u73ZMpzQvRNmg0UCtZJ1CvRMdx1sCadDsEKRNzfIM8bEnZm6jP4D1ZYepgNAx7W7wlZhhgyvfR JBH2p/PsUasnVyMtoplXjxMWb X-Received: by 2002:a17:906:f8d5:: with SMTP id lh21mr3810498ejb.6.1628610065995; Tue, 10 Aug 2021 08:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/DjrDysUQXfzCdt2oUy4OCrRMkrAF9sN4q8ZJ6/dYPJk91FWkYZeYW9kpME72yA+PmBo/Hg== X-Received: by 2002:a17:906:f8d5:: with SMTP id lh21mr3810481ejb.6.1628610065824; Tue, 10 Aug 2021 08:41:05 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id r19sm2113142edd.49.2021.08.10.08.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:41:05 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Haiyue Wang Cc: Beilei Xing , dpdk stable Date: Tue, 10 Aug 2021 17:38:51 +0200 Message-Id: <20210810154022.749358-11-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix RSS key access out of bound' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/e818762474aea4d0b9e53d16aeba6e86aa9f53e6 Thanks. Christian Ehrhardt --- >From e818762474aea4d0b9e53d16aeba6e86aa9f53e6 Mon Sep 17 00:00:00 2001 From: Haiyue Wang Date: Wed, 19 May 2021 15:59:33 +0800 Subject: [PATCH] net/iavf: fix RSS key access out of bound [ upstream commit 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f ] The array rss_key has size 'vf->vf_res->rss_key_size', the array index should be less than that. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Haiyue Wang Acked-by: Beilei Xing --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 10eb3322eb..d7d14ee11a 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -199,7 +199,7 @@ iavf_init_rss(struct iavf_adapter *adapter) /* configure RSS key */ if (!rss_conf->rss_key) { /* Calculate the default hash key */ - for (i = 0; i <= vf->vf_res->rss_key_size; i++) + for (i = 0; i < vf->vf_res->rss_key_size; i++) vf->rss_key[i] = (uint8_t)rte_rand(); } else rte_memcpy(vf->rss_key, rss_conf->rss_key, -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:13.510423053 +0200 +++ 0011-net-iavf-fix-RSS-key-access-out-of-bound.patch 2021-08-10 15:11:12.914637350 +0200 @@ -1 +1 @@ -From 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f Mon Sep 17 00:00:00 2001 +From e818762474aea4d0b9e53d16aeba6e86aa9f53e6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index a7ef7a6d4d..5290588b17 100644 +index 10eb3322eb..d7d14ee11a 100644 @@ -22 +23 @@ -@@ -366,7 +366,7 @@ iavf_init_rss(struct iavf_adapter *adapter) +@@ -199,7 +199,7 @@ iavf_init_rss(struct iavf_adapter *adapter)