From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44675A0C47 for ; Tue, 10 Aug 2021 17:41:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FF60411CC; Tue, 10 Aug 2021 17:41:25 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 505B3411C8 for ; Tue, 10 Aug 2021 17:41:24 +0200 (CEST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 367563F107 for ; Tue, 10 Aug 2021 15:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610084; bh=qNkrcIIew2DcE0AHO4gqUwnHHUUvsEPCjfDJb61EJiY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oWHkSFZVKtdY8Hvv/Otk3j4KeXX5QskPll7dnVx0SqatUV3woEzkBKKFRBxeCzxxk WEG8knAPQhRsdhpljt5PkA/aDao5cmTPbRBinKexzug2p3lNPHoRfgoxnjBGjrdFk/ fyQK8yAPaNnvF9U0qS5ByN7lUlTaNdmrrlQ3lrxl74eo1tS0zloKhxe1bLBpitXzoU XwIFNpJMsZ6ItFwQ9y1lB4NrV6zuCm77KVX4Xh1+SXsj0K0qLLhlp3G0cPhQtUNdkF Ds7Ki9ZKqmJUCn05nIQQ7TxEZvdk/7YpetmwLTtnH0SH7ch5pS0/7pl0e/gUvZKeKJ Oz1qGIJSY2rcA== Received: by mail-ed1-f70.google.com with SMTP id a23-20020a50ff170000b02903b85a16b672so10958682edu.1 for ; Tue, 10 Aug 2021 08:41:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qNkrcIIew2DcE0AHO4gqUwnHHUUvsEPCjfDJb61EJiY=; b=bxv5eVAJ/3xSH8luy9JAmlWgy+en3JsSqzcvfUKTdaSwg9gyKbvflEml+xbSLlcg/Y zetqmNDuQFO+jDpRjlU07yydiUSUUfhVSaCLzdcRmj4AEoPpDTO+6p62N0TACOFzmmSt zRjwevvv8iDj7iMeujFdajJfnc7k3187RlNKRGnzAvZew61zZn4BMLqS6tP3iCq1cTik 9diPue20SB3w9LKjTRLe/Ic1uEfLDeI0P3424AtO19Dft4+BmNkeqA2eL8tdTegIhh0m F+ogEPm55KsZsQFX8ahc1aVdL/EuN82Gc0V+6rbWCOIuGZPwqzzNxkZ3jkKBobX73Z4U iniQ== X-Gm-Message-State: AOAM530s3vmjJ6WkNs84Mr0aSVRbGLbzdJhdN/gH9D6NFO4Rc862afI0 jUOCVbmCWxg7qGGgfp0lvwgNzMJMtsd6EVbisT5ruJSzOtufAVQnvMi9Hwin4FMOkTFhJNsb13O nCvAp0oSHKHFtU64birzTVNcc X-Received: by 2002:a17:906:6d11:: with SMTP id m17mr11849767ejr.325.1628610083907; Tue, 10 Aug 2021 08:41:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvGud6Sj8ypWRsO9lpL18C/T9LcUxJQEymyIDr9p/O6CgWYm6njXxZ6Wv2p3Cbkqr6IKf9zQ== X-Received: by 2002:a17:906:6d11:: with SMTP id m17mr11849754ejr.325.1628610083728; Tue, 10 Aug 2021 08:41:23 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id dt2sm2452535ejc.51.2021.08.10.08.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:41:23 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Owen Hilyard Cc: David Marchand , dpdk stable Date: Tue, 10 Aug 2021 17:38:59 +0200 Message-Id: <20210810154022.749358-19-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'tests/eal: fix memory leak' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/7e5dd0be04b33db9932143099908df8c37bd9b07 Thanks. Christian Ehrhardt --- >From 7e5dd0be04b33db9932143099908df8c37bd9b07 Mon Sep 17 00:00:00 2001 From: Owen Hilyard Date: Wed, 16 Jun 2021 12:24:52 -0400 Subject: [PATCH] tests/eal: fix memory leak [ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ] The directory steam was not closed when the hugepage action was HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of the unit tests. Fixes: 45f1b6e8680a ("app: add new tests on eal flags") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_eal_flags.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 5b2c0f5cdb..654bebff6f 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -125,6 +125,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action) case HUGEPAGE_CHECK_EXISTS: { /* file exists, return */ + closedir(hugepage_dir); result = 1; goto end; } -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:13.817771508 +0200 +++ 0019-tests-eal-fix-memory-leak.patch 2021-08-10 15:11:12.918637378 +0200 @@ -1 +1 @@ -From 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b Mon Sep 17 00:00:00 2001 +From 7e5dd0be04b33db9932143099908df8c37bd9b07 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 932fbe3d08..b4880ee802 100644 +index 5b2c0f5cdb..654bebff6f 100644 @@ -23 +24 @@ -@@ -124,6 +124,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action) +@@ -125,6 +125,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action)