From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3BD4A0C47 for ; Tue, 10 Aug 2021 17:41:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9383F4014F; Tue, 10 Aug 2021 17:41:38 +0200 (CEST) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mails.dpdk.org (Postfix) with ESMTP id C49D34014F for ; Tue, 10 Aug 2021 17:41:36 +0200 (CEST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id A0B023F0A1 for ; Tue, 10 Aug 2021 15:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610096; bh=L6YNly7xubK+eDUYyiWmcjWTTFP0mQvByHk9eLMEDvk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FYGe015mGQKUWnhYNQvhJLp96VVOO+uhh6NB2wz0mXRxlQ/UPEg1PwmTg3eAqYkwu mngUbTlLWmbgB+rZBK43kEOyVXTXgnSsFJHhA2RoAWaActAZrR4E82hfbRPQvg/448 +EZiClkEvx6opKHmrz3TqoMKOgvzh62FrJAJ1Z2j53H3A5F/HOgFRrNvNJaX/zfBgW aIWkflZ+HJp+f8C+yVQ58ms2yFGQdVgzUm+52AO02daUJ3VTb2onz2sax1+Hrn0ds3 lYUMHzk0561yPvphvpYQg1dm9wJLIo1ksYb4xHlCI8RbESSmPAQRx2lj8KOeb8UgdO xNe7F6V4VK1og== Received: by mail-ed1-f72.google.com with SMTP id p2-20020a50c9420000b02903a12bbba1ebso10897784edh.6 for ; Tue, 10 Aug 2021 08:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L6YNly7xubK+eDUYyiWmcjWTTFP0mQvByHk9eLMEDvk=; b=PB+Fbe+7OvM1qhiijm94fgtUOZpwPPQEEReaOFC3TD+79Qi/7wlps6udTKCe5JnH2S vQ98SQ2IB5O0tvR1rDKHtLqPBR4hLirBCxUYzXK8p7jl+Y8yEToP4751QLOGGPOLUMgI 4WWz3qO9LWZP/R5Y1JX0Y5cbtarDkUSYV2HAr6FyUFUBZ1yOi0VBYziI2JnyxlFl4ZEh zQdWzGKEyp+uBJHAXBDt+2zHxppUyKZ1QlSuNxTBqJ5BeKnbpaWmAFO24rTQVvkKBx93 ch/a0Ss/Zxhnd5L2kXlky4DXEVTT9caUHZEx7Pq5OmfslBFb+s2RfO+ahVhyWz9zllP4 Yq4w== X-Gm-Message-State: AOAM532ILOqRnm7CwewsZdemJDnw4GA1RB+d2QBSa75uOTNV7LtjlCWN jITTbRL0q8GF6/M2lnrYlf9Il5RaZwLQxHLnBklou48VNYTEKkksoWahRUgRfxA6tcPotEsRru2 Es0CcIQZwfk0947N5NoypfYi1 X-Received: by 2002:a17:906:9ac6:: with SMTP id ah6mr3674400ejc.64.1628610096124; Tue, 10 Aug 2021 08:41:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmH3Q9tPIX1bIwDyiCqTriYNwp5UtSWxrZuFqmjiXpAHkhgl8iKNfRqeP3rUIcsKwbY1uOoA== X-Received: by 2002:a17:906:9ac6:: with SMTP id ah6mr3674386ejc.64.1628610095959; Tue, 10 Aug 2021 08:41:35 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id b5sm7047320ejq.56.2021.08.10.08.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:41:35 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Lance Richardson Cc: David Marchand , dpdk stable Date: Tue, 10 Aug 2021 17:39:01 +0200 Message-Id: <20210810154022.749358-21-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/test: fix IPv6 header initialization' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/4deebdea168dc1b8aee05db881f0633788418b6b Thanks. Christian Ehrhardt --- >From 4deebdea168dc1b8aee05db881f0633788418b6b Mon Sep 17 00:00:00 2001 From: Lance Richardson Date: Fri, 26 Mar 2021 12:37:32 -0400 Subject: [PATCH] app/test: fix IPv6 header initialization [ upstream commit a906371d2758df7260640873d93f888724759448 ] Fix two issues found when writing PMD unit tests for HW ptype and L4 checksum offload: - The version field in the IPv6 header was being set to zero, which prevented hardware from recognizing it as IPv6. The IP version field is now set to six. - The payload_len field was being initialized using host byte order, which (among other things) resulted in incorrect L4 checksum computation. The payload_len field is now set using network (big-endian) byte order. Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Lance Richardson Reviewed-by: David Marchand --- app/test/packet_burst_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c index c05ea7ad51..0fd7290b0e 100644 --- a/app/test/packet_burst_generator.c +++ b/app/test/packet_burst_generator.c @@ -142,8 +142,8 @@ uint16_t initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, uint8_t *dst_addr, uint16_t pkt_data_len) { - ip_hdr->vtc_flow = 0; - ip_hdr->payload_len = pkt_data_len; + ip_hdr->vtc_flow = rte_cpu_to_be_32(0x60000000); /* Set version to 6. */ + ip_hdr->payload_len = rte_cpu_to_be_16(pkt_data_len); ip_hdr->proto = IPPROTO_UDP; ip_hdr->hop_limits = IP_DEFTTL; -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:13.888301454 +0200 +++ 0021-app-test-fix-IPv6-header-initialization.patch 2021-08-10 15:11:12.922637408 +0200 @@ -1 +1 @@ -From a906371d2758df7260640873d93f888724759448 Mon Sep 17 00:00:00 2001 +From 4deebdea168dc1b8aee05db881f0633788418b6b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a906371d2758df7260640873d93f888724759448 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org