From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C672EA0C47 for ; Tue, 10 Aug 2021 17:42:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C155040686; Tue, 10 Aug 2021 17:42:12 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 646694014F for ; Tue, 10 Aug 2021 17:42:10 +0200 (CEST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 4CED43F357 for ; Tue, 10 Aug 2021 15:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610130; bh=p1DKgZ7pV9+o+UupsKbsfm/YpyipMaF/V/UJX2HtJ6A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KSHJzfI1YuCvJ73fTs6NqOWdQDh4eQlrnswyI/iD88VBLSeLgaNJFSnSlFK1gOtXY IktYcCXWs7FDQFKPWTQxVWnxz4Kvkc/byWKqd61aoe6iOFWTtO0fzQauLaP4oKXH22 o4WUarm4CT2uvwxndv9qhh3gyMjATJ7Zti4WMfCfab9A+UdDdQfzMAgFJvu8hfH5LI wjzCIpopuxK1nZ41NJKOVoygW00DkhsPSWQVPN7uGGgdKaLr3r0+877NUj1Jnr4EvL 20ZFqQLszf/uD4m6nPS39kM0K+MIjwHu+IIqxlE40UvS55t8pAFG8St+VlUhEw/68I EY9yRsswFWfUg== Received: by mail-ej1-f71.google.com with SMTP id kf21-20020a17090776d5b02905af6ad96f02so2025059ejc.12 for ; Tue, 10 Aug 2021 08:42:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p1DKgZ7pV9+o+UupsKbsfm/YpyipMaF/V/UJX2HtJ6A=; b=YP5rjPMpWuswYCc9nBqqAuum1FsL2SXAszTfxsZI1sUJAOieDf2i94JjYyx1gdqcVD yS/kKiN0EwkbHyTyf6jNneDi1pXB6i+N5DWW6P7s5LKOTqh9J+xYQ/gvjr+zupOvZjFd JS5PmbAbwW87HHwyo8cuqhmHme1VX04iC+VMpzJyD5yXnDvrt4mg2yrjd+/NvCXmMcY2 vddIMfPvJ33hw14a+qdBPdbRzqGJYa5wAcAX41jbHeiKX0ccW2D3VkcjViY+jeceanaC EwBgQPN6K69VKbq0rT6o9XrXyAQxl7v9UdLLRo2qrzFHjY4Xxgj/AROWtX+/2s18chC3 VatQ== X-Gm-Message-State: AOAM531RCSHExMg9+K1WTqw0q0rqH5fCgqTVyEJEicn8H7K7J9cD1WjI tKplP2YJ4GSSrbgNqGaWNH/tmLCxglIQeVyuim79tFIavmQo6P2lQiYHcgsjw0kHhNQDPFFXxXE H7vYZuz3oXN+RONCVy/PhVx/Y X-Received: by 2002:a17:906:7c52:: with SMTP id g18mr28508731ejp.224.1628610129724; Tue, 10 Aug 2021 08:42:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTfziqlENFdbOqgVlKv1uF/qY27r33FRfKRBucD3BbC+cf2bamlBTtz06GtjiBs8rCMY8iWw== X-Received: by 2002:a17:906:7c52:: with SMTP id g18mr28508718ejp.224.1628610129548; Tue, 10 Aug 2021 08:42:09 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id q8sm9596911edv.95.2021.08.10.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:42:08 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Thierry Herbelot Cc: Gagandeep Singh , dpdk stable Date: Tue, 10 Aug 2021 17:39:13 +0200 Message-Id: <20210810154022.749358-33-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/pfe: remove unnecessary null check' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/704a3314ef03076bfa9ba120a74de97578f6a01f Thanks. Christian Ehrhardt --- >From 704a3314ef03076bfa9ba120a74de97578f6a01f Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 24 May 2021 11:37:54 +0200 Subject: [PATCH] net/pfe: remove unnecessary null check [ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ] ethdev library does the check of dev before calling the link update. Fixes: acd4818ea2a45 ("net/pfe: add link status update") Signed-off-by: Thierry Herbelot Acked-by: Gagandeep Singh --- drivers/net/pfe/pfe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c index fa3c0ce0fe..4e2ba0565f 100644 --- a/drivers/net/pfe/pfe_ethdev.c +++ b/drivers/net/pfe/pfe_ethdev.c @@ -583,11 +583,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) struct rte_eth_link link, old; unsigned int lstatus = 1; - if (dev == NULL) { - PFE_PMD_ERR("Invalid device in link_update.\n"); - return 0; - } - memset(&old, 0, sizeof(old)); memset(&link, 0, sizeof(struct rte_eth_link)); -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:14.343734353 +0200 +++ 0033-net-pfe-remove-unnecessary-null-check.patch 2021-08-10 15:11:12.970637754 +0200 @@ -1 +1 @@ -From 01bfb518a39b91da7896abe579bcf72d06935bf5 Mon Sep 17 00:00:00 2001 +From 704a3314ef03076bfa9ba120a74de97578f6a01f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 3135466713..feec4d10a2 100644 +index fa3c0ce0fe..4e2ba0565f 100644 @@ -21 +22 @@ -@@ -582,11 +582,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) +@@ -583,11 +583,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)