From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19B00A0C47 for ; Tue, 10 Aug 2021 17:42:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 140CB4014F; Tue, 10 Aug 2021 17:42:14 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 9F13F4014F for ; Tue, 10 Aug 2021 17:42:12 +0200 (CEST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 865663F357 for ; Tue, 10 Aug 2021 15:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610132; bh=4uqvsRUnR8W2HG/P7TYCWEvxXazpEMwta6wKdBpqlPs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eBYq+Xs/sfR2DJiVhtQOfpfM/oc7aQnKOcoZYOvfvn34TfzxDuJI8PiDfk82jxeA7 MtyzjFEo71uMfN7c8cEeJ08TGT7xKOWPK+6L5lDLK28u5Z9k1xhP3+xCSogfAWNoL2 aTaV519ukGP0JpHtQByfRbIHz+SK3nVDPzJhUdBfLtA7L9dLp7iAigoKmg4oKpxcHS L2lhVte8Z9LdDTxB2ZqbwC9/NcNUAGnCJT8MyzyEMf8ry7u2DVV5yHdCe2LxBK/8Z7 gtvnQKzhQYlb3CIcBibJ9Clp88aw7ZPVkso6uVBcPPZ3b3v71CpgHhvJOWT99dnwjZ 2HSyEh/dTJZqA== Received: by mail-ej1-f70.google.com with SMTP id ju25-20020a17090798b9b029058c24b55273so145344ejc.8 for ; Tue, 10 Aug 2021 08:42:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4uqvsRUnR8W2HG/P7TYCWEvxXazpEMwta6wKdBpqlPs=; b=lTT/ZG1S0CdPSna+HKxkcpljBFvY+wVsNu95VcTLaUD/ZyO9026Kc+0ngpzi+SDQ0o bvqklIZZf4fma16LNG6T9l67AgMEaT9bmkhUpgbwWC3FMrUsnlOKmcxVsZg8587FdtlR MQz+KCfNyeHb/xDTVRoc4egU6YxuM2gU0al/MGY75f/qe70RR75Ct0W9J9esaqZyo1Uf pfEDGnXyY+X9t9RRBoaiuefW2gG3SaCXKDR/zxS+qspTgtFO3iJl1lj78r7DC1oJuXi6 AP4KXfzBdsmcxJ3Q2ZcIO31jRRvtQBBstBEDeoexbR4xgHAB2e/85mQgWhU/ffbdrp0j 4uBw== X-Gm-Message-State: AOAM530EQejxypXejH52LVzUTeVy3hYXKKSEh2fllqN1rUfEJy1pLL17 skvZpYEKxDYHVPOc8LZFBzefYDYakjnPuTnMjtGhZX9zNR8qhqK4iNbSpJxYNvcbcnwLyFW55ek PVt6LlhkXU1RND/5zZS27tczj X-Received: by 2002:a17:906:3486:: with SMTP id g6mr695661ejb.71.1628610131957; Tue, 10 Aug 2021 08:42:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3peJ9/2hF5FjwF40axdojc2BdUfY+xRCs4RaoeYUm275G6Uzxzm2y03Is/+rncxL6ezBkWg== X-Received: by 2002:a17:906:3486:: with SMTP id g6mr695651ejb.71.1628610131799; Tue, 10 Aug 2021 08:42:11 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id q8sm9596911edv.95.2021.08.10.08.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:42:11 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Huisong Li Cc: Min Hu , Ferruh Yigit , Xiaoyun Li , dpdk stable Date: Tue, 10 Aug 2021 17:39:15 +0200 Message-Id: <20210810154022.749358-35-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: change port link speed without stopping all' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/ed4de94768fbd47b0ce3b512e2bd93d79d20d75d Thanks. Christian Ehrhardt --- >From ed4de94768fbd47b0ce3b512e2bd93d79d20d75d Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Wed, 28 Apr 2021 16:36:59 +0800 Subject: [PATCH] app/testpmd: change port link speed without stopping all [ upstream commit 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 ] When we use the following cmd to modify the link speed of specified port: "port config speed xxx duplex xxx", we have to stop all ports. It's not necessary. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Acked-by: Ferruh Yigit Acked-by: Xiaoyun Li --- app/test-pmd/cmdline.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 077d860401..3eedb82486 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1704,13 +1704,13 @@ cmd_config_speed_specific_parsed(void *parsed_result, struct cmd_config_speed_specific *res = parsed_result; uint32_t link_speed; - if (!all_ports_stopped()) { - printf("Please stop all ports first\n"); + if (port_id_is_invalid(res->id, ENABLED_WARN)) return; - } - if (port_id_is_invalid(res->id, ENABLED_WARN)) + if (!port_is_stopped(res->id)) { + printf("Please stop port %d first\n", res->id); return; + } if (parse_and_check_speed_duplex(res->value1, res->value2, &link_speed) < 0) -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:14.417958634 +0200 +++ 0035-app-testpmd-change-port-link-speed-without-stopping-.patch 2021-08-10 15:11:12.986637869 +0200 @@ -1 +1 @@ -From 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 Mon Sep 17 00:00:00 2001 +From ed4de94768fbd47b0ce3b512e2bd93d79d20d75d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index bfd2fb9240..8468018cf3 100644 +index 077d860401..3eedb82486 100644 @@ -25 +26 @@ -@@ -1619,13 +1619,13 @@ cmd_config_speed_specific_parsed(void *parsed_result, +@@ -1704,13 +1704,13 @@ cmd_config_speed_specific_parsed(void *parsed_result,