From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0F57A0C47 for ; Tue, 10 Aug 2021 17:43:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B85394114F; Tue, 10 Aug 2021 17:43:12 +0200 (CEST) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mails.dpdk.org (Postfix) with ESMTP id 4772D4014F for ; Tue, 10 Aug 2021 17:43:11 +0200 (CEST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 2AC4D3F0A1 for ; Tue, 10 Aug 2021 15:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610191; bh=1/5p/cZJBo4kWT/BPD40lyUkqGlAXFV23YvJASqdu/o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kOqEJbklPtT3VLRmF3YsgD7T0rAQerr1QQJPCVqPBphk3KvkPM3J4RC2g69+Cn3Q6 ZmwXsMFtL9az3QDSN3xXBy/KXPdcap+PWUzh2EIB9j5fQhFTA1/4biY0U6pE2D9aDv nEZ+byCIppKmPkujhmRm4H7A4LYewNa+S8vYGgRkv24ZFe/sd67ISiaEq6VcMkcq0v /oQxwCxq30g8wN4pbAsKvJBfZSDYBWvLLShyFB6VzIfEwId0d9ZqR4/5B/XqPYY40n v8v9zNYD7hLyp7h6lpIrDHqHh1FDB3FauBQGZP+nMeXERP8a7/lywAuJq6afJfnOt7 ys2nXPd0P4muw== Received: by mail-ed1-f71.google.com with SMTP id s8-20020a0564025208b02903bd8539e1caso10956790edd.22 for ; Tue, 10 Aug 2021 08:43:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1/5p/cZJBo4kWT/BPD40lyUkqGlAXFV23YvJASqdu/o=; b=nbUSGS+TxWoMOS+KFSE1pGFzE0T6S8cfqpu3xwxg0dhzYR2vTYHAS2O/zuI3QBKIbf 0ZgzZFK0i8R1o+oNIOxKjHd0+HgrlewSgxE0IUwQX0haJRH7b35PG7oqROptH8o2o6lA LoSkNabMqrx+/E9dBL0gDs8Unyf3hifMLDss3cLCpQfrx5FN0yLMk1G4EpzmooVLAjTL 5IWT3PmcGjKCz9vfmfxV2uXEVK7Su1vKAL/js5SpmSNGDdLfwCLCiyUl0Jlh5o9vODnR 5Mi1Q5LzA48aBoh+dn346av9mDnuyvvP4HhRWUbmMSz6dHIYXrR6RI99iumSIJ07ZbOh kVNg== X-Gm-Message-State: AOAM530FYdZzX2vFVfpBswZBJFCweEOf415bvq8KTO1Q0Ch7Yj7jI/36 YR2a6+de9hQVg/b8RSfbBCngtPO/MGasOWMQy8joo3M+ugAz14w9nCCbHHAd0orbCO0BzVVQGsv 0dS2AplUsNdrrRAypfg8Txa0N X-Received: by 2002:a05:6402:95a:: with SMTP id h26mr5634243edz.109.1628610190867; Tue, 10 Aug 2021 08:43:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo1QLkmBsfjl3fDmJoB9qFs1ajgpe81Tl7AzT615K+gNwFnxHywhFz9q09LRpSiNQYuR4V4Q== X-Received: by 2002:a05:6402:95a:: with SMTP id h26mr5634223edz.109.1628610190698; Tue, 10 Aug 2021 08:43:10 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id lk14sm7034740ejb.9.2021.08.10.08.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:43:10 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Dmitry Kozlyuk Cc: Viacheslav Ovsiienko , dpdk stable Date: Tue, 10 Aug 2021 17:39:32 +0200 Message-Id: <20210810154022.749358-52-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'doc: add limitation for ConnectX-4 with L2 in mlx5 guide' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/9910c05442d047432d15c8721726dabdc88b478c Thanks. Christian Ehrhardt --- >From 9910c05442d047432d15c8721726dabdc88b478c Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Wed, 30 Jun 2021 10:01:06 +0300 Subject: [PATCH] doc: add limitation for ConnectX-4 with L2 in mlx5 guide [ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ] ConnectX-4 and ConnectX-4 Lx NICs require all L2 headers of transmitted packets to be inlined. By default only first 18 bytes are inlined, which is insufficient if additional encapsulation is used, like Q-in-Q. Thus, default settings caused such traffic to be dropepd on Tx. Document a recommendation to increase inlined data size in such cases. Fixes: 505f1fe426d3 ("net/mlx5: add Tx devargs") Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index bbad7d0d5b..3ce4fda641 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -498,6 +498,13 @@ Run-time configuration it is not recommended and may prevent NIC from sending packets over some configurations. + For ConnectX-4 and ConnectX-4 Lx NICs, automatically configured value + is insufficient for some traffic, because they require at least all L2 headers + to be inlined. For example, Q-in-Q adds 4 bytes to default 18 bytes + of Ethernet and VLAN, thus ``txq_inline_min`` must be set to 22. + MPLS would add 4 bytes per label. Final value must account for all possible + L2 encapsulation headers used in particular environment. + Please, note, this minimal data inlining disengages eMPW feature (Enhanced Multi-Packet Write), because last one does not support partial packet inlining. This is not very critical due to minimal data inlining is mostly required -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:15.032307837 +0200 +++ 0052-doc-add-limitation-for-ConnectX-4-with-L2-in-mlx5-gu.patch 2021-08-10 15:11:13.030638186 +0200 @@ -1 +1 @@ -From e60561cc955ac01512a35ca309793e351cef3c9b Mon Sep 17 00:00:00 2001 +From 9910c05442d047432d15c8721726dabdc88b478c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 0d96eec2bb..5b4bb13914 100644 +index bbad7d0d5b..3ce4fda641 100644 @@ -25 +26 @@ -@@ -700,6 +700,13 @@ Driver options +@@ -498,6 +498,13 @@ Run-time configuration