From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA8A1A0C47 for ; Tue, 10 Aug 2021 17:44:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFFF2411C3; Tue, 10 Aug 2021 17:44:12 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 365654014F for ; Tue, 10 Aug 2021 17:44:12 +0200 (CEST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 1EA083F107 for ; Tue, 10 Aug 2021 15:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610252; bh=IrBIzJmHkeD93SC88yLwazuCoX4QH34fjLfYPXK/qdk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rAR2sbrowqbp6hVX4SYCupxO5mUJSn011qZhzzuaRMGNN3XONit3yl+WqtMPD7TZ/ 3OXh7wmRTcWd/+Oltj3k7flnTzQOANbEsarjMwP7tfFQZlcaoiuVwG93JrE+wZ6OkN g0uC3mt1pbt8fcPgJ0A7ufvA9boM0nermeomMoJp8RrIGtw3fVhC3I3FGLb/N7AwrJ lthrfeCXrCKz9Ks1hNmFWxB2L7M4WQ3Sgj8BfSARv9V0AooTdaZ6O1MInbgs2F/APQ J2BZJESfEhXC1VIp+FnfXiSnqJA3xxYYm5SUKx0ni30eyjXkDc0ZWHOu0XsOZNH6Gp 6srzs+41m/9sA== Received: by mail-ej1-f70.google.com with SMTP id ju25-20020a17090798b9b029058c24b55273so147665ejc.8 for ; Tue, 10 Aug 2021 08:44:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IrBIzJmHkeD93SC88yLwazuCoX4QH34fjLfYPXK/qdk=; b=Sa2i+QgcKq4sIdCGKTG7pS62/orNA5Fz6eGRCR7bV4hAeaGou1irqYmL7JfvW3Yupi 4AG05b4VvnSprYc7UebQHBMvYHW81xGWRPynPXPfIEvdde2KR1kZo8/JCZLq+bOFQnh0 a9rd+ltE3Na5ec+DJFAgSOJ6mO8ftsYInuuyNMFeDUWrCGkcOM8qyuuInT9daIIUKgib Ae7ZvxZxm/iFBBeabvlyb+HBXwQNlKpSsHkrdAJXc9+PgfnscouYuZ7JTzLRpkmsjLVN Rz5sWLZKD8bvF+PAaJCW+rYqSN34svEzWU3AJ4i918VFHMvixVGeDRVDccQeFuW+2DTn YYyg== X-Gm-Message-State: AOAM531hm+TrI9cPKMDtjDH5VqyLR1f2Fz7URfC7CAlLvrFn55KgB3Eh qijNY6+9YfwYZOWze5UdtChSnOR93QeEcDbFmTmMZEkUbAe1x2jP1/8++JvGMT7Dtqc1nOD0m3R M35GFtwNQpKU5wkDwqd7ZYQap X-Received: by 2002:a17:906:d0d5:: with SMTP id bq21mr9390302ejb.470.1628610251700; Tue, 10 Aug 2021 08:44:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+XWCnLJ9paK/n/NlSoM0r4gUyOjXrah4GilptNoW4zhMGB+eOfJvrZ6kBfIueCRK34n9cVA== X-Received: by 2002:a17:906:d0d5:: with SMTP id bq21mr9390288ejb.470.1628610251454; Tue, 10 Aug 2021 08:44:11 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id fp5sm3646319ejc.6.2021.08.10.08.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:44:11 -0700 (PDT) From: christian.ehrhardt@canonical.com To: David Hunt Cc: dpdk stable Date: Tue, 10 Aug 2021 17:39:52 +0200 Message-Id: <20210810154022.749358-72-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'distributor: fix 128-bit write alignment' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/4e4f0af3f678990014815f5326f5078234a3b24a Thanks. Christian Ehrhardt --- >From 4e4f0af3f678990014815f5326f5078234a3b24a Mon Sep 17 00:00:00 2001 From: David Hunt Date: Fri, 16 Jul 2021 14:32:37 +0100 Subject: [PATCH] distributor: fix 128-bit write alignment [ upstream commit de8606bf73323dfa8395f2dc0a93dc6194ff21b7 ] When the distributor sample app is built as a 32-bit app, the data buffer passed to find_match_vec can be unaligned, causing a segmentation fault due to writing a 128-bit value using _mm_store_si128(). 128-bit align the data being passed in so this does not happen. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Signed-off-by: David Hunt --- lib/librte_distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index ef34facba6..50a2d0ee11 100644 --- a/lib/librte_distributor/rte_distributor.c +++ b/lib/librte_distributor/rte_distributor.c @@ -477,7 +477,7 @@ rte_distributor_process(struct rte_distributor *d, return 0; while (next_idx < num_mbufs) { - uint16_t matches[RTE_DIST_BURST_SIZE]; + uint16_t matches[RTE_DIST_BURST_SIZE] __rte_aligned(128); unsigned int pkts; if ((num_mbufs - next_idx) < RTE_DIST_BURST_SIZE) -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:15.804671149 +0200 +++ 0072-distributor-fix-128-bit-write-alignment.patch 2021-08-10 15:11:13.078638532 +0200 @@ -1 +1 @@ -From de8606bf73323dfa8395f2dc0a93dc6194ff21b7 Mon Sep 17 00:00:00 2001 +From 4e4f0af3f678990014815f5326f5078234a3b24a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de8606bf73323dfa8395f2dc0a93dc6194ff21b7 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/distributor/rte_distributor.c | 2 +- + lib/librte_distributor/rte_distributor.c | 2 +- @@ -20,5 +21,5 @@ -diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c -index 07e385a259..c210cf86bd 100644 ---- a/lib/distributor/rte_distributor.c -+++ b/lib/distributor/rte_distributor.c -@@ -478,7 +478,7 @@ rte_distributor_process(struct rte_distributor *d, +diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c +index ef34facba6..50a2d0ee11 100644 +--- a/lib/librte_distributor/rte_distributor.c ++++ b/lib/librte_distributor/rte_distributor.c +@@ -477,7 +477,7 @@ rte_distributor_process(struct rte_distributor *d,