From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78879A0C47 for ; Tue, 10 Aug 2021 17:44:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 726044014F; Tue, 10 Aug 2021 17:44:44 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 4A91C4114F for ; Tue, 10 Aug 2021 17:44:43 +0200 (CEST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 34F8C3F338 for ; Tue, 10 Aug 2021 15:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610283; bh=B4u4MLEkE3+9/32Pu31EvLNUnrbNGuAeCxP7Xte1u+o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LGl9uHmWndJZuZIYHG9ukB/wuLDw+i3DMdNsFC+Oz+Uc9xRQx3IWi9lgvbffnOdIZ zKuxBD8fblFN6rsvICIsipb6MqObwoys9L0SjKukNeW/J3EUaWZXt7OGZasf9RnalG /TTXP5BN0sJW2u9FEz8f0Vpj6nUEE0KXsJw4hOEzKFw/8tGLZSiXRSkPMdcwBp7Nw+ 2YwfnmJQm/7r0FarHBgUBzn3x1fjutzvsIGNRiif5RQqlNtGPfSJuG2trWEKyVsY7b me28rpSb76V12u58mowz9FO2XJPdYpuEYf+2IXwhWCk45XdzV7kJwiUDCZcEk0BaI9 +XGXbn/GHlWDA== Received: by mail-ej1-f71.google.com with SMTP id nb40-20020a1709071ca8b02905992266c319so5705731ejc.21 for ; Tue, 10 Aug 2021 08:44:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B4u4MLEkE3+9/32Pu31EvLNUnrbNGuAeCxP7Xte1u+o=; b=IsC70CxwGy1xA7YqPD4Hc/RSEPR2Ok3W9ptc3vs58miUAJLBN+i2cDiT8GA0XL1/Z9 A+THP00Now0YylY33vCTRRdIDS4zPIiwMfu6vDkrAH3DJerFtTnYabDJLKMjprc/BYg9 wObGP/hPZWnuj5J5qeZ8J+IvAKFetsotSl4gYVfQlXoy2IT4z7w89sSKwh1U6i9deEGt IGiR4OhgZ+kZHWDyLe82GKZ8A2FtyGUo/V8QIy8Pqb+zoxzDuQj1GTfAwt9B54VMFdlR SC+l9UyeEDWeOTazD48EdAQrN15YB4V7aHR3ZVx7Vq1v6S65LEYd9id+8cI5Iz21naW3 RZPQ== X-Gm-Message-State: AOAM533/ytkUABYD5zdi7mSHVmLJQuqvFGRcYG2OnIWlSQkPByLqmNPG j29NWOe7QsUOv6OwrhLhNn+tM7xOTRnMxPh/DVlvoiD270cPlbDI52K4536ad78KRJbbbXw2Qto qiFy5uyDEt78MixHhlxMulLSX X-Received: by 2002:a17:906:769a:: with SMTP id o26mr15808443ejm.18.1628610282918; Tue, 10 Aug 2021 08:44:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjLMtLS772eqV1fpKoCI0Bvza77i+UEnboN+oliGkb/pu8+3k0SjW/62jjS3SCh7oaWYQr0g== X-Received: by 2002:a17:906:769a:: with SMTP id o26mr15808429ejm.18.1628610282688; Tue, 10 Aug 2021 08:44:42 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id a2sm415889edm.72.2021.08.10.08.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:44:42 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Guoyang Zhou Cc: dpdk stable Date: Tue, 10 Aug 2021 17:40:03 +0200 Message-Id: <20210810154022.749358-83-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hinic/base: fix LRO' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/989c4886e7ce3e926ec16b11c0e04979ef48ceca Thanks. Christian Ehrhardt --- >From 989c4886e7ce3e926ec16b11c0e04979ef48ceca Mon Sep 17 00:00:00 2001 From: Guoyang Zhou Date: Fri, 16 Jul 2021 17:54:29 +0800 Subject: [PATCH] net/hinic/base: fix LRO [ upstream commit 68fa836d0ff83229e1404f1274c90e1bff2475c8 ] The Rx queue must config as ceq disables, and must set MSI-X state disabled. Otherwise when LRO is enables, there will be problems with packet aggregation because of firmware. Fixes: 9d02f40d6503 ("net/hinic: fix LRO") Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_nicio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hinic/base/hinic_pmd_nicio.c b/drivers/net/hinic/base/hinic_pmd_nicio.c index 9d9f2a7a56..928a35da78 100644 --- a/drivers/net/hinic/base/hinic_pmd_nicio.c +++ b/drivers/net/hinic/base/hinic_pmd_nicio.c @@ -230,8 +230,8 @@ static void hinic_rq_prepare_ctxt(struct hinic_rq *rq, wq_block_pfn_hi = upper_32_bits(wq_block_pfn); wq_block_pfn_lo = lower_32_bits(wq_block_pfn); - /* must config as ceq enable but do not generate ceq */ - rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(1, EN) | + /* config as ceq disable, but must set msix state disable */ + rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(0, EN) | RQ_CTXT_CEQ_ATTR_SET(1, OWNER); rq_ctxt->pi_intr_attr = RQ_CTXT_PI_SET(pi_start, IDX) | -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:16.218738939 +0200 +++ 0083-net-hinic-base-fix-LRO.patch 2021-08-10 15:11:13.094638647 +0200 @@ -1 +1 @@ -From 68fa836d0ff83229e1404f1274c90e1bff2475c8 Mon Sep 17 00:00:00 2001 +From 989c4886e7ce3e926ec16b11c0e04979ef48ceca Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68fa836d0ff83229e1404f1274c90e1bff2475c8 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 162308b02f..ad5db9f1de 100644 +index 9d9f2a7a56..928a35da78 100644