From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 149E0A0C47 for ; Tue, 10 Aug 2021 17:45:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C9FB411C8; Tue, 10 Aug 2021 17:45:33 +0200 (CEST) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mails.dpdk.org (Postfix) with ESMTP id 52E2E411C5 for ; Tue, 10 Aug 2021 17:45:32 +0200 (CEST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 2B9863F0FD for ; Tue, 10 Aug 2021 15:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628610332; bh=4CgMoUea/p51N+yx3BK7jclRsFpBLaDk1uIsUA27IH8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=odLktBbL1ziDTP4LA1Gb4EaZvL/jlwxyQaJ4a/Onpdct6hlgSbaU3TcNPnzv9QfPa +HoiOnsfbNZZSC+VF7JBdsAASrGUZvHzGcXBw4q2AfkWBI8veI9tQRiwXkLeJgV++z aisK6/mmT3bVmh6/fDzk0vx+TKQHY9OeYpJjnB+cASb/yF92Kg5AatDcuowZPdz2Su 2+AlJ0CClYF6xg4itvMDrkyANZlh7JsJjfPInpwLVjkVG7pVfEZi1g4GoAzHKvbUCv uIhyta/ofgvh9zIwXCFfnCgO/sw9F1YleszLf0ZjfPtPzyaaY2U1quCvAUIFbphS/7 ztf4m6v9l5C9Q== Received: by mail-ej1-f72.google.com with SMTP id ja25-20020a1709079899b02905b2a2bf1a62so1715361ejc.4 for ; Tue, 10 Aug 2021 08:45:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4CgMoUea/p51N+yx3BK7jclRsFpBLaDk1uIsUA27IH8=; b=GeOLu3EzvD6Jvvv4mwpRH+rDHvyOzEzBCtI12NL8F+vGLYTmE27rsfHLDZAy10G898 sgp9nWfcPrprNfsbw2N7RC7p9nV8DPEwfzdz3UbxdlF6Vig8YyGBozQVWPf1PTvXKXdP Y/fbmx4VQS2v0ReIAIqR6aVqpKhkrO0wLfRfZI1z+9fj1ivKqUypK78fN90vCn/DzgdG UAm/wA1PJaEv3X7Rez+FlEwHmGe09AcPrhqb4GbnMSVjnOVrBDF3Cqe/AtnSRut35TTh cWe8uqP8xkRRUyS6hD0rlTkT2S/mFtEVTEcZj7075IkvNSl+WzMX3HPQGjCuKHFIGsuG /3+Q== X-Gm-Message-State: AOAM532+k4jD00j2ZtqlpT4rRs/h3VZvuu2vgSUGUAgfnlnZegsgnDeu teRQuku38Sxp4Tm24ttbkkQqjI+EoEnPJlyukzfNjc6XtDcUIe+zxeVqPFnEXp6yIvbOZD/ubUe fDvUWQfjM6UfdCdFz0HYOpo2D X-Received: by 2002:a17:906:8047:: with SMTP id x7mr28877572ejw.453.1628610329849; Tue, 10 Aug 2021 08:45:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu2kHpCPu4yfYjyO51MQumojfzaFnlmSC+dBZ5pd8P/Qk6+z6pJP0LFhAEL5tA57KkqtQyCQ== X-Received: by 2002:a17:906:8047:: with SMTP id x7mr28877373ejw.453.1628610327433; Tue, 10 Aug 2021 08:45:27 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id w20sm317783edu.22.2021.08.10.08.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:45:27 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Dapeng Yu Cc: Jasvinder Singh , dpdk stable Date: Tue, 10 Aug 2021 17:40:17 +0200 Message-Id: <20210810154022.749358-97-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810154022.749358-1-christian.ehrhardt@canonical.com> References: <20210810154022.749358-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/softnic: fix memory leak as profile is freed' has been queued to stable release 19.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/7f2d70b40028de98e2734a6acdad8eca0e745e94 Thanks. Christian Ehrhardt --- >From 7f2d70b40028de98e2734a6acdad8eca0e745e94 Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Wed, 28 Jul 2021 14:05:39 +0800 Subject: [PATCH] net/softnic: fix memory leak as profile is freed [ upstream commit b3bc560bd6bdf3c9851d25bc0a66cb24aa1fd48c ] In function softnic_table_action_profile_free(), the memory referenced by pointer "ap" in the instance of "struct softnic_table_action_profile" is not freed. This patch fixes it. Fixes: a737dd4e5863 ("net/softnic: add table action profile") Signed-off-by: Dapeng Yu Acked-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_action.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/softnic/rte_eth_softnic_action.c b/drivers/net/softnic/rte_eth_softnic_action.c index 92c744dc9a..33be9552a6 100644 --- a/drivers/net/softnic/rte_eth_softnic_action.c +++ b/drivers/net/softnic/rte_eth_softnic_action.c @@ -183,6 +183,7 @@ softnic_table_action_profile_free(struct pmd_internals *p) break; TAILQ_REMOVE(&p->table_action_profile_list, profile, node); + rte_table_action_profile_free(profile->ap); free(profile); } } -- 2.32.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-08-10 15:11:16.735793046 +0200 +++ 0097-net-softnic-fix-memory-leak-as-profile-is-freed.patch 2021-08-10 15:11:13.130638908 +0200 @@ -1 +1 @@ -From b3bc560bd6bdf3c9851d25bc0a66cb24aa1fd48c Mon Sep 17 00:00:00 2001 +From 7f2d70b40028de98e2734a6acdad8eca0e745e94 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b3bc560bd6bdf3c9851d25bc0a66cb24aa1fd48c ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org