From: Feifei Wang <feifei.wang2@arm.com>
To: christian.ehrhardt@canonical.com
Cc: stable@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,
shahafs@mellanox.com, Ruifeng Wang <ruifeng.wang@arm.com>
Subject: [dpdk-stable] [PATCH 19.11] net/mlx5: fix incorrect r/w lock usage in DMA unmap
Date: Wed, 11 Aug 2021 16:31:46 +0800 [thread overview]
Message-ID: <20210811083146.2048667-1-feifei.wang2@arm.com> (raw)
[ upstream commit 1c196da274b82e6f1642bde7b1c407a2066caee1 ]
For mlx5 DMA unmap, write lock should be used for rebuilding memory
region cache table rather than read lock.
Fixes: 989e999d9305 ("net/mlx5: support PCI device DMA map and unmap")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
drivers/net/mlx5/mlx5_mr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c
index 54a11bd5d1..71c2254c91 100644
--- a/drivers/net/mlx5/mlx5_mr.c
+++ b/drivers/net/mlx5/mlx5_mr.c
@@ -1397,10 +1397,10 @@ mlx5_dma_unmap(struct rte_pci_device *pdev, void *addr,
}
priv = dev->data->dev_private;
sh = priv->sh;
- rte_rwlock_read_lock(&sh->mr.rwlock);
+ rte_rwlock_write_lock(&sh->mr.rwlock);
mr = mr_lookup_dev_list(sh, &entry, (uintptr_t)addr);
if (!mr) {
- rte_rwlock_read_unlock(&sh->mr.rwlock);
+ rte_rwlock_write_unlock(&sh->mr.rwlock);
DRV_LOG(WARNING, "address 0x%" PRIxPTR " wasn't registered "
"to PCI device %p", (uintptr_t)addr,
(void *)pdev);
@@ -1424,7 +1424,7 @@ mlx5_dma_unmap(struct rte_pci_device *pdev, void *addr,
++sh->mr.dev_gen;
DEBUG("broadcasting local cache flush, gen=%d", sh->mr.dev_gen);
rte_smp_wmb();
- rte_rwlock_read_unlock(&sh->mr.rwlock);
+ rte_rwlock_write_unlock(&sh->mr.rwlock);
return 0;
}
--
2.25.1
next reply other threads:[~2021-08-11 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:31 Feifei Wang [this message]
2021-08-11 8:48 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811083146.2048667-1-feifei.wang2@arm.com \
--to=feifei.wang2@arm.com \
--cc=christian.ehrhardt@canonical.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).