* [dpdk-stable] [PATCH v3 1/4] app/testpmd: fix tx retry in flowgen [not found] ` <20210812111105.54307-1-wangzhihong.wzh@bytedance.com> @ 2021-08-12 11:11 ` Zhihong Wang 0 siblings, 0 replies; 5+ messages in thread From: Zhihong Wang @ 2021-08-12 11:11 UTC (permalink / raw) To: dev, ferruh.yigit, xiaoyun.li, aman.deep.singh, irusskikh, cchemparathy Cc: Zhihong Wang, stable Fix tx_pkt number in tx retry logic. Fixes: bf56fce1fb4 ("app/testpmd: add retry option") Cc: stable@dpdk.org Signed-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com> --- app/test-pmd/flowgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 3bf6e1ce97..f2e6255c36 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -192,12 +192,12 @@ pkt_burst_flow_gen(struct fwd_stream *fs) /* * Retry if necessary */ - if (unlikely(nb_tx < nb_rx) && fs->retry_enabled) { + if (unlikely(nb_tx < nb_pkt) && fs->retry_enabled) { retry = 0; - while (nb_tx < nb_rx && retry++ < burst_tx_retry_num) { + while (nb_tx < nb_pkt && retry++ < burst_tx_retry_num) { rte_delay_us(burst_tx_delay_time); nb_tx += rte_eth_tx_burst(fs->tx_port, fs->tx_queue, - &pkts_burst[nb_tx], nb_rx - nb_tx); + &pkts_burst[nb_tx], nb_pkt - nb_tx); } } fs->tx_packets += nb_tx; -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20210812131901.25665-1-wangzhihong.wzh@bytedance.com>]
* [dpdk-stable] [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen [not found] ` <20210812131901.25665-1-wangzhihong.wzh@bytedance.com> @ 2021-08-12 13:18 ` Zhihong Wang 2021-08-13 1:33 ` Li, Xiaoyun 0 siblings, 1 reply; 5+ messages in thread From: Zhihong Wang @ 2021-08-12 13:18 UTC (permalink / raw) To: dev, ferruh.yigit, xiaoyun.li, aman.deep.singh, irusskikh, cchemparathy Cc: Zhihong Wang, stable Fix tx_pkt number in tx retry logic. Fixes: bf56fce1fb4 ("app/testpmd: add retry option") Cc: stable@dpdk.org Signed-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com> --- app/test-pmd/flowgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 3bf6e1ce97..f2e6255c36 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -192,12 +192,12 @@ pkt_burst_flow_gen(struct fwd_stream *fs) /* * Retry if necessary */ - if (unlikely(nb_tx < nb_rx) && fs->retry_enabled) { + if (unlikely(nb_tx < nb_pkt) && fs->retry_enabled) { retry = 0; - while (nb_tx < nb_rx && retry++ < burst_tx_retry_num) { + while (nb_tx < nb_pkt && retry++ < burst_tx_retry_num) { rte_delay_us(burst_tx_delay_time); nb_tx += rte_eth_tx_burst(fs->tx_port, fs->tx_queue, - &pkts_burst[nb_tx], nb_rx - nb_tx); + &pkts_burst[nb_tx], nb_pkt - nb_tx); } } fs->tx_packets += nb_tx; -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen 2021-08-12 13:18 ` [dpdk-stable] [PATCH v4 " Zhihong Wang @ 2021-08-13 1:33 ` Li, Xiaoyun 2021-08-13 2:27 ` [dpdk-stable] [External] " 王志宏 0 siblings, 1 reply; 5+ messages in thread From: Li, Xiaoyun @ 2021-08-13 1:33 UTC (permalink / raw) To: Zhihong Wang, dev, Yigit, Ferruh, Singh, Aman Deep, irusskikh, cchemparathy Cc: stable Hi > -----Original Message----- > From: Zhihong Wang <wangzhihong.wzh@bytedance.com> > Sent: Thursday, August 12, 2021 21:19 > To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun > <xiaoyun.li@intel.com>; Singh, Aman Deep <aman.deep.singh@intel.com>; > irusskikh@marvell.com; cchemparathy@tilera.com > Cc: Zhihong Wang <wangzhihong.wzh@bytedance.com>; stable@dpdk.org > Subject: [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen > > Fix tx_pkt number in tx retry logic. > > Fixes: bf56fce1fb4 ("app/testpmd: add retry option") Missing one character, it should be 12. Fixes: bf56fce1fb45 ("app/testpmd: add retry option") Except this, Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [External] RE: [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen 2021-08-13 1:33 ` Li, Xiaoyun @ 2021-08-13 2:27 ` 王志宏 0 siblings, 0 replies; 5+ messages in thread From: 王志宏 @ 2021-08-13 2:27 UTC (permalink / raw) To: Li, Xiaoyun Cc: dev, Yigit, Ferruh, Singh, Aman Deep, irusskikh, cchemparathy, stable On Fri, Aug 13, 2021 at 9:33 AM Li, Xiaoyun <xiaoyun.li@intel.com> wrote: > > Hi > > > -----Original Message----- > > From: Zhihong Wang <wangzhihong.wzh@bytedance.com> > > Sent: Thursday, August 12, 2021 21:19 > > To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun > > <xiaoyun.li@intel.com>; Singh, Aman Deep <aman.deep.singh@intel.com>; > > irusskikh@marvell.com; cchemparathy@tilera.com > > Cc: Zhihong Wang <wangzhihong.wzh@bytedance.com>; stable@dpdk.org > > Subject: [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen > > > > Fix tx_pkt number in tx retry logic. > > > > Fixes: bf56fce1fb4 ("app/testpmd: add retry option") > > Missing one character, it should be 12. Got it. Thanks Xiaoyun. > Fixes: bf56fce1fb45 ("app/testpmd: add retry option") > > Except this, Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20210813080548.38637-1-wangzhihong.wzh@bytedance.com>]
* [dpdk-stable] [PATCH v5 1/4] app/testpmd: fix tx retry in flowgen [not found] ` <20210813080548.38637-1-wangzhihong.wzh@bytedance.com> @ 2021-08-13 8:05 ` Zhihong Wang 0 siblings, 0 replies; 5+ messages in thread From: Zhihong Wang @ 2021-08-13 8:05 UTC (permalink / raw) To: dev, ferruh.yigit, xiaoyun.li, aman.deep.singh, irusskikh, cchemparathy Cc: Zhihong Wang, stable Fix tx_pkt number in tx retry logic. Fixes: bf56fce1fb45 ("app/testpmd: add retry option") Cc: stable@dpdk.org Signed-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> --- app/test-pmd/flowgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 3bf6e1ce97..f2e6255c36 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -192,12 +192,12 @@ pkt_burst_flow_gen(struct fwd_stream *fs) /* * Retry if necessary */ - if (unlikely(nb_tx < nb_rx) && fs->retry_enabled) { + if (unlikely(nb_tx < nb_pkt) && fs->retry_enabled) { retry = 0; - while (nb_tx < nb_rx && retry++ < burst_tx_retry_num) { + while (nb_tx < nb_pkt && retry++ < burst_tx_retry_num) { rte_delay_us(burst_tx_delay_time); nb_tx += rte_eth_tx_burst(fs->tx_port, fs->tx_queue, - &pkts_burst[nb_tx], nb_rx - nb_tx); + &pkts_burst[nb_tx], nb_pkt - nb_tx); } } fs->tx_packets += nb_tx; -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-13 8:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210809062548.30187-1-wangzhihong.wzh@bytedance.com>
[not found] ` <20210812111105.54307-1-wangzhihong.wzh@bytedance.com>
2021-08-12 11:11 ` [dpdk-stable] [PATCH v3 1/4] app/testpmd: fix tx retry in flowgen Zhihong Wang
[not found] ` <20210812131901.25665-1-wangzhihong.wzh@bytedance.com>
2021-08-12 13:18 ` [dpdk-stable] [PATCH v4 " Zhihong Wang
2021-08-13 1:33 ` Li, Xiaoyun
2021-08-13 2:27 ` [dpdk-stable] [External] " 王志宏
[not found] ` <20210813080548.38637-1-wangzhihong.wzh@bytedance.com>
2021-08-13 8:05 ` [dpdk-stable] [PATCH v5 " Zhihong Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).