From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 154FEA0C57 for ; Tue, 31 Aug 2021 19:15:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 076C940687; Tue, 31 Aug 2021 19:15:21 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id A62D54013F for ; Tue, 31 Aug 2021 19:15:18 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id r13so15106736pff.7 for ; Tue, 31 Aug 2021 10:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ILycEQBrflNYHmoGLf2ZOVC2pCCKrI/1LbN8MNnsGiM=; b=KNlkm3mpIdvqvC0Txgej/FcuNcCuxNB7nBh6xZOQkLF/UdM2WBkSur+ruuNNJPiP/X v0NycWRX5BAA+wQ2yMdjz5BCorIk1aVUohIilh5py1hOzIjJrpIvcwWzhiaePzLM/+mo Uc+swZvGUDvmBy8GA7sL0Z856dkhRCs8heavCRGudFHyfxr+pkHWtwprVUsP6CVgE5br ZpwHE900PtMqeJN+H3WLXuRWNJwFJt9qwTX7XmO5iEnNiwXnLiyiaSUlMnI+7s2zCQmH hT0Tt42z/e2YYW4EDqDT1OfPecw5jUt+DnYsHMLJT7j4C1x2sJjKLDCeD3mnzCTgbPr6 g5LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ILycEQBrflNYHmoGLf2ZOVC2pCCKrI/1LbN8MNnsGiM=; b=eY2wZW5p7bDQ2OoubWgeraXdBGvzDB4iV8wOdJU/HbFMkwtY1vnW+BY+tYUmQcnKjw pNNponfcB77773ukZcXrv1tKEQByqA2jfPzxGRg11Jwn60yFlerjA9YEf8h4WBxtNHF8 nhF7fePmCkpdJjp2JFPOumLl/9aRDS0dYRVn9xMufXldHdaBaCRabFcaBzmC0YtRiyIR TrwXPNbUDbh2m0KEdSy2GRx3Gm7McZU2bhXJ/o8U7jSpIB99cXeRG0DlAMBdSNKsZMxu /I3IL0l3nLkPLXBMprXaI1JMqPJmsAlSV9qrmSYrmCodT6NTU7ECAEB06ciSSrrePT9F mXDA== X-Gm-Message-State: AOAM5312J4ipweDS8Ka6ZP8h3UvL2tqR9JkN+jr/XTYtj69vsHSeRI8o oPyN0kxioYsKD4NUpsjY+BCxTQ== X-Google-Smtp-Source: ABdhPJyoYLcgz9VAS+6dOTe66TvBUDL4d3o3/pUfTcjk1zuBP/4PaYzP/bNwZVH7D6sPOxDg0cq2vw== X-Received: by 2002:a62:ae10:0:b0:3f2:b79:886e with SMTP id q16-20020a62ae10000000b003f20b79886emr28696491pff.47.1630430117794; Tue, 31 Aug 2021 10:15:17 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id d4sm8099465pfv.21.2021.08.31.10.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 10:15:17 -0700 (PDT) Date: Tue, 31 Aug 2021 10:15:14 -0700 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: dev@dpdk.org, Stephen Hemminger , Jonathan Erb , Long Li , stable@dpdk.org Message-ID: <20210831101514.2e6d1bba@hermes.local> In-Reply-To: <1630389404-13468-1-git-send-email-longli@linuxonhyperv.com> References: <1630389404-13468-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] bus/vmbus: map to the correct ring buffer addresses for the secondary process X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 30 Aug 2021 22:56:44 -0700 longli@linuxonhyperv.com wrote: > From: Long Li > > The driver code had wrong assumption that all the addresses to ring buffers > in the secondary process are the same as those in the primary process. This > is not always correct as the channels could be mapped to different > addresses in the secondary process. > > Fix this by keeping track of all the mapped addresses from the primary > process in the shared uio_res, and have second process map to the same > addresses. > > Reported-by: Jonathan Erb > Cc: stable@dpdk.org > Signed-off-by: Long Li I prefer that messages not get split across lines, but this looks fine. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Acked-by: Stephen Hemminger