[dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[Qiming Chen]

In the embedded RTOS environment, the x722 controller Ethernet card of
the d2146nt chip, the vfio user mode driver takes over 8 vf ports in
turn, but i40evf_check_vf_reset_done will probably fail.

This issue has been discussed with intel&dpdk experts for 3 rounds
before, and the version matching is no problem, and there is no
substantial progress. The official website contacted external experts,
but there was no response afterwards. Learning from the implementation
of the i40evf kernel driver locally, after modifying the polling time
from 1 second to 5s, the repeated restart process took over the start
port test, and it was found that this probability was reduced to an
order of magnitude acceptable to the user.

The patch cannot fundamentally solve the failure problem, but it greatly
slows down the probability of the problem. The modification is based on the
i40evf kernel driver.

Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Cc: stable@dpdk.org

Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f64db72e9a..924da8dfb4 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -42,7 +42,7 @@
 /* busy wait delay in msec */
 #define I40EVF_BUSY_WAIT_DELAY 10
 #define I40EVF_BUSY_WAIT_COUNT 50
-#define MAX_RESET_WAIT_CNT     20
+#define MAX_RESET_WAIT_CNT     100
 
 #define I40EVF_ALARM_INTERVAL 50000 /* us */
 
-- 
2.30.1.windows.1

Re: [dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[Xing, Beilei]

> -----Original Message-----
> From: Qiming Chen <chenqiming_huawei@163.com>
> Sent: Monday, September 6, 2021 3:14 PM
> To: stable@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> <chenqiming_huawei@163.com>
> Subject: [PATCH 20.11] net/i40e: extend the polling times of vf reset
> 
> In the embedded RTOS environment, the x722 controller Ethernet card of the
> d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but
> i40evf_check_vf_reset_done will probably fail.
> 
> This issue has been discussed with intel&dpdk experts for 3 rounds before,
> and the version matching is no problem, and there is no substantial progress.
> The official website contacted external experts, but there was no response
> afterwards. Learning from the implementation of the i40evf kernel driver
> locally, after modifying the polling time from 1 second to 5s, the repeated
> restart process took over the start port test, and it was found that this
> probability was reduced to an order of magnitude acceptable to the user.

This detail segment of communication between PAEs can be removed.

> 
> The patch cannot fundamentally solve the failure problem, but it greatly
> slows down the probability of the problem. The modification is based on the
> i40evf kernel driver.
> 
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")

I think the fix commit id is 4861cde4611601ccc9d467675f9d7a10c3095b54 (i40e: new poll mode driver)


> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f64db72e9a..924da8dfb4 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -42,7 +42,7 @@
>  /* busy wait delay in msec */
>  #define I40EVF_BUSY_WAIT_DELAY 10
>  #define I40EVF_BUSY_WAIT_COUNT 50
> -#define MAX_RESET_WAIT_CNT     20
> +#define MAX_RESET_WAIT_CNT     100
> 
>  #define I40EVF_ALARM_INTERVAL 50000 /* us */
> 
> --
> 2.30.1.windows.1

Re: [dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[Xing, Beilei]

> -----Original Message-----
> From: Qiming Chen <chenqiming_huawei@163.com>
> Sent: Monday, September 6, 2021 3:14 PM
> To: stable@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> <chenqiming_huawei@163.com>
> Subject: [PATCH 20.11] net/i40e: extend the polling times of vf reset
Besides, the title should be net/i40evf: xxxx
This comment is for all you fix patches for i40evf.

> 
> In the embedded RTOS environment, the x722 controller Ethernet card of the
> d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but
> i40evf_check_vf_reset_done will probably fail.
> 
> This issue has been discussed with intel&dpdk experts for 3 rounds before,
> and the version matching is no problem, and there is no substantial progress.
> The official website contacted external experts, but there was no response
> afterwards. Learning from the implementation of the i40evf kernel driver
> locally, after modifying the polling time from 1 second to 5s, the repeated
> restart process took over the start port test, and it was found that this
> probability was reduced to an order of magnitude acceptable to the user.
> 
> The patch cannot fundamentally solve the failure problem, but it greatly
> slows down the probability of the problem. The modification is based on the
> i40evf kernel driver.
> 
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f64db72e9a..924da8dfb4 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -42,7 +42,7 @@
>  /* busy wait delay in msec */
>  #define I40EVF_BUSY_WAIT_DELAY 10
>  #define I40EVF_BUSY_WAIT_COUNT 50
> -#define MAX_RESET_WAIT_CNT     20
> +#define MAX_RESET_WAIT_CNT     100
> 
>  #define I40EVF_ALARM_INTERVAL 50000 /* us */
> 
> --
> 2.30.1.windows.1

Re: [dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[Xueming(Steven) Li]

On Wed, 2021-09-08 at 03:15 +0000, Xing, Beilei wrote:
> 
> > -----Original Message-----
> > From: Qiming Chen <chenqiming_huawei@163.com>
> > Sent: Monday, September 6, 2021 3:14 PM
> > To: stable@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> > <chenqiming_huawei@163.com>
> > Subject: [PATCH 20.11] net/i40e: extend the polling times of vf reset
> > 
> > In the embedded RTOS environment, the x722 controller Ethernet card of the
> > d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but
> > i40evf_check_vf_reset_done will probably fail.
> > 
> > This issue has been discussed with intel&dpdk experts for 3 rounds before,
> > and the version matching is no problem, and there is no substantial progress.
> > The official website contacted external experts, but there was no response
> > afterwards. Learning from the implementation of the i40evf kernel driver
> > locally, after modifying the polling time from 1 second to 5s, the repeated
> > restart process took over the start port test, and it was found that this
> > probability was reduced to an order of magnitude acceptable to the user.
> 
> This detail segment of communication between PAEs can be removed.
> 
> > 
> > The patch cannot fundamentally solve the failure problem, but it greatly
> > slows down the probability of the problem. The modification is based on the
> > i40evf kernel driver.
> > 
> > Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
> 
> I think the fix commit id is 4861cde4611601ccc9d467675f9d7a10c3095b54 (i40e: new poll mode driver)
> 
> 
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index f64db72e9a..924da8dfb4 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -42,7 +42,7 @@
> >  /* busy wait delay in msec */
> >  #define I40EVF_BUSY_WAIT_DELAY 10
> >  #define I40EVF_BUSY_WAIT_COUNT 50
> > -#define MAX_RESET_WAIT_CNT     20
> > +#define MAX_RESET_WAIT_CNT     100
> > 
> >  #define I40EVF_ALARM_INTERVAL 50000 /* us */
> > 
> > --
> > 2.30.1.windows.1
> 

Same for this patch, please update and send v2, thanks!

Re: [dpdk-stable] [PATCH 20.11] net/i40e: extend the polling times of vf reset

[Xueming(Steven) Li]

On Mon, 2021-11-08 at 11:49 +0000, Xueming(Steven) Li wrote:
> On Wed, 2021-09-08 at 03:15 +0000, Xing, Beilei wrote:
> > 
> > > -----Original Message-----
> > > From: Qiming Chen <chenqiming_huawei@163.com>
> > > Sent: Monday, September 6, 2021 3:14 PM
> > > To: stable@dpdk.org
> > > Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> > > <chenqiming_huawei@163.com>
> > > Subject: [PATCH 20.11] net/i40e: extend the polling times of vf reset
> > > 
> > > In the embedded RTOS environment, the x722 controller Ethernet card of the
> > > d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but
> > > i40evf_check_vf_reset_done will probably fail.
> > > 
> > > This issue has been discussed with intel&dpdk experts for 3 rounds before,
> > > and the version matching is no problem, and there is no substantial progress.
> > > The official website contacted external experts, but there was no response
> > > afterwards. Learning from the implementation of the i40evf kernel driver
> > > locally, after modifying the polling time from 1 second to 5s, the repeated
> > > restart process took over the start port test, and it was found that this
> > > probability was reduced to an order of magnitude acceptable to the user.
> > 
> > This detail segment of communication between PAEs can be removed.
> > 
> > > 
> > > The patch cannot fundamentally solve the failure problem, but it greatly
> > > slows down the probability of the problem. The modification is based on the
> > > i40evf kernel driver.
> > > 
> > > Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
> > 
> > I think the fix commit id is 4861cde4611601ccc9d467675f9d7a10c3095b54 (i40e: new poll mode driver)
> > 
> > 
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> > > ---
> > >  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > > b/drivers/net/i40e/i40e_ethdev_vf.c
> > > index f64db72e9a..924da8dfb4 100644
> > > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > > @@ -42,7 +42,7 @@
> > >  /* busy wait delay in msec */
> > >  #define I40EVF_BUSY_WAIT_DELAY 10
> > >  #define I40EVF_BUSY_WAIT_COUNT 50
> > > -#define MAX_RESET_WAIT_CNT     20
> > > +#define MAX_RESET_WAIT_CNT     100
> > > 
> > >  #define I40EVF_ALARM_INTERVAL 50000 /* us */
> > > 
> > > --
> > > 2.30.1.windows.1
> > 
> 
> Same for this patch, please update and send v2, thanks!

Found another patch with same subject, assuming it v2 and applied.
thanks!