patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: stable@dpdk.org, Luca Boccassi <bluca@debian.org>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [dpdk-stable] [PATCH] 5-make-release-commit: tolerate longer versions
Date: Mon,  6 Sep 2021 12:29:44 +0200	[thread overview]
Message-ID: <20210906102944.692177-1-christian.ehrhardt@canonical.com> (raw)

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Without this we have tool warnings and ugly headers like
  19.11.10 Foo
  -----------

The static underlines need to adapt to the length of the string.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 5-make-release-commit | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/5-make-release-commit b/5-make-release-commit
index 832e8e4..374154f 100755
--- a/5-make-release-commit
+++ b/5-make-release-commit
@@ -21,41 +21,42 @@ change_version()
 	fi
 }
 
-update_release_note()
+function rstheader()
 {
-	{
+	msg=${1}
+	rchar=${2}
+	n=0;
 
 	echo
-	echo "$stable_release Release Notes"
-	echo "---------------------"
-
+	echo "${msg}"
+	printf "${rchar}%.0s" $(seq 1 ${#msg})
+	# break after line plus one empty line
 	echo
-	echo "$stable_release Fixes"
-	echo "~~~~~~~~~~~~~"
 	echo
+}
+
+
+update_release_note()
+{
+	{
+
+	rstheader "$stable_release Release Notes" "-"
+
+	rstheader "$stable_release Fixes" "~"
 
 	$GIT log --oneline v${last_release}..HEAD | cut -d ' ' -f 2-  | sort | sed 's/^/* /'
 
-        echo
-        echo "$stable_release Validation"
-        echo "~~~~~~~~~~~~~~~~~~"
-        echo
+	rstheader "$stable_release Validation" "~"
 
 	echo "$(cat $stable_release/validation)"
 
 	if [ -e $stable_release/known_issues ]; then
-		echo
-		echo "$stable_release Known Issues"
-		echo "~~~~~~~~~~~~~~~~~~~~"
-		echo
+		rstheader "$stable_release Known Issues" "~"
 		echo "$(cat $stable_release/known_issues)"
 	fi
 
 	if [ -e $stable_release/failed_list ]; then
-		echo
-		echo "$stable_release Fixes skipped and status unresolved"
-		echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
-		echo
+		rstheader "$stable_release Fixes skipped and status unresolved" "~"
 		echo "$(cat $stable_release/failed_list)"
 	fi
 
-- 
2.32.0


             reply	other threads:[~2021-09-06 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 10:29 christian.ehrhardt [this message]
2021-09-06 10:34 ` Luca Boccassi
2021-09-06 10:41   ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210906102944.692177-1-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=bluca@debian.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).