From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D79AA0C4D for ; Thu, 7 Oct 2021 05:24:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 928DD411A2; Thu, 7 Oct 2021 05:24:02 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 993414114B for ; Thu, 7 Oct 2021 05:24:00 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id k23so3780941pji.0 for ; Wed, 06 Oct 2021 20:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=P5cHOJhPZpkmf934mK0EhQ/tsiv9b0orseSA4FGZsKg=; b=NuzMpmn2n78UMaRd8/io3voFwQJwuxb4PgdhRWSlehEZ97KLxDppp5mzz+YnZY/WS/ 26lg5OwLaGbwrPtOYrhyikgOHjFyv3osou8Pp3EtXmqZv6EnqzEElW//Mjkh29/FUrmk qZvaP/HjZXIwfRlq1ofvzgE9GBGLZ6RMRe49Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=P5cHOJhPZpkmf934mK0EhQ/tsiv9b0orseSA4FGZsKg=; b=bQa8X9KlBMPak+qAQPipLJ++N1GAHJ2x2nclJ/QVKioB/GkoxvNNml05RHnqR5tUr0 Sobi8JyzLDs8FEcqLHXc/FrmLVOg9vjYLYB819M6e05FqK04E8JR56JG9S6Rx4AZvV6Z oUz6vVH1eiDuUgCcNHETk8d8wnOn4jOzr8P6q3j1IPpJEDZ0MZL26xayPK8pxq8dIwVg 2Lc8J+oQl5Yzo4b/uyc4Ojq00sfdafG8SQm9NLVPwt1b9jdB6FRL9tjLu4KG3ggXlKHJ LgUaF1jjNXuakjCnvk6F9GXJKAqX3fu8m8nv939JRAAF7+cOUwCgDLMB0FwxCDn/yusW Wg2Q== X-Gm-Message-State: AOAM532lxPpr+HPQbFxmjYToU/fZZBqNtPjlwJnpmbDZ/nEHIai//8s7 VN8dRe4RI/exw3RhiiIRJlDdzw== X-Google-Smtp-Source: ABdhPJwJG3lUQuA7gb7ouVJ3RGPuEURrmKQIvQNo/uXm8+fzeKk45as2a/iyv5hk7FYpgFd/o1qzXw== X-Received: by 2002:a17:90a:62ca:: with SMTP id k10mr2081148pjs.38.1633577039663; Wed, 06 Oct 2021 20:23:59 -0700 (PDT) Received: from localhost.localdomain ([2600:8802:3300:145:493f:a3ef:de16:5144]) by smtp.gmail.com with ESMTPSA id y15sm16807320pfa.64.2021.10.06.20.23.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 20:23:59 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org, Lance Richardson Date: Wed, 6 Oct 2021 20:23:52 -0700 Message-Id: <20211007032353.93579-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211007032353.93579-1-ajit.khaparde@broadcom.com> References: <20211007032353.93579-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000308a6f05cdbacb6d" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --000000000000308a6f05cdbacb6d Content-Transfer-Encoding: 8bit Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, -- 2.30.1 (Apple Git-130) --000000000000308a6f05cdbacb6d--