From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4237DA034F
for <public@inbox.dpdk.org>; Sat, 9 Oct 2021 03:55:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9A82040F35;
Sat, 9 Oct 2021 03:55:00 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by mails.dpdk.org (Postfix) with ESMTP id E24B740685;
Sat, 9 Oct 2021 03:54:58 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="213571646"
X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="213571646"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Oct 2021 18:54:58 -0700
X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="624917151"
Received: from unknown (HELO intel-npg-odc-srv03.cd.intel.com)
([10.240.178.145])
by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Oct 2021 18:54:53 -0700
From: Robin Zhang <robinx.zhang@intel.com>
To: dev@dpdk.org
Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, helin.zhang@intel.com,
jingjing.wu@intel.com, remy.horton@intel.com, jijiang.liu@intel.com,
jing.d.chen@intel.com, cunming.liang@intel.com, wenzhuo.lu@intel.com,
junfeng.guo@intel.com, stevex.yang@intel.com,
Robin Zhang <robinx.zhang@intel.com>, stable@dpdk.org,
Christopher Pau <christopher.pau@intel.com>
Date: Sat, 9 Oct 2021 01:39:50 +0000
Message-Id: <20211009013956.70937-12-robinx.zhang@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211009013956.70937-1-robinx.zhang@intel.com>
References: <20210618063851.3694702-1-robinx.zhang@intel.com>
<20211009013956.70937-1-robinx.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH v6 11/17] net/i40e/base: fix potentially
uninitialized variables
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
The status of i40e_read_nvm_word is not checked, so variables set
from this function could be used uninitialized. In this case, preserve
the existing flow that does not block initialization by initializing
these values from the start.
Fixes: 8d6c51fcd24b ("i40e/base: get OEM version")
Fixes: 2db70574247b ("net/i40e/base: limit PF/VF specific code to that driver only")
Cc: stable@dpdk.org
Signed-off-by: Christopher Pau <christopher.pau@intel.com>
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
drivers/net/i40e/base/i40e_adminq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c
index 38d3429e5b..27c82d9b44 100644
--- a/drivers/net/i40e/base/i40e_adminq.c
+++ b/drivers/net/i40e/base/i40e_adminq.c
@@ -652,8 +652,10 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw *hw)
{
struct i40e_adminq_info *aq = &hw->aq;
enum i40e_status_code ret_code;
- u16 cfg_ptr, oem_hi, oem_lo;
- u16 eetrack_lo, eetrack_hi;
+ u16 oem_hi = 0, oem_lo = 0;
+ u16 eetrack_hi = 0;
+ u16 eetrack_lo = 0;
+ u16 cfg_ptr = 0;
int retry = 0;
/* verify input for valid configuration */
--
2.25.1