From: Harneet Singh <harneet.singh@intel.com>
To: dev@dpdk.org
Cc: Harneet Singh <harneet.singh@intel.com>,
stable@dpdk.org, David Hunt <david.hunt@intel.com>
Subject: [dpdk-stable] [PATCH] examples/l3fwd-power: fix ctrl+c issue
Date: Fri, 29 Oct 2021 14:05:56 +0000 [thread overview]
Message-ID: <20211029140556.1913267-1-harneet.singh@intel.com> (raw)
Currently, EAL init cannot be interrupted with SIGINT because the
signal handler is already overridden by the time EAL init happens.
Fix it by moving signal handler installation to after EAL
initialization, to allow SIGNIT to interrupt EAL initialization.
Fixes: d7937e2e3d12 ("power: initial import")
Cc: stable@dpdk.org
Signed-off-by: Harneet Singh <harneet.singh@intel.com>
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 21c79567b1..002ba011c3 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2532,9 +2532,6 @@ main(int argc, char **argv)
uint16_t portid;
const char *ptr_strings[NUM_TELSTATS];
- /* catch SIGINT and restore cpufreq governor to ondemand */
- signal(SIGINT, signal_exit_now);
-
/* init EAL */
ret = rte_eal_init(argc, argv);
if (ret < 0)
@@ -2542,6 +2539,9 @@ main(int argc, char **argv)
argc -= ret;
argv += ret;
+ /* catch SIGINT and restore cpufreq governor to ondemand */
+ signal(SIGINT, signal_exit_now);
+
/* init RTE timer library to be used late */
rte_timer_subsystem_init();
--
2.25.1
next reply other threads:[~2021-10-29 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 14:05 Harneet Singh [this message]
2021-10-29 15:50 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2021-11-16 14:24 ` David Marchand
-- strict thread matches above, loose matches on Subject: below --
2021-10-29 13:42 [dpdk-stable] " Harneet Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029140556.1913267-1-harneet.singh@intel.com \
--to=harneet.singh@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).