From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A572CA034F for ; Wed, 10 Nov 2021 07:47:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9ED0440142; Wed, 10 Nov 2021 07:47:09 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) by mails.dpdk.org (Postfix) with ESMTP id 70DA840142 for ; Wed, 10 Nov 2021 07:47:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPtOl4BYBObEO9LRfNzoalNU68a0O+kPrR9bxRP1SQo5RrRpxoZCE2BJdszeAzVtukVsVU9PrEwhdRmwqqRxR2vYubtuxfE858G6mJKllVCR//wyOfU5rcChj6yCQ8tDkI58LxZiilVorSNPcRnaDmgXIAdgdB7F8dSYLbVI1rH6UGnPSC5lCHvA2TMbnw9XgTJtUOvL2wg3J/Scogom3ISeozybqyAuTYyLmWDIj/M2PXRTdXH/UHl/f7cLGpU5PksvMpzJLWot46k3crHnPxI64JhbbFmlMKUBWNEu4lCO2FURId1i/BzLQXCqpELq7nU9Nxwt7QwjR8aLumR/0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0LIoFLmSI2hp70e2vxduH4hDF6yiL9rebu1l6Y+ktJk=; b=LgBdwJVxDeekPcXYRGo66GuMLWSuaxhdSIzumT1vHNiwftlemn1wvGgLVyxSPjbWrk849ulzmMggOGYWbBzFhlqejIZ+uaEqMgtbATGaEjzN+LzvKeeG2gqTRt+EeqAlcecG3e7zX3gKQS+XwysbZWOp0RjyO8680A920DO93cg42fNTrKn+oEMI50E6pMbS7oqxciOwBWvglg39y/qlD4azNZVGnIBEQizyA2wpYfpuHZd04wnZUVgWuCObHpdKOwc+OXqcTrfCxkD2/87fPZlaN7m0liSGu/xPYbupWdR7nk3zg+ZVkBCUAVZ6NR5Xqk90lZfBK2MUimRK5uE/yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LIoFLmSI2hp70e2vxduH4hDF6yiL9rebu1l6Y+ktJk=; b=jet6kiCnMWuhWstYNweO39zf6ytrq8zaTaKtn6IOWbiKY/7y9ysVw8Ci4kgTi/h8cXvfiNvzcQzvfgwuKUeF2vj5dIyYTcK6P8EgS+gZssUhIcuBPpqNZ+EdkoiJ7/BOuTpvnPH2IdXGdcwMvxYiJl0/CFgXZitnvSWiHq1PZeEFRQ7QpqeJEOTC4RZEI8PSaXm3d6C7cpVzEKPaRP7fwz9nd6zGtpiH1sJYp49W7vrpyHgqiBgnP8B8ZFv5OBpElPSwuCaQUN6vvT28tEmj/SWQvj9qJBUo8UWgsl3HHy+zub3aoqU2u5ZsjCIq3wRoj7UPwG4I0Ht64SR/clbpUg== Received: from BN8PR07CA0004.namprd07.prod.outlook.com (2603:10b6:408:ac::17) by CH0PR12MB5171.namprd12.prod.outlook.com (2603:10b6:610:ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 10 Nov 2021 06:47:06 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::6) by BN8PR07CA0004.outlook.office365.com (2603:10b6:408:ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Wed, 10 Nov 2021 06:47:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:47:05 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:47:03 +0000 From: Xueming Li To: Gagandeep Singh CC: Luca Boccassi , Konstantin Ananyev , Akhil Goyal , dpdk stable Date: Wed, 10 Nov 2021 14:30:14 +0800 Message-ID: <20211110063216.2744012-131-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 055c99cf-26d9-489e-6a4f-08d9a415e900 X-MS-TrafficTypeDiagnostic: CH0PR12MB5171: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fLVhIED0WN8NDR0wAoy1l43MVHwxkbfgpja4Jua/HUCSFvBZ9WAcifgUDODNZSQ4vtyCKRAEsJ63+4Y55UMdMGNsZ5bR9IXl3fZnDRvBu9d+O6jfeUK6sRmKb4fFvROwht1KtkrlnLxHT9M/TCLNFzdQz/ACrZy0oS7LKJOvszEiFp0hU4ZQOYX9ZMLY2xBA9VP8HBh5TToREeV78yxG669Y76n8+FpZCrm5fEPz1z163wcGDlfieuQ/nHZ+NGuDpFHqYGBFYVQrhKEyQTH7OhQHZz03s1E5AdqjD71Epps8P3JKctG6VTnL7QCW5EJHN7Ax95iUO3agHENi94TWefYxPaqnlcqaB0bpu768aKRvHfSRfkBz5Kk99GDtbo8ssvKOgP6Az/ui3O93Fz235a7iDoJTiaA+gQsIeBNM0JegOg0BE8W/JX4j6egNranEpGULaWTCGEwB5aDwHfcYy0PEnViV2oTpkexMKjCZM2kpOMmYi89LaUDDvg74wyZKTc7bdXwAAGjsnK+cBNRRd+M2VRuRdIAcD8lbJ3yfIIEvaofj2Q+r0DKvFCo8ZItG/ozxeHqByidh8M53wKq9A+DTd5TQUBrb+ojkR9V4dj4/RpMD8FAxWz91UlrNpVvWexAPzGJgRnU+eBpoIZ+e0sJX/bl95oXYsRIhMgXT8IqAwJK5sujLbpZ9uRy1jMvmx9jRHUAIXWf6jfav4UKpVfvXYlCPdeNpw84yTKeJi2UmktEGHkdWY5kZ6Jrapy62To5XmbBcuE8tRSKFR8diOu7+MxFZevF5L128uzP5muWXMQm/UQkfZvP4zJrjrT4JZxZlxqg+iwYRoBWXV+5sCg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(6916009)(82310400003)(316002)(86362001)(5660300002)(4001150100001)(54906003)(36906005)(36860700001)(36756003)(7636003)(356005)(70586007)(26005)(2906002)(6286002)(16526019)(186003)(8676002)(6666004)(4326008)(83380400001)(7696005)(70206006)(1076003)(55016002)(47076005)(966005)(53546011)(8936002)(426003)(508600001)(336012)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:47:05.8353 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 055c99cf-26d9-489e-6a4f-08d9a415e900 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5171 Subject: [dpdk-stable] patch 'cryptodev: fix multi-segment raw vector processing' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/3d67f2c1c3f1ea58d87fcccdb673f045d4f67082 Thanks. Xueming Li --- >From 3d67f2c1c3f1ea58d87fcccdb673f045d4f67082 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Thu, 14 Oct 2021 00:30:21 +0530 Subject: [PATCH] cryptodev: fix multi-segment raw vector processing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 8edcb68fd01b6a1e47549be389335cfef042ea05 ] If no next segment available the “for” loop will fail and it still returns i+1 i.e. 2, which is wrong as it has filled only 1 buffer. Fixes: 7adf992fb9bf ("cryptodev: introduce CPU crypto API") Signed-off-by: Gagandeep Singh Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_cryptodev/rte_crypto_sym.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index 9d572ec057..406c5c7a5c 100644 --- a/lib/librte_cryptodev/rte_crypto_sym.h +++ b/lib/librte_cryptodev/rte_crypto_sym.h @@ -963,6 +963,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, /* whole requested data is completed */ vec[i].len = left; left = 0; + i++; break; } @@ -972,7 +973,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, } RTE_ASSERT(left == 0); - return i + 1; + return i; } -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:07.723070176 +0800 +++ 0130-cryptodev-fix-multi-segment-raw-vector-processing.patch 2021-11-10 14:17:01.890745927 +0800 @@ -1 +1 @@ -From 8edcb68fd01b6a1e47549be389335cfef042ea05 Mon Sep 17 00:00:00 2001 +From 3d67f2c1c3f1ea58d87fcccdb673f045d4f67082 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 8edcb68fd01b6a1e47549be389335cfef042ea05 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ - lib/cryptodev/rte_crypto_sym.h | 3 ++- + lib/librte_cryptodev/rte_crypto_sym.h | 3 ++- @@ -22,5 +24,5 @@ -diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h -index c907b1646d..daa090b978 100644 ---- a/lib/cryptodev/rte_crypto_sym.h -+++ b/lib/cryptodev/rte_crypto_sym.h -@@ -990,6 +990,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, +diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h +index 9d572ec057..406c5c7a5c 100644 +--- a/lib/librte_cryptodev/rte_crypto_sym.h ++++ b/lib/librte_cryptodev/rte_crypto_sym.h +@@ -963,6 +963,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, @@ -34 +36 @@ -@@ -999,7 +1000,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, +@@ -972,7 +973,7 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len,