patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Liu <kevinx.liu@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, qi.z.zhang@intel.com,
	stevex.yang@intel.com, ferruh.yigit@intel.com,
	Kevin Liu <kevinx.liu@intel.com>,
	stable@dpdk.org
Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments
Date: Wed, 29 Dec 2021 09:37:02 +0000	[thread overview]
Message-ID: <20211229093702.1930214-3-kevinx.liu@intel.com> (raw)
In-Reply-To: <20211229093702.1930214-1-kevinx.liu@intel.com>

Testpmd forwards packets in checksum mode that it needs to calculate
the checksum of each layer's protocol.

In process_inner_cksums, when parsing tunnel packets, inner L4 offset should be
outer_l2_len + outer_l3_len + l2_len + l3_len.

In process_outer_cksums, when parsing tunnel packets, outer L4 offset should be
outer_l2_len + outer_l3_len.

Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi-segments")
Cc: stable@dpdk.org

Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
 app/test-pmd/csumonly.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 02bc3929c7..c235456e58 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -513,7 +513,7 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,
 				ol_flags |= RTE_MBUF_F_TX_UDP_CKSUM;
 			} else {
 				if (info->is_tunnel)
-					l4_off = info->l2_len +
+					l4_off = info->outer_l2_len +
 						 info->outer_l3_len +
 						 info->l2_len + info->l3_len;
 				else
@@ -536,7 +536,7 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,
 			ol_flags |= RTE_MBUF_F_TX_TCP_CKSUM;
 		} else {
 			if (info->is_tunnel)
-				l4_off = info->l2_len + info->outer_l3_len +
+				l4_off = info->outer_l2_len + info->outer_l3_len +
 					 info->l2_len + info->l3_len;
 			else
 				l4_off = info->l2_len + info->l3_len;
@@ -625,7 +625,7 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info,
 	if (udp_hdr->dgram_cksum != 0) {
 		udp_hdr->dgram_cksum = 0;
 		udp_hdr->dgram_cksum = get_udptcp_checksum(m, outer_l3_hdr,
-					info->l2_len + info->outer_l3_len,
+					info->outer_l2_len + info->outer_l3_len,
 					info->outer_ethertype);
 	}
 
-- 
2.33.1


  parent reply	other threads:[~2022-02-28  3:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-24 15:09 [PATCH] net/ice: fix Tx offload path choice Kevin Liu
     [not found] ` <20211229093702.1930214-1-kevinx.liu@intel.com>
2021-12-29  9:37   ` [PATCH v2 1/2] " Kevin Liu
2022-03-04  3:19     ` Xu, Ting
2022-03-04  3:31       ` Zhang, Qi Z
2022-03-04 11:52         ` Ferruh Yigit
2021-12-29  9:37   ` Kevin Liu [this message]
     [not found]     ` <d2d97e6cf1a14faaa47b61b63ed55573@intel.com>
2022-03-03  6:29       ` [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Zhang, Yuying
2022-03-11  7:04         ` Liu, KevinX
2022-03-11  8:02           ` Singh, Aman Deep
2022-03-11  8:12             ` Liu, KevinX
2022-03-11  9:04               ` Singh, Aman Deep
2022-03-11 10:46           ` Ferruh Yigit
2022-03-14  2:33             ` Zhang, Qi Z
2022-03-14 20:21               ` Thomas Monjalon
2022-02-24  2:32 ` [PATCH] net/ice: fix Tx offload path choice Ling, WeiX
2022-02-27  6:19 ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211229093702.1930214-3-kevinx.liu@intel.com \
    --to=kevinx.liu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=stevex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).