From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CE6A034C for ; Fri, 25 Feb 2022 18:16:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93C7F410FD; Fri, 25 Feb 2022 18:16:22 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 70DEB410FD for ; Fri, 25 Feb 2022 18:16:21 +0100 (CET) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 475A73FCAD for ; Fri, 25 Feb 2022 17:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645809381; bh=RVCI/do3Ln6/6EtRTdP3t1krSss/T6AFfzGKnxKMunA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kt3j2ke/EtqBsz7EEsLStCC0b06XtsrewJAM1tBOga0R2BWHGBgObhNDQa+i12tSd OKvVu5HstY2+sV8wd4mKYBTXMxxyQfFRvX7BRYnM8n8pRYprJeBXGMZQOlAdICjxIL Bo7CzEVYhSramjvp3lG7K6HYRUqdpwBGRGa/DQPgR2E+2SNx2nFTnJMivvzUmWCvka WErxBwORyjWLiQZsYiIiOxKdZJHpumAgx3AGvY/PBcd4PMigrjpbJE9djoVu1ydv9H UixlfxhkiuFF7ibslqykgfBWQ+wJlVnHwjGLQhiK6u+CP9tKjJ5aPZ2FqNUnhceLCI ZPgdI/KPC7ZFw== Received: by mail-wr1-f71.google.com with SMTP id y8-20020adfc7c8000000b001e755c08b91so1093848wrg.15 for ; Fri, 25 Feb 2022 09:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RVCI/do3Ln6/6EtRTdP3t1krSss/T6AFfzGKnxKMunA=; b=UX3ZJEUGjQa/0iAv6aspjwJ5F/hJqGOujKIIyMGgUprI4nX7uzzzt/Y3R5LIF8S+Wr SLkocGNZa4rYcfq4igbkEZxZFkV1R6Tl3CZstbqjuamg+c3vEoapoyskW/k8LMcMIzxp IEQrkSJzjkbcdydLeIjNHR7GqJPVEjrR9XFgML7m1tqVrEo/5lQYCoAgW5y0YQBbWQF9 /NA8xNVItv4EpDILcOQSPhUmYK3V/7h7Iz3qKnO2i6GMjnhHgdv94V/AhfrGPQzE+GFv W3Jos/Z+fjrRD1wsY5KcCa9tYxg7y2u5HexL1siC87H8HRrrByBYDAB6uxFs/WdQclMG fkig== X-Gm-Message-State: AOAM530QHJaV09JfaVxrLMGTl+H6okX7vbGFDmCObUjzMKa8FmT3Jxx9 Dwo2W6FTbZTOMJh0c/8wPAcH7/LKUzaSGmyz0l6YsEZqJp/8uTqypkbLnPnnBv0maYIV7+UQj3L QmjUom/hcbknVw6bN7r2VSUPp X-Received: by 2002:adf:bbcd:0:b0:1ed:b9a6:c66d with SMTP id z13-20020adfbbcd000000b001edb9a6c66dmr6897491wrg.455.1645809375728; Fri, 25 Feb 2022 09:16:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJygBOgJ7XothKrB1XaWGlS9dPNPZXj6Ki8v3S68uFOlxTcpda32JlAd5Kkci5mlj871EduoXQ== X-Received: by 2002:adf:bbcd:0:b0:1ed:b9a6:c66d with SMTP id z13-20020adfbbcd000000b001edb9a6c66dmr6897477wrg.455.1645809375503; Fri, 25 Feb 2022 09:16:15 -0800 (PST) Received: from Keschdeichel.fritz.box (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id s3-20020a5d4ec3000000b001ea95eba44dsm2625340wrv.109.2022.02.25.09.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:16:15 -0800 (PST) From: christian.ehrhardt@canonical.com To: Stephen Hemminger Cc: Bruce Richardson , dpdk stable Subject: patch 'eal/linux: log hugepage create errors with filename' has been queued to stable release 19.11.12 Date: Fri, 25 Feb 2022 18:15:02 +0100 Message-Id: <20220225171550.3499040-9-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> References: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/1e884c7a6834429cf7a177a9d31f2dfd44d582b7 Thanks. Christian Ehrhardt --- >From 1e884c7a6834429cf7a177a9d31f2dfd44d582b7 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 23 Dec 2021 11:21:58 -0800 Subject: [PATCH] eal/linux: log hugepage create errors with filename [ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] While debugging running DPDK service in a container, it is useful to see which file creation failed. Don't hide this failure with DEBUG. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/librte_eal/linux/eal/eal_memalloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c index 9f2d3e113c..7499ba0b15 100644 --- a/lib/librte_eal/linux/eal/eal_memalloc.c +++ b/lib/librte_eal/linux/eal/eal_memalloc.c @@ -304,8 +304,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, if (fd < 0) { fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(ERR, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } /* take out a read lock and keep it indefinitely */ @@ -342,8 +342,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } /* take out a read lock */ -- 2.35.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-25 16:58:44.646388076 +0100 +++ 0009-eal-linux-log-hugepage-create-errors-with-filename.patch 2022-02-25 16:58:44.196990375 +0100 @@ -1 +1 @@ -From 8a5a91401dc23ddab1ddea3667a17a615a25077f Mon Sep 17 00:00:00 2001 +From 1e884c7a6834429cf7a177a9d31f2dfd44d582b7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] + @@ -10,2 +11,0 @@ -Cc: stable@dpdk.org - @@ -15 +15 @@ - lib/eal/linux/eal_memalloc.c | 8 ++++---- + lib/librte_eal/linux/eal/eal_memalloc.c | 8 ++++---- @@ -18,5 +18,5 @@ -diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c -index 337f2bc739..16b58d861b 100644 ---- a/lib/eal/linux/eal_memalloc.c -+++ b/lib/eal/linux/eal_memalloc.c -@@ -308,8 +308,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, +diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c +index 9f2d3e113c..7499ba0b15 100644 +--- a/lib/librte_eal/linux/eal/eal_memalloc.c ++++ b/lib/librte_eal/linux/eal/eal_memalloc.c +@@ -304,8 +304,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, @@ -33 +33 @@ -@@ -346,8 +346,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, +@@ -342,8 +342,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi,