From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D4BBA034F for ; Tue, 1 Mar 2022 11:45:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78CF9426E1; Tue, 1 Mar 2022 11:45:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 993A1426EE for ; Tue, 1 Mar 2022 11:45:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ff9smiA2Z76F8tdP/vJWGSBHcBrT81JnVGFyrtGD59M=; b=NGvJEMGv0h6OFQpoCP+HBI+MsA/iH0Hsp3OFH6i1t+6sU/9BAXeUMdS6fP07SCDIvXBY7x GWwsrSITlDXTqMrJwZTd/i3PHhZYtlpp4mbNkYPCfmp5GjFEp9lZGokn08AkgdbSe3tPLt nl9cYgbwH/MwjfJQVdnRfaGKa1+XvC4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-5VZcusZ5NyK-NI3fWGXpwg-1; Tue, 01 Mar 2022 05:45:44 -0500 X-MC-Unique: 5VZcusZ5NyK-NI3fWGXpwg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E6B751DC; Tue, 1 Mar 2022 10:45:43 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56C13752C7; Tue, 1 Mar 2022 10:45:42 +0000 (UTC) From: Kevin Traynor To: Michal Krawczyk Cc: dpdk stable Subject: patch 'net/ena: fix checksum flag for L4' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:34 +0000 Message-Id: <20220301104300.334382-78-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/dd246a2e8f2b6f043999c1b8336a1bbc7ef996f5 Thanks. Kevin --- >From dd246a2e8f2b6f043999c1b8336a1bbc7ef996f5 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:43 +0100 Subject: [PATCH] net/ena: fix checksum flag for L4 [ upstream commit b2d2f1cf89a6c3661e68b750364e4a7018f954ba ] Some HW may invalidly set checksum error bit for the valid L4 checksum. To avoid drop of the packets in that situation, do not indicate bad checksum for L4 Rx csum offloads. Instead, set it as unknown, so the application will re-verify this value. The statistics counters will still work as previously. Fixes: 05817057faba ("net/ena: fix indication of bad L4 Rx checksums") Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 80fcaf300a..770b101688 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -311,5 +311,11 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, else if (unlikely(ena_rx_ctx->l4_csum_err)) - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + /* + * For the L4 Rx checksum offload the HW may indicate + * bad checksum although it's valid. Because of that, + * we're setting the UNKNOWN flag to let the app + * re-verify the checksum. + */ + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; else ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:03.560437171 +0000 +++ 0078-net-ena-fix-checksum-flag-for-L4.patch 2022-03-01 10:41:01.400244117 +0000 @@ -1 +1 @@ -From b2d2f1cf89a6c3661e68b750364e4a7018f954ba Mon Sep 17 00:00:00 2001 +From dd246a2e8f2b6f043999c1b8336a1bbc7ef996f5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b2d2f1cf89a6c3661e68b750364e4a7018f954ba ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 151c688eec..4b58dcda74 100644 +index 80fcaf300a..770b101688 100644 @@ -25,3 +26,3 @@ -@@ -584,5 +584,11 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, - if (unlikely(ena_rx_ctx->l4_csum_err)) { - ++rx_stats->l4_csum_bad; +@@ -311,5 +311,11 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, + else + if (unlikely(ena_rx_ctx->l4_csum_err)) @@ -36,2 +37,2 @@ - } else { - ++rx_stats->l4_csum_good; + else + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;