From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDA90A0555 for ; Wed, 25 May 2022 18:29:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8824400EF; Wed, 25 May 2022 18:29:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AFB1D4280C for ; Wed, 25 May 2022 18:29:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hitPcwMBGBkPnB0YPUZRPqvJm+aTtWvJsr7XPBNJFXw=; b=YS1BhI31lupbtXwG52dLdrt/O1RiAu75HMY4bXUHrPkLbTohBdO9jA4d5inUzmzA97kmGm NGEd/dgjY4F/SK0dHjwkFDrSb6AbRYCUyM6dtwV+2YN7wTQypMAQkpfNvlIg/JlCF6wrwE nDvGxV8eIFEwEPkiYkFC1naSy32/Zjs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-36-vJ9PGEraN7yvYPSFTe0RCw-1; Wed, 25 May 2022 12:29:54 -0400 X-MC-Unique: vJ9PGEraN7yvYPSFTe0RCw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4AA2210726A4; Wed, 25 May 2022 16:29:54 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15C9C2026D64; Wed, 25 May 2022 16:29:52 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix RSS action' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:32 +0100 Message-Id: <20220525162847.711753-40-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/821dd9cd433bad28ee71e7656eb5acfe41af7aa4 Thanks. Kevin --- >From 821dd9cd433bad28ee71e7656eb5acfe41af7aa4 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Wed, 27 Apr 2022 20:28:11 +0530 Subject: [PATCH] net/bnxt: fix RSS action [ upstream commit 202a1711a1d318d97ee1d3cb718fc3fcf6ee2dad ] Specifying a subset of Rx queues created by the application in the "flow create" command is invalid. User must either specify all Rx queues created or no queues. Also removed a wrong comment as RSS action will not be supported if user or application specifies MARK or COUNT action. Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index f7c90c442f..11dca5dc7e 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1075,5 +1075,4 @@ bnxt_update_filter_flags_en(struct bnxt_filter_info *filter, } -/* Valid actions supported along with RSS are count and mark. */ static int bnxt_validate_rss_action(const struct rte_flow_action actions[]) @@ -1124,4 +1123,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, rss = (const struct rte_flow_action_rss *)act->conf; + /* must specify either all the Rx queues created by application or zero queues */ + if (rss->queue_num && vnic->rx_queue_cnt != rss->queue_num) { + rte_flow_error_set(error, + EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "Incorrect RXQ count"); + rc = -rte_errno; + goto ret; + } + /* Currently only Toeplitz hash is supported. */ if (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT && -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.523428330 +0100 +++ 0040-net-bnxt-fix-RSS-action.patch 2022-05-25 17:26:58.626828418 +0100 @@ -1 +1 @@ -From 202a1711a1d318d97ee1d3cb718fc3fcf6ee2dad Mon Sep 17 00:00:00 2001 +From 821dd9cd433bad28ee71e7656eb5acfe41af7aa4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 202a1711a1d318d97ee1d3cb718fc3fcf6ee2dad ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 71a8edd830..bd96bbaf4c 100644 +index f7c90c442f..11dca5dc7e 100644