From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D3A6A0555 for ; Wed, 25 May 2022 18:30:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1710E42B81; Wed, 25 May 2022 18:30:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 38D5942B6D for ; Wed, 25 May 2022 18:30:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PDYLBXuKy4tNC7rconmLLsfnG4EkG8xoI4NyrpNJlTU=; b=EEAnIb8aHwSAFDZHeTDb0abY+/xXtbXRJ1fGS7Q3mJ4851hetU8aFi6NOPCMe09x29tv4S Jqh0npgLq4No6ORcoBzpRoMGHpvodEtkUeNBwlRyOSIIjncYZ7c2kheWKuEYRJKt/gRTRt iZGH48ToL31qUZRWxTRJsV9ER8/Xz/Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-445-xpaDF91aP3aPphyqzyHvIw-1; Wed, 25 May 2022 12:30:14 -0400 X-MC-Unique: xpaDF91aP3aPphyqzyHvIw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 430711C01B24; Wed, 25 May 2022 16:30:14 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74A652026D64; Wed, 25 May 2022 16:30:13 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Jay Jayatheerthan , dpdk stable Subject: patch 'eventdev/eth_rx: fix telemetry Rx stats reset' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:44 +0100 Message-Id: <20220525162847.711753-52-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/09d859555f9d1555228ec3494443cba926f09643 Thanks. Kevin --- >From 09d859555f9d1555228ec3494443cba926f09643 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 24 Mar 2022 16:28:30 +0100 Subject: [PATCH] eventdev/eth_rx: fix telemetry Rx stats reset [ upstream commit b450a990b07e008077377a6dfa45a562b3f9a496 ] Caught by covscan: 1. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: logical_vs_bitwise: "~(*__ctype_b_loc()[(int)*params] & 2048 /* (unsigned short)_ISdigit */)" is always 1/true regardless of the values of its operand. This occurs as the logical second operand of "||". 2. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: remediation: Did you intend to use "!" rather than "~"? While isdigit return value should be compared as an int to 0, prefer ! since all of this file uses this convention. Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry") Signed-off-by: David Marchand Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 4b46e9b6c6..2356e2a535 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -3315,5 +3315,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused, uint8_t rx_adapter_id; - if (params == NULL || strlen(params) == 0 || ~isdigit(*params)) + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) return -1; -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.788081205 +0100 +++ 0052-eventdev-eth_rx-fix-telemetry-Rx-stats-reset.patch 2022-05-25 17:26:58.663828472 +0100 @@ -1 +1 @@ -From b450a990b07e008077377a6dfa45a562b3f9a496 Mon Sep 17 00:00:00 2001 +From 09d859555f9d1555228ec3494443cba926f09643 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b450a990b07e008077377a6dfa45a562b3f9a496 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index ff83ce8b67..bf8741d2ea 100644 +index 4b46e9b6c6..2356e2a535 100644 @@ -31 +32 @@ -@@ -3335,5 +3335,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused, +@@ -3315,5 +3315,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused,