From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C09DA0555 for ; Wed, 25 May 2022 18:29:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9722042B6C; Wed, 25 May 2022 18:29:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 18ABA400EF for ; Wed, 25 May 2022 18:29:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ED8QFTcSE0kbzIV2f4/VD5IVYOE1Jr8uxcU4ZXhd3Ig=; b=D+jA/rcOEh0eCgUopNZ9ofAXlMjHhGRpu3XOopfKI1+IhdeWzZpRwMGfR+5EdM1zof40yJ GpomKDl9hAcRlMRVt8TptrudHQ9W+V5Ucsg1E3fD3hxv06+kep0IJ59E+ujS1w+yj3slyk zG7lQiQ4wFYevw1I/wJhcBK5fwGBp1g= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-2kqzPJQFOS-96VOTmTPxAQ-1; Wed, 25 May 2022 12:29:07 -0400 X-MC-Unique: 2kqzPJQFOS-96VOTmTPxAQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30AAD1C05AE3 for ; Wed, 25 May 2022 16:29:07 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53EF92026D64; Wed, 25 May 2022 16:29:06 +0000 (UTC) From: Kevin Traynor To: Maxime Coquelin Cc: David Marchand , dpdk stable Subject: patch 'net/vhost: fix TSO feature default disablement' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:01 +0100 Message-Id: <20220525162847.711753-9-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e3036fbd0a686e19f76ae2aec633508d2e7f7b8f Thanks. Kevin --- >From e3036fbd0a686e19f76ae2aec633508d2e7f7b8f Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Fri, 22 Apr 2022 11:35:43 +0200 Subject: [PATCH] net/vhost: fix TSO feature default disablement [ upstream commit 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 ] By default, TSO feature should be disabled because it requires application's support to be functional as mentioned in the documentation. However, if "tso" devarg was not specified, the feature did not get disabled. This patch fixes this issue, so that TSO is disabled, even if "tso=0" is not passed as devarg. Fixes: e289400669d5 ("net/vhost: support TSO disabling") Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- drivers/net/vhost/rte_eth_vhost.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 8a6595504a..a248a65df4 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1655,9 +1655,9 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) if (ret < 0) goto out_free; + } - if (tso == 0) { - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); - } + if (tso == 0) { + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:58.846963661 +0100 +++ 0009-net-vhost-fix-TSO-feature-default-disablement.patch 2022-05-25 17:26:58.542828295 +0100 @@ -1 +1 @@ -From 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 Mon Sep 17 00:00:00 2001 +From e3036fbd0a686e19f76ae2aec633508d2e7f7b8f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org