From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFB47A0032 for ; Fri, 24 Jun 2022 17:02:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9151400EF; Fri, 24 Jun 2022 17:02:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CBC5D42823 for ; Fri, 24 Jun 2022 17:02:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656082968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Ok8WYdR92SIKT2oR05RKDykQQCNugSW5oukBuI3Hwg=; b=MeCO9u4EQodz9N6XOEOTge+RVK8tb4BL+FuOlOxAu+wBHJjfzY31+d8UOMKWHlAxvONoxJ fmtX2gMEc0H7ljEFeT0xDih2inubOsN7xAaLrWF06aY7do0kunbNy0n7/vbXGq9OUFUehR as9P8jCGO5khEkwRedr9J533JG+uh20= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-232-5BYjGbLBNc-USfnA2tcSzQ-1; Fri, 24 Jun 2022 11:02:47 -0400 X-MC-Unique: 5BYjGbLBNc-USfnA2tcSzQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C5A3081B915; Fri, 24 Jun 2022 15:02:46 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id C103D10725; Fri, 24 Jun 2022 15:02:45 +0000 (UTC) From: Kevin Traynor To: Maxime Coquelin Cc: Chenbo Xia , Aman Singh , dpdk stable Subject: patch 'app/testpmd: revert MAC update in checksum forwarding' has been queued to stable release 21.11.2 Date: Fri, 24 Jun 2022 16:01:44 +0100 Message-Id: <20220624150148.1855580-36-ktraynor@redhat.com> In-Reply-To: <20220624150148.1855580-1-ktraynor@redhat.com> References: <20220624150148.1855580-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/76556a3128281b9d27d4b8fe2ee4fb1383830731 Thanks. Kevin --- >From 76556a3128281b9d27d4b8fe2ee4fb1383830731 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 8 Jun 2022 14:49:41 +0200 Subject: [PATCH] app/testpmd: revert MAC update in checksum forwarding [ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ] This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and destination MAC addresses. Doing so, we can test checksum offloading with real traffic without breaking broadcast packets. Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") Signed-off-by: Maxime Coquelin Acked-by: Chenbo Xia Acked-by: Aman Singh --- app/test-pmd/csumonly.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index aaaec17841..d661e21e02 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -907,8 +907,4 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], - ð_hdr->dst_addr); - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, - ð_hdr->src_addr); parse_ethernet(eth_hdr, &info); l3_hdr = (char *)eth_hdr + info.l2_len; -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-24 15:51:10.004612536 +0100 +++ 0041-app-testpmd-revert-MAC-update-in-checksum-forwarding.patch 2022-06-24 15:51:08.931984243 +0100 @@ -1 +1 @@ -From 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 Mon Sep 17 00:00:00 2001 +From 76556a3128281b9d27d4b8fe2ee4fb1383830731 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 7df201e047..1a3fd9ce8a 100644 +index aaaec17841..d661e21e02 100644 @@ -28 +29 @@ -@@ -917,8 +917,4 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) +@@ -907,8 +907,4 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)