From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22DCDA057F for ; Tue, 28 Jun 2022 17:20:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E24440042; Tue, 28 Jun 2022 17:20:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1F7BC42905 for ; Tue, 28 Jun 2022 17:20:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656429602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ejgVgm0y/6c91MebsuVEPRaO+81eUwGrzuw4gTCRdbk=; b=BbECWyg9PC7ARpjwwfRMcqrScY1bYCANkUO/rii0iv5IhHU4DIqU1bh65kSqs6VJ86U+b+ bVDln33SwWW3rjmBncSInEusRHc17HkpGxUPt70LVZ8wdt7BSr0HWkZlwgzIRe52Api2// w1TzMjpp/fr8ioPfM+E7QekGsSk8eEo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-uBtSkIDbPPGdAYcCE9ua8Q-1; Tue, 28 Jun 2022 11:20:01 -0400 X-MC-Unique: uBtSkIDbPPGdAYcCE9ua8Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADF3719705AA; Tue, 28 Jun 2022 15:20:00 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id B70E21410DD8; Tue, 28 Jun 2022 15:19:59 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix link status capability query from VF' has been queued to stable release 21.11.2 Date: Tue, 28 Jun 2022 16:19:25 +0100 Message-Id: <20220628151938.2278711-13-ktraynor@redhat.com> In-Reply-To: <20220628151938.2278711-1-ktraynor@redhat.com> References: <20220628151938.2278711-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a650bf5cfed955ba68195a875376867f450ae3b3 Thanks. Kevin --- >From a650bf5cfed955ba68195a875376867f450ae3b3 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Sat, 11 Jun 2022 15:42:26 +0800 Subject: [PATCH] net/hns3: fix link status capability query from VF [ upstream commit a8e1bd096fa9a96e3f50c14e92017b7416536038 ] Currently, the VF LSC capability is obtained from PF driver in the interrupt mailbox interrupt thread, it is asynchronous. The VF driver waits for 500ms to get this capability in probe process. The primary process will receive a message and do probe in the interrupt thread context when attach a device in the secondary process. At this case, VF driver never obtains this capability from PF. The root cause is that 'vf->pf_push_lsc_cap' is not updated by the handling mailbox thread until finishing probe. The reason this update wouldn't be done is that the handling mailbox interrupt thread and the probe alarm thread are both in epool thread, and the probe alarm thread is before the mailbox interrupt thread. Fixes: 9bc2289fe5ea ("net/hns3: refactor VF LSC event report") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev_vf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index 7a843fd7d5..0af4dcb324 100644 --- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c @@ -780,4 +780,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw) while (remain_ms > 0) { rte_delay_ms(HNS3_POLL_RESPONE_MS); + /* + * The probe process may perform in interrupt thread context. + * For example, users attach a device in the secondary process. + * At the moment, the handling mailbox task will be blocked. So + * driver has to actively handle the HNS3_MBX_LINK_STAT_CHANGE + * mailbox from PF driver to get this capability. + */ + hns3_dev_handle_mbx_msg(hw); if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) != HNS3_PF_PUSH_LSC_CAP_UNKNOWN) -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-28 16:18:04.338721900 +0100 +++ 0013-net-hns3-fix-link-status-capability-query-from-VF.patch 2022-06-28 16:18:04.022387176 +0100 @@ -1 +1 @@ -From a8e1bd096fa9a96e3f50c14e92017b7416536038 Mon Sep 17 00:00:00 2001 +From a650bf5cfed955ba68195a875376867f450ae3b3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a8e1bd096fa9a96e3f50c14e92017b7416536038 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index bebfaa6417..3abd4aafcb 100644 +index 7a843fd7d5..0af4dcb324 100644 @@ -35 +36 @@ -@@ -778,4 +778,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw) +@@ -780,4 +780,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)