From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A4C6A057F for ; Tue, 28 Jun 2022 17:19:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01B5E40DF7; Tue, 28 Jun 2022 17:19:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2F20C40042 for ; Tue, 28 Jun 2022 17:19:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656429591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lpNhGNaFRDwCoEw/5uU9x4irjr/JnUBczRwB0r0YIt8=; b=dy7q96UD+Y4Ayn7Deh3ZGnLJ71WDJS1fIVOqXyE6KKcRx2Kvjjr6DY7rxx6SjHM/gYWcm5 fidPuDkU1CZN7Q1iixdopEdiNzI0FjdeOIiD9l04IV8nETwo+PJFqBKbe7ePbJ+JqK+/H5 Pbpj6GQuyG8t9jWBE6xY8ShJ9YmoscA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-I6TjROgtMCi4i-35dPbhlg-1; Tue, 28 Jun 2022 11:19:48 -0400 X-MC-Unique: I6TjROgtMCi4i-35dPbhlg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 472591019C91; Tue, 28 Jun 2022 15:19:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E1B11410DD8; Tue, 28 Jun 2022 15:19:47 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Yu Jiang , dpdk stable Subject: patch 'dma/idxd: fix non-AVX builds with old compilers' has been queued to stable release 21.11.2 Date: Tue, 28 Jun 2022 16:19:16 +0100 Message-Id: <20220628151938.2278711-4-ktraynor@redhat.com> In-Reply-To: <20220628151938.2278711-1-ktraynor@redhat.com> References: <20220628151938.2278711-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1b31f49983824786d4c579fd71c80da10faf376a Thanks. Kevin --- >From 1b31f49983824786d4c579fd71c80da10faf376a Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 23 Jun 2022 14:49:33 +0100 Subject: [PATCH] dma/idxd: fix non-AVX builds with old compilers [ upstream commit 86f89b626b7ccb250b7688559922e942f413d0a0 ] When building without AVX2 support using an older compiler e.g. gcc 4.8 on Centos/RHEL 7, we get build errors due to the use of AVX2 intrinsics. This is because the compiler does not support "__attribute__((target(AVX2)))" function attribute. Disable build of this driver such edge cases. Generic builds using recent compilers, and all builds with a minimum baseline of AVX2 are unaffected by this change. Fixes: aa802b10237c ("dma/idxd: fix AVX2 in non-datapath functions") Signed-off-by: Bruce Richardson Tested-by: Yu Jiang --- drivers/dma/idxd/meson.build | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/dma/idxd/meson.build b/drivers/dma/idxd/meson.build index dcc0a297d7..c5403b431c 100644 --- a/drivers/dma/idxd/meson.build +++ b/drivers/dma/idxd/meson.build @@ -5,4 +5,15 @@ build = dpdk_conf.has('RTE_ARCH_X86') reason = 'only supported on x86' +test_avx2_code = ''' +#include +__attribute__((target("avx2"))) +__m256i fn(void *x) { return _mm256_loadu_si256(x); } +''' +if build and not cc.compiles(test_avx2_code, args:machine_args) + build = false + reason = 'missing support for AVX2 function attribute' + subdir_done() +endif + deps += ['bus_pci'] sources = files( -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-28 16:18:04.150368619 +0100 +++ 0004-dma-idxd-fix-non-AVX-builds-with-old-compilers.patch 2022-06-28 16:18:03.999387177 +0100 @@ -1 +1 @@ -From 86f89b626b7ccb250b7688559922e942f413d0a0 Mon Sep 17 00:00:00 2001 +From 1b31f49983824786d4c579fd71c80da10faf376a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 86f89b626b7ccb250b7688559922e942f413d0a0 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org