From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61445A0540 for ; Wed, 6 Jul 2022 22:36:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C5134280E; Wed, 6 Jul 2022 22:36:08 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 963D640FAE for ; Wed, 6 Jul 2022 22:36:07 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id cl1so23625060wrb.4 for ; Wed, 06 Jul 2022 13:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=drvub31eM5HeMAopk0OxLgf1IwSP9bVo7PgUW1I1hGY=; b=hkn8gqYA3hgtRpU9ceAMPFcYz4bBrxlJi7thjXSEOTq5srRIW2kegQBfC72ryFovPu FMwYA1aLiFKXjaU+joh87Lh8msTSwFlc59W5ASDwgMUoruXKGv9pKdXc5+F8918xFWE8 VdDxrXDIVcbPx779Ku8SqAiPQJA8I88pScwvCQiDAkbedeyxFtg7nttKiqM77Q7q8plg xri2X1QSxmzszaywrYaGqc/S9WSfs2RDLRfawn58OfnHOv6oRVRu20rRYUz0X5Mr51gK /T7RRbQDD7ssfUOQcSZKhfU6zyzHqEDcwYPr6ROCh09qQO6VZbnDKccQ/BAefDZEfny4 2hGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=drvub31eM5HeMAopk0OxLgf1IwSP9bVo7PgUW1I1hGY=; b=bABaxeD/xrvqLYRkoB0QLL+BQIbY/bGI3t6SdPvCI7iWX+XR8JKcaaDURiMcye2lnf Eu1ISaTwIVy9TM7+onXAwwcf/SaXsFsgIQczWVAHdKVBJm4DOVa6CoBn1wcF+FKWHFpi 0VH0NKEhfuWoTx6/C4L852GMvRfj0weVOvQGNLLWqyXKJlmvQxTmCluu7Nj4ZsVqWmkf ih6OKh7eZ7q0W7RYyXu1cxWirOyWnWVkdUO/6z40i2wwJVlMGGMspkDPwAT3qJxfGzh0 rrb1+HpxC/NRrXi9MCqngsRw1DBV6EL8CoOrN0N28Q0q8p2c24JgrafccV8l7cZA2m6h yBLQ== X-Gm-Message-State: AJIora+4i/6nHeGWTnbjDS3uzVyWmMOpYcVvujaU/dFSAy4+O+7ZnPnC OpZga2kmWuQB4SLgU0S8KP4= X-Google-Smtp-Source: AGRyM1tqa3Yxe0iiF8nx6F64/awhWOgHBfK0zSrMl+ODK1jTaxnkENK3cG3UVwxzXq3iwkwhHSXcyA== X-Received: by 2002:a5d:6da3:0:b0:21b:aaf5:b814 with SMTP id u3-20020a5d6da3000000b0021baaf5b814mr38695469wrs.140.1657139767309; Wed, 06 Jul 2022 13:36:07 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id j31-20020a05600c1c1f00b003a18d352893sm18897865wms.42.2022.07.06.13.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 13:36:06 -0700 (PDT) From: luca.boccassi@gmail.com To: Zhichao Zeng Cc: Qi Zhang , dpdk stable Subject: patch 'net/igc: support multi-process' has been queued to stable release 21.11.2 Date: Wed, 6 Jul 2022 21:34:55 +0100 Message-Id: <20220706203506.3422496-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706203506.3422496-1-luca.boccassi@gmail.com> References: <20220628151938.2278711-26-ktraynor@redhat.com> <20220706203506.3422496-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/08/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/399cbc736cae28ec9707fc26d3f159791ad4d5dd Thanks. Luca Boccassi --- >From 399cbc736cae28ec9707fc26d3f159791ad4d5dd Mon Sep 17 00:00:00 2001 From: Zhichao Zeng Date: Thu, 30 Jun 2022 19:03:30 +0800 Subject: [PATCH] net/igc: support multi-process [ upstream commit e097bf80e418b03eea1b032a37b71097b4cf0a89 ] The Rx function was not specified in the secondary process, causing the secondary process to segfault in a multi-process environment. This patch specify RX/TX functions in "dev_init" to support secondary processes. Fixes: 66fde1b943eb ("net/igc: add skeleton") Signed-off-by: Zhichao Zeng Acked-by: Qi Zhang --- drivers/net/igc/igc_ethdev.c | 9 ++++++++- drivers/net/igc/igc_txrx.c | 8 ++++---- drivers/net/igc/igc_txrx.h | 6 ++++++ 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index a1f1a9772b..8d8a0da424 100644 --- a/drivers/net/igc/igc_ethdev.c +++ b/drivers/net/igc/igc_ethdev.c @@ -1234,8 +1234,15 @@ eth_igc_dev_init(struct rte_eth_dev *dev) * has already done this work. Only check we don't need a different * RX function. */ - if (rte_eal_process_type() != RTE_PROC_PRIMARY) + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { + dev->rx_pkt_burst = igc_recv_pkts; + if (dev->data->scattered_rx) + dev->rx_pkt_burst = igc_recv_scattered_pkts; + + dev->tx_pkt_burst = igc_xmit_pkts; + dev->tx_pkt_prepare = eth_igc_prep_pkts; return 0; + } rte_eth_copy_pci_info(dev, pci_dev); dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c index e48d5df11a..ffd219b0df 100644 --- a/drivers/net/igc/igc_txrx.c +++ b/drivers/net/igc/igc_txrx.c @@ -345,7 +345,7 @@ rx_desc_get_pkt_info(struct igc_rx_queue *rxq, struct rte_mbuf *rxm, rxm->packet_type = rx_desc_pkt_info_to_pkt_type(pkt_info); } -static uint16_t +uint16_t igc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) { struct igc_rx_queue * const rxq = rx_queue; @@ -488,7 +488,7 @@ igc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) return nb_rx; } -static uint16_t +uint16_t igc_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) { @@ -1397,7 +1397,7 @@ eth_igc_rx_queue_setup(struct rte_eth_dev *dev, } /* prepare packets for transmit */ -static uint16_t +uint16_t eth_igc_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) { @@ -1604,7 +1604,7 @@ tx_desc_cksum_flags_to_olinfo(uint64_t ol_flags) return tmp; } -static uint16_t +uint16_t igc_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) { struct igc_tx_queue * const txq = tx_queue; diff --git a/drivers/net/igc/igc_txrx.h b/drivers/net/igc/igc_txrx.h index 535108a868..02a0a051bb 100644 --- a/drivers/net/igc/igc_txrx.h +++ b/drivers/net/igc/igc_txrx.h @@ -49,6 +49,12 @@ void eth_igc_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, struct rte_eth_txq_info *qinfo); void eth_igc_vlan_strip_queue_set(struct rte_eth_dev *dev, uint16_t rx_queue_id, int on); +uint16_t igc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts); +uint16_t igc_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts); +uint16_t eth_igc_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, + uint16_t nb_pkts); +uint16_t igc_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, + uint16_t nb_pkts); #ifdef __cplusplus } #endif -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-06 21:07:54.245875484 +0100 +++ 0020-net-igc-support-multi-process.patch 2022-07-06 21:07:53.555518938 +0100 @@ -1 +1 @@ -From e097bf80e418b03eea1b032a37b71097b4cf0a89 Mon Sep 17 00:00:00 2001 +From 399cbc736cae28ec9707fc26d3f159791ad4d5dd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e097bf80e418b03eea1b032a37b71097b4cf0a89 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index b9933b395d..7f221a5d34 100644 +index a1f1a9772b..8d8a0da424 100644 @@ -27 +28 @@ -@@ -1240,8 +1240,15 @@ eth_igc_dev_init(struct rte_eth_dev *dev) +@@ -1234,8 +1234,15 @@ eth_igc_dev_init(struct rte_eth_dev *dev)