From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C49AA0540 for ; Wed, 6 Jul 2022 22:35:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3688D40691; Wed, 6 Jul 2022 22:35:26 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 4E20A410E5 for ; Wed, 6 Jul 2022 22:35:23 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id g39-20020a05600c4ca700b003a03ac7d540so12239145wmp.3 for ; Wed, 06 Jul 2022 13:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ydOzniGWdQY5s1rw9tjBjs4b/SjewK/fhKku621Xd+Y=; b=L5GnbhaULFQruqWbBZ1s5fUuew7qK1fbh0d5U6UyMcBlq5HBo0QW83KoD8BGtO9MXS YdBeEz23WtfE9DdzsK5PA1kXznPtSL1wha5bqOKzYNQbytDP8yIpFGMSmcQjVLiaHHq2 g7yufLxVREJ11Oz21ww0tJewJeZxpD1ie9wbIRDwnijhuGmsVsRVrK1B/UmvM1ZZpSNa sdETLvLEU7VkLjzhe4iXVy6+I9V7DknEVfX/tCCG+IUs6onOftzfUVT13diwBTyOgPTa XfpTKBfOavATSUAHE+7hNG8Uie/iN4XEl7yqE92rE1ZojGhTpYdk6EXMO1sfrOPzKIhF 6RKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ydOzniGWdQY5s1rw9tjBjs4b/SjewK/fhKku621Xd+Y=; b=5cd4fVFsWoJrbKzkPUsS/vZKacDmyduwRmcCPEoQK/xATLmdeLBcUt77nsX3dpc9Dl Dh7rEKF0FBBjrPvJwB+kdLUPfLOTUIdUaFd2JPKNe9/6HJnHNsGOzvCcgTFaluAnwgjB nQjBUUhjMdnBFStVqzahbcxqm7ZzuQF1hMPSQDQzCcH/4e1URAkb/MxTGmh+JpcalTlx +0uU44oe4iTQIycQ9kJgwLNve04DX8G2uKbnjT8FiJWyMw0U3EDjIFm/V9bkDIU5A0/M iHiInxnzoCOOhgEIrFnOsh1hSgZCakoFsTJ9UaQp2Fp/00swfGLWnxYW6jq9iQ82/ZnB 9BMg== X-Gm-Message-State: AJIora+/Kqo4Gc7+btosLuxw5EX+EZfCMpdQ0VzPeP+eJUXXLn8gaiGH H0I0rZ9fHzOeDMyuj9o39eVd5n83BAZL1g== X-Google-Smtp-Source: AGRyM1t4GGcqkceAn5jZo8Ww6w7YTLe7PicHXsEbSOgHr1bKFFuyza8y5m+muEtuRtgvOLIS/KOLsg== X-Received: by 2002:a05:600c:1c0d:b0:3a0:4d2a:1862 with SMTP id j13-20020a05600c1c0d00b003a04d2a1862mr447704wms.198.1657139723055; Wed, 06 Jul 2022 13:35:23 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c4ece00b0039c99f61e5bsm26267040wmq.5.2022.07.06.13.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 13:35:22 -0700 (PDT) From: luca.boccassi@gmail.com To: Rebecca Troy Cc: Fan Zhang , dpdk stable Subject: patch 'crypto/qat: fix DOCSIS crash' has been queued to stable release 21.11.2 Date: Wed, 6 Jul 2022 21:34:40 +0100 Message-Id: <20220706203506.3422496-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706203506.3422496-1-luca.boccassi@gmail.com> References: <20220628151938.2278711-26-ktraynor@redhat.com> <20220706203506.3422496-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/08/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8017591016087a62c4bcc52ec7207ab6e342f50c Thanks. Luca Boccassi --- >From 8017591016087a62c4bcc52ec7207ab6e342f50c Mon Sep 17 00:00:00 2001 From: Rebecca Troy Date: Wed, 29 Jun 2022 16:10:36 +0000 Subject: [PATCH] crypto/qat: fix DOCSIS crash [ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] Currently if AES or DES algorithms fail for DOCSIS test suite, a segmentation fault occurs when cryptodev_qat_autotest is ran. This is due to a duplicate call of EVP_CIPHER_CTX_free for the session context. Ctx is freed firstly in the bpi_cipher_ctx_init function and then again at the end of qat_sym_session_configure_cipher function. This commit fixes this bug by removing the first instance of EVP_CIPHER_CTX_free, leaving just the dedicated function in the upper level to free the ctx. Fixes: 98f060891615 ("crypto/qat: add symmetric session file") Signed-off-by: Rebecca Troy Acked-by: Fan Zhang --- drivers/crypto/qat/qat_sym_session.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index f439bbd0f1..80d6fbfa46 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -126,8 +126,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, return 0; ctx_init_err: - if (*ctx != NULL) + if (*ctx != NULL) { EVP_CIPHER_CTX_free(*ctx); + *ctx = NULL; + } return ret; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-06 21:07:53.745612157 +0100 +++ 0005-crypto-qat-fix-DOCSIS-crash.patch 2022-07-06 21:07:53.527518400 +0100 @@ -1 +1 @@ -From 03f0e3608d44d468b22ed17c30144d87edeb3ee9 Mon Sep 17 00:00:00 2001 +From 8017591016087a62c4bcc52ec7207ab6e342f50c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index e40c042ba9..b30396487e 100644 +index f439bbd0f1..80d6fbfa46 100644 @@ -31 +32 @@ -@@ -136,8 +136,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, +@@ -126,8 +126,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo,