From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB4E2A054A for ; Tue, 25 Oct 2022 17:08:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D80D342C4F; Tue, 25 Oct 2022 17:08:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E8B6942C5B for ; Tue, 25 Oct 2022 17:08:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EUihrBB+5G3AEO3Exc1GjZi9mxtoByT5kLiOxbm1uIU=; b=DArfFH4Px2hVXWHD7gUl2w1VaEjEIsiC8hvvMx+tIUODa0BEcUjnNp+2mZD02MP1Xqs3p6 V/ppGsIqtIXQ6qNqFGXPnaGYDzevzlKzH8Tj3UViFHOqMP5IIhphJF5hoHdPQ7FLzPVjnd 9oQPxenVI6476uKNZ06dZA//O4ULLAE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-248-GYo4jl3vN-Kjzrw7YGtP8w-1; Tue, 25 Oct 2022 11:08:30 -0400 X-MC-Unique: GYo4jl3vN-Kjzrw7YGtP8w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F23EC38149B6; Tue, 25 Oct 2022 15:08:22 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26E06477F55; Tue, 25 Oct 2022 15:08:21 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: remove semaphore between SW/FW' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:12 +0100 Message-Id: <20221025150734.142189-17-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/982225e1bba5ad3d4225ac48c8e31316b768852a Thanks. Kevin --- >From 982225e1bba5ad3d4225ac48c8e31316b768852a Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 2 Sep 2022 11:00:05 +0800 Subject: [PATCH] net/txgbe: remove semaphore between SW/FW [ upstream commit 61b7a046e260897329a648b1c0e72032b5fbe685 ] Since firmware does not use the semaphore between software and firmware. Remove useless unilateral semaphore setting. Fixes: 35c90ecccfd4 ("net/txgbe: add EEPROM functions") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.c | 32 --------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_eeprom.c b/drivers/net/txgbe/base/txgbe_eeprom.c index 4ed6bd6728..aeeae06dfc 100644 --- a/drivers/net/txgbe/base/txgbe_eeprom.c +++ b/drivers/net/txgbe/base/txgbe_eeprom.c @@ -112,35 +112,4 @@ s32 txgbe_get_eeprom_semaphore(struct txgbe_hw *hw) } - /* Now get the semaphore between SW/FW through the SWESMBI bit */ - if (status == 0) { - for (i = 0; i < timeout; i++) { - /* Set the SW EEPROM semaphore bit to request access */ - wr32m(hw, TXGBE_MNGSWSYNC, - TXGBE_MNGSWSYNC_REQ, TXGBE_MNGSWSYNC_REQ); - - /* - * If we set the bit successfully then we got the - * semaphore. - */ - swsm = rd32(hw, TXGBE_MNGSWSYNC); - if (swsm & TXGBE_MNGSWSYNC_REQ) - break; - - usec_delay(50); - } - - /* - * Release semaphores and return error if SW EEPROM semaphore - * was not granted because we don't have access to the EEPROM - */ - if (i >= timeout) { - DEBUGOUT("SWESMBI Software EEPROM semaphore not granted."); - txgbe_release_eeprom_semaphore(hw); - status = TXGBE_ERR_EEPROM; - } - } else { - DEBUGOUT("Software semaphore SMBI between device drivers not granted."); - } - return status; } @@ -154,5 +123,4 @@ s32 txgbe_get_eeprom_semaphore(struct txgbe_hw *hw) void txgbe_release_eeprom_semaphore(struct txgbe_hw *hw) { - wr32m(hw, TXGBE_MNGSWSYNC, TXGBE_MNGSWSYNC_REQ, 0); wr32m(hw, TXGBE_SWSEM, TXGBE_SWSEM_PF, 0); txgbe_flush(hw); -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:58.951770912 +0100 +++ 0017-net-txgbe-remove-semaphore-between-SW-FW.patch 2022-10-25 14:18:58.366797930 +0100 @@ -1 +1 @@ -From 61b7a046e260897329a648b1c0e72032b5fbe685 Mon Sep 17 00:00:00 2001 +From 982225e1bba5ad3d4225ac48c8e31316b768852a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 61b7a046e260897329a648b1c0e72032b5fbe685 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org