From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0175DA054A for ; Tue, 25 Oct 2022 17:08:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB6CA42C54; Tue, 25 Oct 2022 17:08:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A5A2C42C4E for ; Tue, 25 Oct 2022 17:08:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qNBbFvLDZLdCqETI+cpvEHpiDV709OONJLGhsfUkYFc=; b=JMMMN04jl/dfwzEK8yWrfpY1MOT8QqnzRCY5+sh78294bZR7N5BLekonPTvbv+7m7ySb++ fFisgDVofeTkYYX+v2SriHLIWzRHFATEDGXYP2TUkIB0azUFpzMjRzRkw52IPioTyLaJ4i hvo+D1qhfrDUMwwBnEG4RrrsMH2an+M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-Gp4y2kqmOGiHULzxx2c9VQ-1; Tue, 25 Oct 2022 11:08:26 -0400 X-MC-Unique: Gp4y2kqmOGiHULzxx2c9VQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 479A010115EF; Tue, 25 Oct 2022 15:08:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89A1E477F5C; Tue, 25 Oct 2022 15:08:25 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: remove semaphore between SW/FW' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:15 +0100 Message-Id: <20221025150734.142189-20-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/60df2778b9877bd09ce934eb416181b510e2266f Thanks. Kevin --- >From 60df2778b9877bd09ce934eb416181b510e2266f Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 2 Sep 2022 11:00:08 +0800 Subject: [PATCH] net/ngbe: remove semaphore between SW/FW [ upstream commit c18385220f776855a1b2eb798d44068d8fa2bd6d ] Since firmware does not use the semaphore between software and firmware. Remove useless unilateral semaphore setting. Fixes: f501a195bded ("net/ngbe: initialize and validate EEPROM") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_eeprom.c | 32 ----------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/net/ngbe/base/ngbe_eeprom.c b/drivers/net/ngbe/base/ngbe_eeprom.c index 6375ee9b29..104501fa7a 100644 --- a/drivers/net/ngbe/base/ngbe_eeprom.c +++ b/drivers/net/ngbe/base/ngbe_eeprom.c @@ -106,35 +106,4 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw) } - /* Now get the semaphore between SW/FW through the SWESMBI bit */ - if (status == 0) { - for (i = 0; i < timeout; i++) { - /* Set the SW EEPROM semaphore bit to request access */ - wr32m(hw, NGBE_MNGSWSYNC, - NGBE_MNGSWSYNC_REQ, NGBE_MNGSWSYNC_REQ); - - /* - * If we set the bit successfully then we got the - * semaphore. - */ - swsm = rd32(hw, NGBE_MNGSWSYNC); - if (swsm & NGBE_MNGSWSYNC_REQ) - break; - - usec_delay(50); - } - - /* - * Release semaphores and return error if SW EEPROM semaphore - * was not granted because we don't have access to the EEPROM - */ - if (i >= timeout) { - DEBUGOUT("SWESMBI Software EEPROM semaphore not granted."); - ngbe_release_eeprom_semaphore(hw); - status = NGBE_ERR_EEPROM; - } - } else { - DEBUGOUT("Software semaphore SMBI between device drivers not granted."); - } - return status; } @@ -148,5 +117,4 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw) void ngbe_release_eeprom_semaphore(struct ngbe_hw *hw) { - wr32m(hw, NGBE_MNGSWSYNC, NGBE_MNGSWSYNC_REQ, 0); wr32m(hw, NGBE_SWSEM, NGBE_SWSEM_PF, 0); ngbe_flush(hw); -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.017151746 +0100 +++ 0020-net-ngbe-remove-semaphore-between-SW-FW.patch 2022-10-25 14:18:58.375797962 +0100 @@ -1 +1 @@ -From c18385220f776855a1b2eb798d44068d8fa2bd6d Mon Sep 17 00:00:00 2001 +From 60df2778b9877bd09ce934eb416181b510e2266f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c18385220f776855a1b2eb798d44068d8fa2bd6d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org