From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FB7DA054A for ; Tue, 25 Oct 2022 17:08:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BDB842C4F; Tue, 25 Oct 2022 17:08:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E64E842C34 for ; Tue, 25 Oct 2022 17:08:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fR2PHuLRam4Z+TM2+bq/i0SIhs1IgGpn0nMMpiOJbEM=; b=dQY4mc3g+Ii7cWi/XVjihSHN9qCQ7celiW0oxCpqiJ4hpDNrUllRpmRZ8vHyOUtU/eRRHz e0PsyW2O3WMYDl7vDPbpso6TlXXR+BWbjz3yJXsXdrPHtVH6kHwCZhxOApwfdiAzTxMtEq QT01FKPQ646Z4pYKE/bOFchjE0cK57g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-X8IufzvyPLeFegekkTJqng-1; Tue, 25 Oct 2022 11:08:33 -0400 X-MC-Unique: X8IufzvyPLeFegekkTJqng-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0EC61823F78; Tue, 25 Oct 2022 15:08:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3682A4A9254; Tue, 25 Oct 2022 15:08:29 +0000 (UTC) From: Kevin Traynor To: Amit Prakash Shukla Cc: Liron Himi , dpdk stable Subject: patch 'net/mvneta: fix build with GCC 12' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:18 +0100 Message-Id: <20221025150734.142189-23-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6d030554f1a6a0f2d82bb3371ebb1c5458a49491 Thanks. Kevin --- >From 6d030554f1a6a0f2d82bb3371ebb1c5458a49491 Mon Sep 17 00:00:00 2001 From: Amit Prakash Shukla Date: Thu, 1 Sep 2022 14:01:18 +0530 Subject: [PATCH] net/mvneta: fix build with GCC 12 [ upstream commit d7b080f1e72d833d668a66199fe99ccda6c81a36 ] ./drivers/net/mvneta/mvneta_rxtx.c:89:42: error: 'mbufs' may be used uninitialized [-Werror=maybe-uninitialized] 89 | MVNETA_SET_COOKIE_HIGH_ADDR(mbufs[0]); | ^ ../drivers/net/mvneta/mvneta_rxtx.c:77:26: note: 'mbufs' declared here 77 | struct rte_mbuf *mbufs[MRVL_NETA_BUF_RELEASE_BURST_SIZE_MAX]; | ^~~~~ Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") Signed-off-by: Amit Prakash Shukla Acked-by: Liron Himi --- drivers/net/mvneta/mvneta_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvneta/mvneta_rxtx.c b/drivers/net/mvneta/mvneta_rxtx.c index 6e4a7896b4..952e982275 100644 --- a/drivers/net/mvneta/mvneta_rxtx.c +++ b/drivers/net/mvneta/mvneta_rxtx.c @@ -80,4 +80,8 @@ mvneta_buffs_refill(struct mvneta_priv *priv, struct mvneta_rxq *rxq, u16 *num) uint16_t nb_desc = *num; + /* To prevent GCC-12 warning. */ + if (unlikely(nb_desc == 0)) + return -1; + ret = rte_pktmbuf_alloc_bulk(rxq->mp, mbufs, nb_desc); if (ret) { -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.081045507 +0100 +++ 0023-net-mvneta-fix-build-with-GCC-12.patch 2022-10-25 14:18:58.378797973 +0100 @@ -1 +1 @@ -From d7b080f1e72d833d668a66199fe99ccda6c81a36 Mon Sep 17 00:00:00 2001 +From 6d030554f1a6a0f2d82bb3371ebb1c5458a49491 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d7b080f1e72d833d668a66199fe99ccda6c81a36 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org