From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B783A054A for ; Tue, 25 Oct 2022 17:08:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37CE842C3C; Tue, 25 Oct 2022 17:08:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 091FB42C48 for ; Tue, 25 Oct 2022 17:08:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=obtXQXoCkiKW1SlM6vDypY/thQxFJjaPQvk2us0sUkU=; b=EZUCgXj0+i5u+WatRW4jfHddoqfc7tCGupk2T1ydh2rFrS41HnkN5jXtRf6qvGOg6sSm9+ cD8GtPJmaCXA2bItRtnSIBxzoqnDUSeMnd9nv1od1uWqCbV5cNX/GVMQBq5Dg2WPSZHHwo BpDdmjE19rYOik+IWIKpa4oB8cWO4W4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-r85nn9s3NXKZW9o7Hu_jOA-1; Tue, 25 Oct 2022 11:08:41 -0400 X-MC-Unique: r85nn9s3NXKZW9o7Hu_jOA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ABCC21818234; Tue, 25 Oct 2022 15:08:40 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2C964A9254; Tue, 25 Oct 2022 15:08:39 +0000 (UTC) From: Kevin Traynor To: Naga Harish K S V Cc: Jay Jayatheerthan , dpdk stable Subject: patch 'eventdev/eth_tx: fix adapter stop' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:25 +0100 Message-Id: <20221025150734.142189-30-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a003adfe324f71f8f26c3b4c7b586901883c6c6f Thanks. Kevin --- >From a003adfe324f71f8f26c3b4c7b586901883c6c6f Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Mon, 25 Jul 2022 23:22:11 -0500 Subject: [PATCH] eventdev/eth_tx: fix adapter stop [ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] adapter_stop function is stopping the adapter service using rte_service_runstate_set() API and waiting until rte_service_may_be_active() API returns stopped state in an infinite loop. This results in hang issues if application calls rte_service_lcore_stop() before adapter stop. Remove the state check after setting the service state which avoids running into hang issues. This also makes Tx adapter stop inline with remaining adapters. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_event_eth_tx_adapter.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 6730345e4c..78418744ca 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -476,8 +476,4 @@ txa_service_ctrl(uint8_t id, int start) rte_spinlock_unlock(&txa->tx_lock); - if (ret == 0 && !start) { - while (rte_service_may_be_active(txa->service_id)) - rte_pause(); - } return ret; } -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.227994213 +0100 +++ 0030-eventdev-eth_tx-fix-adapter-stop.patch 2022-10-25 14:18:58.384797994 +0100 @@ -1 +1 @@ -From fbb9f7e215c3394681ab1292f421c4e5c4880392 Mon Sep 17 00:00:00 2001 +From a003adfe324f71f8f26c3b4c7b586901883c6c6f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index aa7713bfa1..7e82fe030c 100644 +index 6730345e4c..78418744ca 100644 @@ -31 +32 @@ -@@ -510,8 +510,4 @@ txa_service_ctrl(uint8_t id, int start) +@@ -476,8 +476,4 @@ txa_service_ctrl(uint8_t id, int start)